sarman/tftsr-devops_investigation
1
1
Fork 0
Code Issues 4 Pull Requests Actions 36 Packages Projects 3 Releases 6 Wiki Activity

fix: register missing updater commands #99

Merged
sarman merged 1 commits from fix/updater-issues into beta 2026-06-14 03:38:49 +00:00
Conversation 0 Commits 1 Files Changed 2 +17
sarman commented 2026-06-14 00:42:07 +00:00
Owner
Copy Link
  • Add check_app_updates, install_app_updates, get_update_channel, set_update_channel to Tauri handler
  • Add unit tests for update channel functionality

This fixes the 'Command check_app_updates not found' and 'Failed to update channel' errors reported in the latest build.

- Add check_app_updates, install_app_updates, get_update_channel, set_update_channel to Tauri handler - Add unit tests for update channel functionality This fixes the 'Command check_app_updates not found' and 'Failed to update channel' errors reported in the latest build.
sarman added 1 commit 2026-06-14 00:42:08 +00:00
fix: register missing updater commands
All checks were successful
Test / frontend-tests (pull_request) Successful in 1m45s
Details
Test / frontend-typecheck (pull_request) Successful in 1m54s
Details
PR Review Automation / review (pull_request) Successful in 4m11s
Details
Test / rust-fmt-check (pull_request) Successful in 13m22s
Details
Test / rust-clippy (pull_request) Successful in 15m5s
Details
Test / rust-tests (pull_request) Successful in 17m15s
Details
2fae73fb3a 
- Add check_app_updates, install_app_updates, get_update_channel, set_update_channel to Tauri handler
- Add unit tests for update channel functionality

This fixes the 'Command check_app_updates not found' and 'Failed to update channel' errors reported in the latest build.
sarman reviewed 2026-06-14 00:46:17 +00:00
sarman left a comment
Author
Owner
Copy Link

Automated PR Review (qwen3-coder-next via liteLLM):\n\nSummary

The PR adds four previously-unregistered Tauri commands (check_app_updates, install_app_updates, get_update_channel, set_update_channel) to the generate_handler! macro in lib.rs, and implements the Rust command handlers in system.rs. Unit tests were added for the update channel functionality.

After reviewing all changed files and the codebase index:

  1. The Rust command functions already exist and are correctly implemented in commands/system.rs.
  2. The generate_handler! macro in lib.rs now includes all four new commands.
  3. The TypeScript invoke wrappers (checkAppUpdatesCmd, etc.) already exist in src/lib/tauriCommands.ts, indicating the frontend-side contract is already established.
  4. All commands appear in the Registered Tauri commands list in the codebase index — confirming they were already declared in the handler before this PR (or are now correctly added by it).

No compilation errors, logic errors, or security issues are present in the changes.

Findings

No findings.

Verdict: APPROVE

Automated PR Review (qwen3-coder-next via liteLLM):\n\n**Summary** The PR adds four previously-unregistered Tauri commands (`check_app_updates`, `install_app_updates`, `get_update_channel`, `set_update_channel`) to the `generate_handler!` macro in `lib.rs`, and implements the Rust command handlers in `system.rs`. Unit tests were added for the update channel functionality. After reviewing all changed files and the codebase index: 1. The Rust command functions already exist and are correctly implemented in `commands/system.rs`. 2. The `generate_handler!` macro in `lib.rs` now includes all four new commands. 3. The TypeScript invoke wrappers (`checkAppUpdatesCmd`, etc.) already exist in `src/lib/tauriCommands.ts`, indicating the frontend-side contract is already established. 4. All commands appear in the **Registered Tauri commands** list in the codebase index — confirming they were already declared in the handler before this PR (or are now correctly added by it). No compilation errors, logic errors, or security issues are present in the changes. **Findings** No findings. **Verdict**: APPROVE
sarman merged commit f2aa75061b into beta 2026-06-14 03:38:49 +00:00
sarman deleted branch fix/updater-issues 2026-06-14 03:38:49 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sarman/tftsr-devops_investigation#99
No description provided.
Delete Branch "fix/updater-issues"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?