f2a795772c
The Tauri v2 IPC layer expects camelCase parameter names. The frontend was sending cluster_type (snake_case), causing the deserialization failure with error 'command add_proxmox_cluster missing required key clusterType'. Changed proxmoxClient.ts line 28 from: cluster_type: clusterType to: clusterType This aligns with the project's convention where all multi-word parameters use camelCase (clusterId, nodeId, vmId, etc.). Fixes the 'Failed to add remote' error when adding new Proxmox remotes.
2.9 KiB
Ticket: Fix Proxmox Add Remote Failure
Description
Clicking "Add Remote" in the Proxmox Remotes page always produces the error dialog "Add New Remote / Error / Failed to add remote" regardless of what credentials are entered. The root cause is a chain of three bugs:
-
password: &strin async Tauri v2 command (src-tauri/src/commands/proxmox.rs): Tauri v2 requires command parameters to implementDeserializeOwned + Send.&stris lifetime-bound and does not implementDeserializeOwned, so the IPC layer fails to deserialize the payload at runtime — the command body never runs. -
Generic error fallback in frontend (
src/components/Proxmox/AddRemoteForm.tsx): The catch block useserr instanceof Error ? err.message : 'Failed to add remote'. Tauri errors arrive as plain strings, notErrorobjects, so the fallback branch always fires and the real error is hidden. -
Missing protocol/port in
ProxmoxClientURL builder (src-tauri/src/proxmox/client.rs): The frontend strips the protocol viaparseRemoteUrlbefore sending just the bare hostname.get_api_url()andauthenticate()were constructing URLs like"172.0.0.18/api2/json/..."— no scheme, no port — meaning all subsequent Proxmox API calls (VMs, containers, etc.) would silently fail even after a successful add.
Acceptance Criteria
- Submitting the Add Remote form with valid credentials stores the remote and closes the dialog.
- Submitting with invalid credentials shows the actual backend error string, not the generic fallback.
- All existing Rust tests pass (416).
cargo clippy -- -D warnings,tsc --noEmit,eslint --max-warnings 0all pass.- Proxmox API calls (VMs, containers) use correctly formed
https://{host}:{port}/api2/json/...URLs.
Work Implemented
Branch: fix/proxmox-add-remote → beta | PR: #122
| File | Change |
|---|---|
src-tauri/src/commands/proxmox.rs |
password: &str → password: String (line 41) |
src-tauri/src/proxmox/client.rs |
get_api_url() now produces https://{host}:{port}/api2/json/...; same for authenticate(); tests updated to reflect bare-hostname input |
src/components/Proxmox/AddRemoteForm.tsx |
err instanceof Error ? err.message : 'Failed to add remote' → String(err) |
Testing Needed
- Build and run the app (
cargo tauri devor install release binary). - Navigate to Proxmox → Remotes.
- Click Add Remote, fill in a valid hostname (e.g.,
https://172.0.1.42:8006), usernameroot@pam, password, type PVE. - Confirm the dialog closes and the remote appears in the list.
- Repeat with a wrong password — confirm the actual Tauri error message is shown in the dialog (not the generic fallback).
- Navigate to a cluster's VM or container list to confirm Proxmox API calls form correct URLs.