Some checks failed
Test / frontend-tests (pull_request) Successful in 1m38s
Test / frontend-typecheck (pull_request) Successful in 1m46s
PR Review Automation / review (pull_request) Successful in 5m37s
Test / rust-fmt-check (pull_request) Failing after 12m26s
Test / rust-clippy (pull_request) Successful in 13m43s
Test / rust-tests (pull_request) Successful in 16m4s
- Storage: prevent double-slash ID when cluster/resources returns
shared storage without a node field (e.g. "storage//PBS_TFTSR"
→ "storage/PBS_TFTSR")
- Firewall: add comment explaining why rule_num is omitted from
add_rule — PVE assigns position (pos) automatically on creation
- Network: replace misleading "implementation pending" toasts with
an immediate warning; dialog no longer opens since backend commands
(POST/PUT/DELETE nodes/{node}/network) are not yet implemented
- Backup: same treatment for New Job — warns immediately instead of
opening a form that silently does nothing
- VMList: add comment explaining handleVMAction receives clusterId
from props (not a stale closure over state); add inline comment
clarifying the migration button disabled conditions
253 lines
9.8 KiB
TypeScript
253 lines
9.8 KiB
TypeScript
import React, { useState, useEffect, useCallback } from 'react';
|
|
import { Card, CardContent, CardHeader, CardTitle } from '@/components/ui/index';
|
|
import { Button } from '@/components/ui/index';
|
|
import { Badge } from '@/components/ui/index';
|
|
import { RefreshCw, Network, Plus, Edit, Trash2 } from 'lucide-react';
|
|
import { listNetworkInterfaces, listProxmoxClusters, NetworkInterface } from '@/lib/proxmoxClient';
|
|
import { Dialog, DialogContent, DialogHeader, DialogTitle, DialogFooter } from '@/components/ui/index';
|
|
import { Input } from '@/components/ui/index';
|
|
import { Label } from '@/components/ui/index';
|
|
import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from '@/components/ui/index';
|
|
import { toast } from 'sonner';
|
|
|
|
export function ProxmoxNetworkPage() {
|
|
const [interfaces, setInterfaces] = useState<NetworkInterface[]>([]);
|
|
const [clusterId, setClusterId] = useState('');
|
|
const [nodeId] = useState('localhost');
|
|
const [loading, setLoading] = useState(false);
|
|
const [error, setError] = useState<string | null>(null);
|
|
const [showAddDialog, setShowAddDialog] = useState(false);
|
|
const [editingInterface] = useState<NetworkInterface | null>(null);
|
|
|
|
// Form state
|
|
const [ifaceName, setIfaceName] = useState('');
|
|
const [ifaceType, setIfaceType] = useState('eth');
|
|
const [address, setAddress] = useState('');
|
|
const [netmask, setNetmask] = useState('');
|
|
const [gateway, setGateway] = useState('');
|
|
const [active, setActive] = useState(true);
|
|
|
|
const loadInterfaces = useCallback(async (cId: string, nId: string) => {
|
|
if (!cId) return;
|
|
setLoading(true);
|
|
setError(null);
|
|
try {
|
|
const ifaces = await listNetworkInterfaces(cId, nId);
|
|
setInterfaces(ifaces);
|
|
} catch (e) {
|
|
setError(String(e));
|
|
} finally {
|
|
setLoading(false);
|
|
}
|
|
}, []);
|
|
|
|
useEffect(() => {
|
|
listProxmoxClusters()
|
|
.then((cls) => {
|
|
if (cls.length > 0) {
|
|
setClusterId(cls[0].id);
|
|
void loadInterfaces(cls[0].id, nodeId);
|
|
}
|
|
})
|
|
.catch(console.error);
|
|
}, [loadInterfaces, nodeId]);
|
|
|
|
const NOT_IMPLEMENTED_MSG =
|
|
'Network interface management requires additional backend implementation (POST/PUT/DELETE nodes/{node}/network) and is not yet available.';
|
|
|
|
const handleAddInterface = () => {
|
|
toast.warning(NOT_IMPLEMENTED_MSG);
|
|
};
|
|
|
|
const handleEditInterface = (_iface: NetworkInterface) => {
|
|
toast.warning(NOT_IMPLEMENTED_MSG);
|
|
};
|
|
|
|
const handleSubmit = async () => {
|
|
toast.warning(NOT_IMPLEMENTED_MSG);
|
|
setShowAddDialog(false);
|
|
};
|
|
|
|
const handleDeleteInterface = async (_iface: NetworkInterface) => {
|
|
toast.warning(NOT_IMPLEMENTED_MSG);
|
|
};
|
|
|
|
return (
|
|
<div className="space-y-4">
|
|
<div className="flex items-center justify-between">
|
|
<div>
|
|
<h1 className="text-2xl font-bold">Network</h1>
|
|
<p className="text-muted-foreground">Network interfaces and bridges</p>
|
|
</div>
|
|
<div className="flex items-center space-x-2">
|
|
<Button variant="outline" size="sm" onClick={() => void loadInterfaces(clusterId, nodeId)} disabled={loading || !clusterId}>
|
|
<RefreshCw className={`mr-2 h-4 w-4 ${loading ? 'animate-spin' : ''}`} />
|
|
Refresh
|
|
</Button>
|
|
<Button size="sm" onClick={handleAddInterface}>
|
|
<Plus className="mr-2 h-4 w-4" />
|
|
Add Interface
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
|
|
{error && (
|
|
<div className="rounded border border-destructive/40 bg-destructive/10 px-3 py-2 text-sm text-destructive">
|
|
{error}
|
|
</div>
|
|
)}
|
|
|
|
<Card>
|
|
<CardHeader>
|
|
<CardTitle>Network Interfaces</CardTitle>
|
|
</CardHeader>
|
|
<CardContent>
|
|
{loading ? (
|
|
<div className="text-sm text-muted-foreground">Loading...</div>
|
|
) : interfaces.length === 0 ? (
|
|
<div className="text-sm text-muted-foreground">
|
|
{clusterId ? 'No network interfaces found.' : 'No cluster configured.'}
|
|
</div>
|
|
) : (
|
|
<div className="space-y-2">
|
|
{interfaces.map((iface, i) => (
|
|
<div key={`${iface.iface}-${i}`} className="flex items-center gap-3 rounded border p-3">
|
|
<Network className="h-4 w-4 shrink-0 text-muted-foreground" />
|
|
<div className="flex-1 min-w-0">
|
|
<div className="flex flex-wrap items-center gap-2">
|
|
<span className="font-mono font-medium">{iface.iface}</span>
|
|
<Badge variant="outline">{iface.type}</Badge>
|
|
<Badge variant={iface.active ? 'default' : 'secondary'}>
|
|
{iface.active ? 'Active' : 'Inactive'}
|
|
</Badge>
|
|
{iface.autostart && (
|
|
<Badge variant="outline" className="text-xs">Autostart</Badge>
|
|
)}
|
|
</div>
|
|
{(iface.address || iface.gateway) && (
|
|
<div className="mt-1 text-xs text-muted-foreground">
|
|
{iface.address && (
|
|
<span>
|
|
{iface.address}
|
|
{iface.netmask ? `/${iface.netmask}` : ''}
|
|
</span>
|
|
)}
|
|
{iface.gateway && (
|
|
<span className="ml-2">gw {iface.gateway}</span>
|
|
)}
|
|
</div>
|
|
)}
|
|
{iface.comments && (
|
|
<div className="mt-1 text-xs italic text-muted-foreground">
|
|
{iface.comments}
|
|
</div>
|
|
)}
|
|
</div>
|
|
<div className="flex items-center gap-2">
|
|
<button
|
|
className="rounded p-1 hover:bg-accent"
|
|
onClick={() => handleEditInterface(iface)}
|
|
title="Edit"
|
|
>
|
|
<Edit className="h-4 w-4" />
|
|
</button>
|
|
<button
|
|
className="rounded p-1 hover:bg-red-100 hover:text-red-600"
|
|
onClick={() => handleDeleteInterface(iface)}
|
|
title="Delete"
|
|
>
|
|
<Trash2 className="h-4 w-4" />
|
|
</button>
|
|
</div>
|
|
</div>
|
|
))}
|
|
</div>
|
|
)}
|
|
</CardContent>
|
|
</Card>
|
|
|
|
<Dialog open={showAddDialog} onOpenChange={setShowAddDialog}>
|
|
<DialogContent>
|
|
<DialogHeader>
|
|
<DialogTitle>{editingInterface ? 'Edit Network Interface' : 'Add Network Interface'}</DialogTitle>
|
|
</DialogHeader>
|
|
<div className="space-y-4 py-4">
|
|
<div className="space-y-2">
|
|
<Label htmlFor="iface">Interface Name</Label>
|
|
<Input
|
|
id="iface"
|
|
value={ifaceName}
|
|
onChange={(e) => setIfaceName(e.target.value)}
|
|
placeholder="eth0"
|
|
/>
|
|
</div>
|
|
<div className="space-y-2">
|
|
<Label htmlFor="type">Interface Type</Label>
|
|
<Select value={ifaceType} onValueChange={setIfaceType}>
|
|
<SelectTrigger>
|
|
<SelectValue placeholder="Select interface type" />
|
|
</SelectTrigger>
|
|
<SelectContent>
|
|
<SelectItem value="eth">eth — Ethernet</SelectItem>
|
|
<SelectItem value="bond">bond — Network Bond</SelectItem>
|
|
<SelectItem value="bridge">bridge — Linux Bridge</SelectItem>
|
|
<SelectItem value="vlan">vlan — VLAN</SelectItem>
|
|
<SelectItem value="OVSBridge">OVSBridge — Open vSwitch Bridge</SelectItem>
|
|
<SelectItem value="OVSBond">OVSBond — Open vSwitch Bond</SelectItem>
|
|
<SelectItem value="OVSIntPort">OVSIntPort — OVS Internal Port</SelectItem>
|
|
<SelectItem value="OVSPort">OVSPort — OVS Port</SelectItem>
|
|
</SelectContent>
|
|
</Select>
|
|
</div>
|
|
<div className="space-y-2">
|
|
<Label htmlFor="address">IP Address</Label>
|
|
<Input
|
|
id="address"
|
|
value={address}
|
|
onChange={(e) => setAddress(e.target.value)}
|
|
placeholder="192.168.1.100"
|
|
/>
|
|
</div>
|
|
<div className="space-y-2">
|
|
<Label htmlFor="netmask">Netmask</Label>
|
|
<Input
|
|
id="netmask"
|
|
value={netmask}
|
|
onChange={(e) => setNetmask(e.target.value)}
|
|
placeholder="24"
|
|
/>
|
|
</div>
|
|
<div className="space-y-2">
|
|
<Label htmlFor="gateway">Gateway</Label>
|
|
<Input
|
|
id="gateway"
|
|
value={gateway}
|
|
onChange={(e) => setGateway(e.target.value)}
|
|
placeholder="192.168.1.1"
|
|
/>
|
|
</div>
|
|
<div className="flex items-center space-x-2">
|
|
<input
|
|
type="checkbox"
|
|
id="active"
|
|
checked={active}
|
|
onChange={(e) => setActive(e.target.checked)}
|
|
className="rounded"
|
|
/>
|
|
<Label htmlFor="active">Active</Label>
|
|
</div>
|
|
</div>
|
|
<DialogFooter>
|
|
<Button variant="outline" onClick={() => setShowAddDialog(false)}>
|
|
Cancel
|
|
</Button>
|
|
<Button onClick={handleSubmit}>
|
|
{editingInterface ? 'Update' : 'Create'}
|
|
</Button>
|
|
</DialogFooter>
|
|
</DialogContent>
|
|
</Dialog>
|
|
</div>
|
|
);
|
|
}
|