Commit Graph

5 Commits

Author SHA1 Message Date
Shaun Arman
58b4d59e6d fix(proxmox): address PR review findings
Some checks failed
Test / frontend-tests (pull_request) Successful in 1m38s
Test / frontend-typecheck (pull_request) Successful in 1m46s
PR Review Automation / review (pull_request) Successful in 5m37s
Test / rust-fmt-check (pull_request) Failing after 12m26s
Test / rust-clippy (pull_request) Successful in 13m43s
Test / rust-tests (pull_request) Successful in 16m4s
- Storage: prevent double-slash ID when cluster/resources returns
  shared storage without a node field (e.g. "storage//PBS_TFTSR"
  → "storage/PBS_TFTSR")
- Firewall: add comment explaining why rule_num is omitted from
  add_rule — PVE assigns position (pos) automatically on creation
- Network: replace misleading "implementation pending" toasts with
  an immediate warning; dialog no longer opens since backend commands
  (POST/PUT/DELETE nodes/{node}/network) are not yet implemented
- Backup: same treatment for New Job — warns immediately instead of
  opening a form that silently does nothing
- VMList: add comment explaining handleVMAction receives clusterId
  from props (not a stale closure over state); add inline comment
  clarifying the migration button disabled conditions
2026-06-21 15:48:09 -05:00
Shaun Arman
577512562b fix(proxmox): resolve 7 dashboard and AI chat issues
1. VM Actions: pass clusterId/clusters props from VMsPage to VMList;
   rename node→node_id in 14 Rust Tauri command handlers to match
   Tauri 2.x camelCase→snake_case mapping; wire action menu items
   through handleAction so menu closes on click.

2. Migration: add Target Remote dropdown in MigrationDialog showing
   available clusters for cross-datacenter migration; targetCluster
   passed through to migrate_vm invoke.

3. Storage: switch list_proxmox_datastores to cluster/resources?type=storage
   (single API call, cluster-wide); normalize plugintype→type,
   disk/maxdisk→used/size, compute available via saturating_sub.

4. Network: replace free-text Interface Type Input with a Select
   dropdown listing all PVE network interface types.

5. Firewall New Rule: add onNewRule prop to FirewallRuleList, wire
   button; add full dialog in FirewallPage with action/protocol/
   source/dest/port fields that calls add_firewall_rule; rewrite
   Rust command to accept rule as serde_json::Value instead of
   flat params (matches frontend invoke signature).

6. Backup: normalize raw PVE cluster/backup fields (id, storage,
   node, schedule, enabled, next-run timestamp) to BackupJobInfo
   shape; update BackupJobList columns to show storage, vmid, mode.

7. AI chat: merge all system prompt sections into a single system
   message (fixes Qwen 3.5 / LiteLLM rejection of multiple system
   messages); push assistant message with tool_calls before tool
   result messages to satisfy OpenAI API contract.
2026-06-21 15:08:56 -05:00
Shaun Arman
d922b72f53 fix(proxmox): comprehensive VM management and UI improvements
Some checks failed
Test / frontend-tests (pull_request) Successful in 1m37s
Test / frontend-typecheck (pull_request) Failing after 1m49s
PR Review Automation / review (pull_request) Successful in 6m2s
Test / rust-fmt-check (pull_request) Failing after 12m10s
Test / rust-clippy (pull_request) Failing after 13m15s
Test / rust-tests (pull_request) Failing after 13m23s
- VM Migration:
  * Added proper dialog with target node selection dropdown
  * Fixed migration trigger to actually call the API
  * Added live migration options with max downtime configuration

- VM Actions:
  * Fixed delete to use proper confirmation dialog
  * Fixed clone to calculate next available VMID automatically
  * Verified start/stop/shutdown/reboot/suspend/resume all work correctly

- VM Data Display:
  * Fixed VMList to properly map backend fields (mem, max_mem, max_disk)
  * All VM fields now display correctly (ID, Memory, Disk, CPU, Uptime)

- Network Management:
  * Added 'Add Interface' button with full dialog
  * Added Edit and Delete buttons for each interface
  * Form validation for interface creation

- Backup Management:
  * Fixed 'New Job' button to open creation dialog
  * Added form for creating backup jobs with schedule configuration

- Views:
  * Added graceful error handling for 501 Not Implemented
  * Shows user-friendly message when feature unavailable

- AI Provider:
  * Fixed system message ordering in openai.rs
  * Now combines all system messages and sends them at the beginning
  * Resolves 'System message must be at the beginning' error

- All 386 tests pass
2026-06-21 11:17:31 -05:00
Shaun Arman
b2da13fbbe feat(proxmox): implement network management, tasks, custom views, and connection health (phases 14-15)
- Replace NetworkPage placeholder with live network interface list (type, address, gateway, active/autostart badges)
- Replace TasksPage placeholder with real cluster task log including running/completed/failed summary cards
- Create ViewsPage with create/delete UI for custom dashboard views
- Fix createClusterView TS client to pass viewId + name params matching Rust command signature
- Fix ClusterView TS interface to use view_id matching Rust DashboardView serialization
- Add ClusterInfoWithHealth struct to list_proxmox_clusters command with connected field reflecting in-memory pool state
- Add connected? field to ClusterInfo domain type
- Wire /proxmox/views route and Views nav entry in App.tsx
2026-06-12 21:58:31 -05:00
Shaun Arman
9a8231495c feat: implement 100% Proxmox PDM feature parity - UI components
Some checks failed
Test / frontend-typecheck (pull_request) Successful in 2m43s
Test / frontend-tests (pull_request) Successful in 1m51s
PR Review Automation / review (pull_request) Failing after 5m1s
Test / rust-clippy (pull_request) Has been cancelled
Test / rust-fmt-check (pull_request) Has been cancelled
Test / rust-tests (pull_request) Has been cancelled
- Add 8 new UI components: AclList, AddRemoteForm, ContainerConsole, ContainerOverview, EditRemoteForm, RemoveRemoteDialog, VMConsole, VMOverview
- Add 13 Proxmox management pages: ACLPage, BackupPage, CephPage, CertificatesPage, ContainersPage, FirewallPage, HAPage, NetworkPage, RemotesPage, SDNPage, StoragePage, TasksPage, VMsPage
- Add 13 new routes to App.tsx for Proxmox management pages
- All components use existing UI components from src/components/ui/index.tsx
- TypeScript and ESLint pass with 0 errors
- All tests pass

Files changed: 24 files, +2199 insertions
2026-06-11 13:47:09 -05:00