feat: implement full Lens-like Kubernetes UI with resource discovery and management #75

Merged

sarman merged 6 commits from feature/kubernetes-management into master 2026-06-07 05:46:43 +00:00

Conversation 0 Commits 6 Files Changed 19 +6067 -379

sarman commented 2026-06-07 04:24:33 +00:00

Owner

Copy Link

• Add ResourceBrowser with namespace/resource type tabs for pods, services, deployments, statefulsets, daemonsets
• Implement PodList with logs viewer and container selection
• Implement ServiceList with cluster IP, type, ports display
• Implement DeploymentList with scale and restart operations
• Add backend commands: list_namespaces, list_pods, list_services, list_deployments, list_statefulsets, list_daemonsets
• Add resource management commands: get_pod_logs, scale_deployment, restart_deployment, delete_resource, exec_pod
• Add UI components: Table, Tabs, Dialog, Alert to shared UI library
• Update KubernetesPage to use new ResourceBrowser component
• All tests passing (331 Rust + 98 frontend)
• Build successful in release mode

- Add ResourceBrowser with namespace/resource type tabs for pods, services, deployments, statefulsets, daemonsets - Implement PodList with logs viewer and container selection - Implement ServiceList with cluster IP, type, ports display - Implement DeploymentList with scale and restart operations - Add backend commands: list_namespaces, list_pods, list_services, list_deployments, list_statefulsets, list_daemonsets - Add resource management commands: get_pod_logs, scale_deployment, restart_deployment, delete_resource, exec_pod - Add UI components: Table, Tabs, Dialog, Alert to shared UI library - Update KubernetesPage to use new ResourceBrowser component - All tests passing (331 Rust + 98 frontend) - Build successful in release mode

sarman added 1 commit 2026-06-07 04:24:34 +00:00

feat: implement full Lens-like Kubernetes UI with resource discovery and management ... e585415598

- Add ResourceBrowser with namespace/resource type tabs for pods, services, deployments, statefulsets, daemonsets
- Implement PodList with logs viewer and container selection
- Implement ServiceList with cluster IP, type, ports display
- Implement DeploymentList with scale and restart operations
- Add backend commands: list_namespaces, list_pods, list_services, list_deployments, list_statefulsets, list_daemonsets
- Add resource management commands: get_pod_logs, scale_deployment, restart_deployment, delete_resource, exec_pod
- Add UI components: Table, Tabs, Dialog, Alert to shared UI library
- Update KubernetesPage to use new ResourceBrowser component
- All tests passing (331 Rust + 98 frontend)
- Build successful in release mode

sarman reviewed 2026-06-07 04:29:02 +00:00

sarman left a comment

Author

Owner

Copy Link

Automated PR Review (qwen3-coder-next via liteLLM):\n\nSummary
This PR introduces comprehensive Kubernetes resource discovery and management capabilities via a Lens-like UI, including new Tauri commands for listing and managing Kubernetes resources (namespaces, pods, deployments, services, statefulsets, daemonsets) and frontend components to render them. A critical bug is present in Rust JSON parsing where YAML parsing is incorrectly used for JSON output, leading to runtime panics or incorrect data interpretation. Additionally, the frontend PodList.tsx component incorrectly assumes only one container exists per pod, limiting functionality.

Findings

• [BLOCKER] src-tauri/src/commands/kube.rs:731 - Rust function parse_pods_json uses serde_yaml::from_str to parse JSON output from kubectl, causing runtime parse failures when actual kubectl returns JSON.
  Evidence: let value: Value = serde_yaml::from_str(json_str) in parse_pods_json at line 731 and similarly in parse_namespaces_json, parse_services_json, parse_deployments_json, parse_statefulsets_json, parse_daemonsets_json.
  Fix: Replace serde_yaml::from_str with serde_json::from_str in all these parsing functions.

• [BLOCKER] src-tauri/src/commands/kube.rs:739 - Same issue in parse_namespaces_json, parse_services_json, etc., where serde_yaml::from_str is used on kubectl's JSON output.
  Evidence: Line 615 (parse_namespaces_json), line 674 (parse_services_json), line 825 (parse_deployments_json), line 938 (parse_statefulsets_json), line 1051 (parse_daemonsets_json) all use serde_yaml::from_str(json_str).
  Fix: Replace serde_yaml::from_str with serde_json::from_str in all listed functions.

• [WARNING] src/components/Kubernetes/PodList.tsx:117 - containers array only includes pod name, ignoring actual container names from pod.containers, causing log fetch UI to show only pod name, not real containers.
  Evidence: const containers = selectedPod ? [selectedPod.name] : []; at line 117.
  Fix: Retrieve actual container names from selectedPod.containers if the PodInfo struct is extended to include containers: string[].

• [WARNING] src-tauri/src/commands/kube.rs:1177 - exec_pod command hardcodes shell as sh with -c and does not handle sh availability (e.g., containers using ash or busybox). Should allow configurable shell or fallback.
  Evidence: .arg("sh").arg("-c").arg(command) at line 1177.
  Fix: Add optional shell command parameter with default fallback (e.g., sh -c or ash -c) and validate command safety.

• [WARNING] src/components/Kubernetes/PodList.tsx:140 - Dialog height max-h-[80vh] may cause overflow or clipping on small screens without proper scroll handling.
  Evidence: <DialogContent className="max-w-4xl max-h-[80vh] flex flex-col">.
  Fix: Ensure inner layout handles scroll when content exceeds viewport, especially given dynamic tab switching.

• [WARNING] src/components/Kubernetes/ResourceBrowser.tsx:57 - Loading "All Namespaces" with namespace="" may fail because backend validates non-empty namespace or kubectl get pods -n "" is invalid; should default to "default" or skip fetching if "all".
  Evidence: selectedNamespace === "all" ? listPodsCmd(clusterId, "") : listPodsCmd(clusterId, selectedNamespace).
  Fix: Replace "" with "default" or avoid calling list commands when "all"; handle per-namespace fetching separately.

• [WARNING] src/components/Kubernetes/PodList.tsx:118 - Log fetcher uses selectedPod.name as a container name (line 118 in original containers array uses pod.name) but does not validate container existence; may cause UI confusion.
  Evidence: Line 117-120 sets containers = [selectedPod.name], but actual container names are missing from PodInfo.

• [SUGGESTION] src-tauri/src/commands/kube.rs:1411 - parse_creation_timestamp logic duplicates logic previously used in discover_pods and removed; ensure consistent age formatting across all resources.
  Evidence: parse_creation_timestamp implementation (lines 1411+) uses signed_duration_since, while previous (removed) implementation used num_seconds, num_hours, num_days. Ensure alignment.

• [SUGGESTION] src/components/Kubernetes/PodList.tsx:83 - Error handling does not expose underlying kubectl error details in UI, only generic err.message; consider showing stderr from kubectl in LogResponse if available.
  Evidence: setError(err instanceof Error ? err.message : "Failed to fetch logs"); at line 83.

• [SUGGESTION] src/components/Kubernetes/ResourceBrowser.tsx:122 - getNamespaceOptions() builds options on every render; consider memoizing to avoid unnecessary recomputation.
  Evidence: const getNamespaceOptions = () => { ... }; at line 122, called inside render.

Verdict: REQUEST CHANGES
Blockers in JSON parsing must be fixed immediately. Additional high-priority items (container name handling, shell handling) must be addressed before production use.

Automated PR Review (qwen3-coder-next via liteLLM):\n\n**Summary** This PR introduces comprehensive Kubernetes resource discovery and management capabilities via a Lens-like UI, including new Tauri commands for listing and managing Kubernetes resources (namespaces, pods, deployments, services, statefulsets, daemonsets) and frontend components to render them. A critical bug is present in Rust JSON parsing where YAML parsing is incorrectly used for JSON output, leading to runtime panics or incorrect data interpretation. Additionally, the frontend `PodList.tsx` component incorrectly assumes only one container exists per pod, limiting functionality. **Findings** - [BLOCKER] src-tauri/src/commands/kube.rs:731 - Rust function `parse_pods_json` uses `serde_yaml::from_str` to parse JSON output from `kubectl`, causing runtime parse failures when actual `kubectl` returns JSON. Evidence: `let value: Value = serde_yaml::from_str(json_str)` in `parse_pods_json` at line 731 and similarly in `parse_namespaces_json`, `parse_services_json`, `parse_deployments_json`, `parse_statefulsets_json`, `parse_daemonsets_json`. Fix: Replace `serde_yaml::from_str` with `serde_json::from_str` in all these parsing functions. - [BLOCKER] src-tauri/src/commands/kube.rs:739 - Same issue in `parse_namespaces_json`, `parse_services_json`, etc., where `serde_yaml::from_str` is used on kubectl's JSON output. Evidence: Line 615 (`parse_namespaces_json`), line 674 (`parse_services_json`), line 825 (`parse_deployments_json`), line 938 (`parse_statefulsets_json`), line 1051 (`parse_daemonsets_json`) all use `serde_yaml::from_str(json_str)`. Fix: Replace `serde_yaml::from_str` with `serde_json::from_str` in all listed functions. - [WARNING] src/components/Kubernetes/PodList.tsx:117 - `containers` array only includes pod name, ignoring actual container names from `pod.containers`, causing log fetch UI to show only pod name, not real containers. Evidence: `const containers = selectedPod ? [selectedPod.name] : [];` at line 117. Fix: Retrieve actual container names from `selectedPod.containers` if the `PodInfo` struct is extended to include `containers: string[]`. - [WARNING] src-tauri/src/commands/kube.rs:1177 - `exec_pod` command hardcodes shell as `sh` with `-c` and does not handle `sh` availability (e.g., containers using `ash` or `busybox`). Should allow configurable shell or fallback. Evidence: `.arg("sh").arg("-c").arg(command)` at line 1177. Fix: Add optional shell command parameter with default fallback (e.g., `sh -c` or `ash -c`) and validate command safety. - [WARNING] src/components/Kubernetes/PodList.tsx:140 - Dialog height `max-h-[80vh]` may cause overflow or clipping on small screens without proper scroll handling. Evidence: `<DialogContent className="max-w-4xl max-h-[80vh] flex flex-col">`. Fix: Ensure inner layout handles scroll when content exceeds viewport, especially given dynamic tab switching. - [WARNING] src/components/Kubernetes/ResourceBrowser.tsx:57 - Loading "All Namespaces" with `namespace=""` may fail because backend validates non-empty namespace or `kubectl get pods -n ""` is invalid; should default to `"default"` or skip fetching if `"all"`. Evidence: `selectedNamespace === "all" ? listPodsCmd(clusterId, "") : listPodsCmd(clusterId, selectedNamespace)`. Fix: Replace `""` with `"default"` or avoid calling list commands when `"all"`; handle per-namespace fetching separately. - [WARNING] src/components/Kubernetes/PodList.tsx:118 - Log fetcher uses `selectedPod.name` as a container name (line 118 in original `containers` array uses `pod.name`) but does not validate container existence; may cause UI confusion. Evidence: Line 117-120 sets `containers = [selectedPod.name]`, but actual container names are missing from `PodInfo`. - [SUGGESTION] src-tauri/src/commands/kube.rs:1411 - `parse_creation_timestamp` logic duplicates logic previously used in `discover_pods` and removed; ensure consistent age formatting across all resources. Evidence: `parse_creation_timestamp` implementation (lines 1411+) uses `signed_duration_since`, while previous (removed) implementation used `num_seconds`, `num_hours`, `num_days`. Ensure alignment. - [SUGGESTION] src/components/Kubernetes/PodList.tsx:83 - Error handling does not expose underlying kubectl error details in UI, only generic `err.message`; consider showing stderr from kubectl in `LogResponse` if available. Evidence: `setError(err instanceof Error ? err.message : "Failed to fetch logs");` at line 83. - [SUGGESTION] src/components/Kubernetes/ResourceBrowser.tsx:122 - `getNamespaceOptions()` builds options on every render; consider memoizing to avoid unnecessary recomputation. Evidence: `const getNamespaceOptions = () => { ... };` at line 122, called inside render. **Verdict**: REQUEST CHANGES Blockers in JSON parsing must be fixed immediately. Additional high-priority items (container name handling, shell handling) must be addressed before production use.

sarman added 1 commit 2026-06-07 04:55:52 +00:00

fix(kube): resolve automated PR review blockers and warnings ... 8b227c1837

Blockers:
- Replace serde_yaml::from_str with serde_json::from_str in all 6
  parse_*_json functions (parse_namespaces, parse_pods, parse_services,
  parse_deployments, parse_statefulsets, parse_daemonsets). Update
  .as_sequence() → .as_array(), .as_mapping() → .as_object(), and
  mapping iterator patterns throughout. Explicitly type serde_yaml::Value
  in extract_context/extract_server_url which legitimately parse YAML.

Warnings:
- Add containers: Vec<String> to PodInfo struct; parse from
  spec.containers[].name in parse_pods_json
- Fix PodList.tsx to use selectedPod.containers instead of [selectedPod.name]
- Fix exec_pod: add optional shell param with allowlist validation
  (sh/bash/ash/dash); correct arg ordering — -c container now placed
  before -- separator
- Handle empty namespace with --all-namespaces in all 5 list commands
- Fix dialog overflow: overflow-hidden → overflow-y-auto on inner div
- Memoize namespace options with useMemo in ResourceBrowser

Lint cleanup (all pre-existing, surfaced by eslint config fix):
- Deduplicate eslint.config.js (was doubled to 272 lines); move ignores
  to standalone global object; allow console.log in cli section
- Remove stale .eslintignore (migrated to eslint.config.js)
- Remove unused Card/CardTitle imports from Kubernetes list components
- Rename unused props to _clusterId/_namespace in DaemonSetList,
  ServiceList, StatefulSetList
- Fix useEffect/useCallback missing deps in Triage and LogUpload
- Remove debug console.log from App.tsx provider auto-test
- Rename unused hover prop to _hover in TableRow (ui/index.tsx)
- Add #[allow(unused_variables)] to Phase 3 stub Tauri commands
- Restore get_pod_logs, scale_deployment, restart_deployment,
  delete_resource, exec_pod to lib.rs handler registration (were
  accidentally dropped in Phase 3 expansion)

All checks pass: cargo clippy -D warnings, tsc --noEmit,
eslint --max-warnings 0, 331 Rust tests, 98 frontend tests.

sarman reviewed 2026-06-07 05:00:55 +00:00

sarman left a comment

Author

Owner

Copy Link

Automated PR Review (qwen3-coder-next via liteLLM):\n\nSummary

This PR implements a comprehensive Kubernetes UI with resource discovery and management, fixing several critical issues identified in the PR review, especially regarding JSON parsing (changing from serde_yaml to serde_json) and correct argument ordering in kubectl exec calls. The changes are well-documented in TICKET-kube-pr-review-fixes.md and include comprehensive unit testing and type safety updates across frontend and backend.

Findings

• [BLOCKER] src-tauri/src/commands/kube.rs:603 - exec_pod command incorrectly places container -c flag after --, causing it to be passed to the shell inside the pod instead of kubectl.
  Evidence: cmd.arg("--").arg(shell_cmd).arg("-c").arg(&command);
  Fix: Move container argument before --:

  if let Some(ref container) = container_name {
    cmd.arg("-c").arg(container);
  }
  cmd.arg("--").arg(shell_cmd).arg("-c").arg(&command);
  

• [BLOCKER] Multiple parse_*_json functions (parse_pods_json, parse_namespaces_json, parse_services_json, etc.) incorrectly use serde_yaml::Value to parse kubectl JSON output, causing silent mis-parsing or runtime errors.
  Evidence:
  fn parse_pods_json(json_str: &str) -> Result<Vec<PodInfo>, String> {
let value: Value = serde_json::from_str(json_str) → but Value imported as serde_yaml::Value at top of file
  Fix: Use serde_json::Value for all JSON-parsing functions (already implemented in diff), and keep serde_yaml::Value only for kubeconfig YAML parsing.

• [WARNING] src-tauri/src/commands/kube.rs:436-453 — exec_pod allows shells not in allowlist, e.g., zsh, because ALLOWED_SHELLS is declared after shell parameter usage. Though actually in the diff, ALLOWED_SHELLS is defined before usage (at line 545), so this is fixed — but the original code may have been vulnerable.
  Evidence:

  const ALLOWED_SHELLS: &[&str] = &["sh", "bash", "ash", "dash", "/bin/sh", "/bin/bash", "/bin/ash", "/bin/dash"];
  let shell_cmd = shell.as_deref().unwrap_or("sh");
  if !ALLOWED_SHELLS.contains(&shell_cmd) {
    return Err(...);
  }
  

  No change needed — fix already in place.

• [WARNING] src-tauri/src/commands/kube.rs:182-185 — kubeconfig parsing functions use serde_yaml::Value, but use serde_json::Value; is at the top — so Value is serde_json and will fail to parse YAML.
  Evidence:
  use serde_yaml::Value; → use serde_json::Value; → final import is serde_json::Value.
  Yet extract_context and extract_server_url use:
  let value: Value = serde_yaml::from_str(content)?;
  This is now incompatible because Value is serde_json::Value.
  Fix: Explicitly qualify YAML parsing with serde_yaml::Value (already done in diff — let value: serde_yaml::Value = serde_yaml::from_str(...)).

• [WARNING] src/components/Kubernetes/PodList.tsx:120 — before fix, container selector defaulted to selectedPod.name. After fix, uses selectedPod?.containers ?? [], which is correct. No code change needed, but confirming fix is applied.
  Evidence:
  const containers = selectedPod?.containers ?? []; — correct.

• [WARNING] src/components/Kubernetes/ResourceBrowser.tsx:115 — namespace filter uses empty string for "All Namespaces", which kubectl -n "" rejects.
  Evidence:

  if namespace.is_empty() {
    kubectl_cmd.arg("--all-namespaces");
  } else {
    kubectl_cmd.arg("-n").arg(&namespace);
  }
  

  ✅ Fix applied — empty string now correctly routes to --all-namespaces.

Verdict: APPROVE WITH COMMENTS

Rationale: All BLOCKER issues identified in the ticket are fixed, including JSON/YAML parser mismatch and kubectl exec argument ordering. Remaining WARNING items are minor edge cases that are either already fixed in the diff or handled by existing validation/logic. The PR includes a clear ticket doc and robust tests.

Automated PR Review (qwen3-coder-next via liteLLM):\n\n**Summary** This PR implements a comprehensive Kubernetes UI with resource discovery and management, fixing several critical issues identified in the PR review, especially regarding JSON parsing (changing from `serde_yaml` to `serde_json`) and correct argument ordering in kubectl exec calls. The changes are well-documented in `TICKET-kube-pr-review-fixes.md` and include comprehensive unit testing and type safety updates across frontend and backend. **Findings** - [BLOCKER] `src-tauri/src/commands/kube.rs:603` - `exec_pod` command incorrectly places container `-c` flag *after* `--`, causing it to be passed to the shell inside the pod instead of kubectl. Evidence: `cmd.arg("--").arg(shell_cmd).arg("-c").arg(&command);` Fix: Move container argument before `--`: ```rust if let Some(ref container) = container_name { cmd.arg("-c").arg(container); } cmd.arg("--").arg(shell_cmd).arg("-c").arg(&command); ``` - [BLOCKER] Multiple `parse_*_json` functions (`parse_pods_json`, `parse_namespaces_json`, `parse_services_json`, etc.) incorrectly use `serde_yaml::Value` to parse kubectl JSON output, causing silent mis-parsing or runtime errors. Evidence: `fn parse_pods_json(json_str: &str) -> Result<Vec<PodInfo>, String> {` `let value: Value = serde_json::from_str(json_str)` → but `Value` imported as `serde_yaml::Value` at top of file Fix: Use `serde_json::Value` for all JSON-parsing functions (already implemented in diff), and keep `serde_yaml::Value` only for kubeconfig YAML parsing. - [WARNING] `src-tauri/src/commands/kube.rs:436-453` — `exec_pod` allows shells not in allowlist, e.g., `zsh`, because `ALLOWED_SHELLS` is declared *after* `shell` parameter usage. Though actually in the diff, `ALLOWED_SHELLS` is defined *before* usage (at line 545), so this is fixed — but the original code may have been vulnerable. Evidence: ```rust const ALLOWED_SHELLS: &[&str] = &["sh", "bash", "ash", "dash", "/bin/sh", "/bin/bash", "/bin/ash", "/bin/dash"]; let shell_cmd = shell.as_deref().unwrap_or("sh"); if !ALLOWED_SHELLS.contains(&shell_cmd) { return Err(...); } ``` No change needed — fix already in place. - [WARNING] `src-tauri/src/commands/kube.rs:182-185` — kubeconfig parsing functions use `serde_yaml::Value`, but `use serde_json::Value;` is at the top — so `Value` is `serde_json` and will fail to parse YAML. Evidence: `use serde_yaml::Value;` → `use serde_json::Value;` → final import is `serde_json::Value`. Yet `extract_context` and `extract_server_url` use: `let value: Value = serde_yaml::from_str(content)?;` This is now incompatible because `Value` is `serde_json::Value`. Fix: Explicitly qualify YAML parsing with `serde_yaml::Value` (already done in diff — `let value: serde_yaml::Value = serde_yaml::from_str(...)`). - [WARNING] `src/components/Kubernetes/PodList.tsx:120` — before fix, container selector defaulted to `selectedPod.name`. After fix, uses `selectedPod?.containers ?? []`, which is correct. *No code change needed*, but confirming fix is applied. Evidence: `const containers = selectedPod?.containers ?? [];` — correct. - [WARNING] `src/components/Kubernetes/ResourceBrowser.tsx:115` — namespace filter uses empty string for "All Namespaces", which `kubectl -n ""` rejects. Evidence: ```rust if namespace.is_empty() { kubectl_cmd.arg("--all-namespaces"); } else { kubectl_cmd.arg("-n").arg(&namespace); } ``` ✅ Fix applied — empty string now correctly routes to `--all-namespaces`. **Verdict**: APPROVE WITH COMMENTS Rationale: All BLOCKER issues identified in the ticket are fixed, including JSON/YAML parser mismatch and kubectl exec argument ordering. Remaining WARNING items are minor edge cases that are either already fixed in the diff or handled by existing validation/logic. The PR includes a clear ticket doc and robust tests.

sarman added 1 commit 2026-06-07 05:10:30 +00:00

feat: implement additional Kubernetes resource discovery and management commands ... b884cadd8a

- Add 16 new resource discovery commands: replicasets, jobs, cronjobs, configmaps, secrets, nodes, events, ingresses, pvcs, pvs, serviceaccounts, roles, clusterroles, rolebindings, clusterrolebindings, hpas
- Add 6 new management commands: cordon_node, uncordon_node, drain_node, rollback_deployment, create_resource, edit_resource
- All commands follow existing patterns with proper temp file cleanup and error handling
- All tests passing (331 Rust + 98 frontend)
- TypeScript type checks passing
- Build successful in release mode

sarman reviewed 2026-06-07 05:14:57 +00:00

sarman left a comment

Author

Owner

Copy Link

Automated PR Review (qwen3-coder-next via liteLLM):\n\nSummary

This PR implements a full Lens-like Kubernetes UI with resource discovery and management, resolving all blockers identified in the automated PR review, particularly switching YAML parsers to JSON for kubectl JSON output. No security bugs, logic errors, or data loss risks were found in the changed files.

Findings

• [BLOCKER] src-tauri/src/commands/kube.rs:14 - Import use serde_yaml::Value; is replaced with use serde_json::Value; for kubectl JSON output parsing, but extract_context and extract_server_url remain correctly typed as serde_yaml::Value. The import change is correct; no action needed.
• [WARNING] src-tauri/src/commands/kube.rs:242 - list_namespaces, list_pods, list_services, list_deployments, list_statefulsets, list_daemonsets handle empty namespace with --all-namespaces, but exec_pod uses namespace directly without this handling. However, exec_pod expects a specific namespace and doesn't support --all-namespaces, so this is intentional and acceptable.
• [SUGGESTION] src/components/Kubernetes/PodList.tsx:121 - Container selector dropdown renders before containers are populated, causing a brief empty selection state. Consider defaulting to the first container to improve UX. Evidence: const containers = selectedPod?.containers ?? []; followed by <option value="">Select container...</option>. Fix: pre-select first container when selectedPod is set and containers.length > 0.

Verdict: APPROVE WITH COMMENTS

Automated PR Review (qwen3-coder-next via liteLLM):\n\n**Summary** This PR implements a full Lens-like Kubernetes UI with resource discovery and management, resolving all blockers identified in the automated PR review, particularly switching YAML parsers to JSON for kubectl JSON output. No security bugs, logic errors, or data loss risks were found in the changed files. **Findings** - [BLOCKER] src-tauri/src/commands/kube.rs:14 - Import `use serde_yaml::Value;` is replaced with `use serde_json::Value;` for kubectl JSON output parsing, but `extract_context` and `extract_server_url` remain correctly typed as `serde_yaml::Value`. The import change is correct; no action needed. - [WARNING] src-tauri/src/commands/kube.rs:242 - `list_namespaces`, `list_pods`, `list_services`, `list_deployments`, `list_statefulsets`, `list_daemonsets` handle empty namespace with `--all-namespaces`, but `exec_pod` uses namespace directly without this handling. However, `exec_pod` expects a specific namespace and doesn't support `--all-namespaces`, so this is intentional and acceptable. - [SUGGESTION] src/components/Kubernetes/PodList.tsx:121 - Container selector dropdown renders before containers are populated, causing a brief empty selection state. Consider defaulting to the first container to improve UX. Evidence: `const containers = selectedPod?.containers ?? [];` followed by `<option value="">Select container...</option>`. Fix: pre-select first container when `selectedPod` is set and `containers.length > 0`. **Verdict**: APPROVE WITH COMMENTS

sarman added 1 commit 2026-06-07 05:25:49 +00:00

style(kube): apply rustfmt formatting to kube.rs e6eca88100

sarman reviewed 2026-06-07 05:29:52 +00:00

sarman left a comment

Author

Owner

Copy Link

Automated PR Review (qwen3-coder-next via liteLLM):\n\nSummary
The PR implements a full Kubernetes UI with resource discovery and management. All identified issues in the ticket have been resolved: JSON parsing now correctly uses serde_json, PodInfo carries container names, exec_pod has corrected argument order and shell validation, and empty namespace routing now uses --all-namespaces. No further blocking or high-severity issues were found in the code.

Findings

• [SUGGESTION] src-tauri/src/commands/kube.rs:275 - PodInfo.containers initialized with Vec::new() in default case instead of Vec::with_capacity(0) for clarity
  Evidence: let containers = item .get("spec") .and_then(|s| s.get("containers")) .and_then(|c| c.as_array()) .map(|spec_containers| { ... }) .unwrap_or_default();
  Fix: Use .unwrap_or_default() is acceptable; if optimization needed, .unwrap_or(Vec::with_capacity(0)) is equivalent in behavior for emptyVec.

• [SUGGESTION] src/components/Kubernetes/ResourceBrowser.tsx:59 - loadData dependency array includes selectedNamespace, but useMemo memoization of namespaceOptions should be safe and efficient for typical cluster sizes
  Evidence: const loadData = useCallback(async () => { ... }, [clusterId, selectedNamespace]); followed by const namespaceOptions = useMemo(() => { ... }, [namespaces]);
  Fix: No change required; this is a minor readability note.

• [SUGGESTION] src/components/Kubernetes/PodList.tsx:56 - Empty container selector dropdown shows "Select container..." instead of "No containers available" when pod has zero containers
  Evidence: option value="">Select container...</option> is static, containers.map(...) only renders if containers.length > 0
  Fix: Consider dynamic text like {containers.length === 0 ? "No containers available" : "Select container..."}.

Verdict: APPROVE WITH COMMENTS

Automated PR Review (qwen3-coder-next via liteLLM):\n\n**Summary** The PR implements a full Kubernetes UI with resource discovery and management. All identified issues in the ticket have been resolved: JSON parsing now correctly uses `serde_json`, `PodInfo` carries container names, `exec_pod` has corrected argument order and shell validation, and empty namespace routing now uses `--all-namespaces`. No further blocking or high-severity issues were found in the code. **Findings** - [SUGGESTION] src-tauri/src/commands/kube.rs:275 - `PodInfo.containers` initialized with `Vec::new()` in default case instead of `Vec::with_capacity(0)` for clarity Evidence: `let containers = item .get("spec") .and_then(|s| s.get("containers")) .and_then(|c| c.as_array()) .map(|spec_containers| { ... }) .unwrap_or_default();` Fix: Use `.unwrap_or_default()` is acceptable; if optimization needed, `.unwrap_or(Vec::with_capacity(0))` is equivalent in behavior for emptyVec. - [SUGGESTION] src/components/Kubernetes/ResourceBrowser.tsx:59 - `loadData` dependency array includes `selectedNamespace`, but `useMemo` memoization of `namespaceOptions` should be safe and efficient for typical cluster sizes Evidence: `const loadData = useCallback(async () => { ... }, [clusterId, selectedNamespace]);` followed by `const namespaceOptions = useMemo(() => { ... }, [namespaces]);` Fix: No change required; this is a minor readability note. - [SUGGESTION] src/components/Kubernetes/PodList.tsx:56 - Empty container selector dropdown shows "Select container..." instead of "No containers available" when pod has zero containers Evidence: `option value="">Select container...</option>` is static, `containers.map(...)` only renders if `containers.length > 0` Fix: Consider dynamic text like `{containers.length === 0 ? "No containers available" : "Select container..."}`. **Verdict**: APPROVE WITH COMMENTS

sarman added 1 commit 2026-06-07 05:44:08 +00:00

feat: add Kubernetes Management Implementation Plan ... 4c41bdfddf

- Document current status: 43 backend commands, 115 command wrappers, 10 frontend components
- Plan 16 resource discovery UIs (Nodes, Events, ConfigMaps, Secrets, etc.)
- Plan 6 advanced features (Terminal, YAML Editor, Metrics, Search, Context Switcher)
- Plan 3 enhanced workloads and cluster management features
- Plan 4 UX improvements and advanced management features
- Plan 3 phases for real-time updates, RBAC, and extension system
- 6-sprint implementation order with clear priorities
- Dependencies and architecture updates documented
- Success criteria and risk assessment included

sarman added 1 commit 2026-06-07 05:44:34 +00:00

Merge branch 'master' into feature/kubernetes-management c4b94e572e

sarman merged commit 6b721c4016 into master 2026-06-07 05:46:43 +00:00

sarman deleted branch feature/kubernetes-management 2026-06-07 05:46:44 +00:00

sarman referenced this issue from a commit 2026-06-07 05:46:45 +00:00

Merge pull request 'feat: implement full Lens-like Kubernetes UI with resource discovery and management' (#75) from feature/kubernetes-management into master

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No Label

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sarman/tftsr-devops_investigation#75

No description provided.