fix(fmt): reformat storage.rs map_err closure for rustfmt compliance #133

sarman · 2026-06-23T00:03:35Z

sarman commented

2026-06-23 00:03:35 +00:00

Summary

Reformats the map_err closure in proxmox/storage.rs:list_storage_content_iso to the multi-line style required by rustfmt's line-length rule
No logic changes — pure formatting fix to unblock the cargo fmt --check CI gate

Test plan

cargo fmt --manifest-path src-tauri/Cargo.toml --check passes
All other CI jobs (clippy, rust-tests, frontend-typecheck, frontend-tests) unaffected

## Summary - Reformats the `map_err` closure in `proxmox/storage.rs:list_storage_content_iso` to the multi-line style required by rustfmt's line-length rule - No logic changes — pure formatting fix to unblock the `cargo fmt --check` CI gate ## Test plan - [ ] `cargo fmt --manifest-path src-tauri/Cargo.toml --check` passes - [ ] All other CI jobs (clippy, rust-tests, frontend-typecheck, frontend-tests) unaffected

sarman added 1 commit 2026-06-23 00:03:37 +00:00

fix(fmt): reformat storage.rs map_err closure to satisfy rustfmt line-length rule

Test / frontend-tests (pull_request) Successful in 1m47s

Details

Test / frontend-typecheck (pull_request) Successful in 1m55s

Details

PR Review Automation / review (pull_request) Successful in 4m21s

Details

Test / rust-fmt-check (pull_request) Successful in 13m19s

Details

Test / rust-clippy (pull_request) Successful in 14m53s

Details

Test / rust-tests (pull_request) Successful in 17m15s

Details

9eac746f05

sarman reviewed 2026-06-23 00:07:56 +00:00

sarman left a comment

Automated PR Review:

Summary

This PR addresses a rustfmt compliance issue by reformatting the map_err closure in list_storage_content_iso. The change is purely cosmetic with no logic modifications. The code correctly handles error formatting and follows Rust best practices for error propagation.

Findings
No findings.

The change is a standard formatting adjustment to satisfy cargo fmt --check in CI. The error handling pattern is correct:

The closure properly captures node, storage, and e in the format string
Error context is preserved and propagated correctly
No logic changes were made, only whitespace/line breaks

Verdict: APPROVE

Note on Review Process: Per the instructions, I launched 4 parallel analysis agents:

Agent 1 & 2 (CLAUDE.md Compliance): No CLAUDE.md files were found in the provided codebase context that would override standard Rust formatting rules. The change complies with the project's stated lint policy: "ALWAYS run cargo fmt and cargo clippy after any Rust code change".
Agent 3 & 4 (Bug Detection): No bugs detected. The map_err closure correctly transforms the error type and preserves context. The filtering logic for ISO content remains unchanged.
Validation: The formatting change is valid and necessary to pass the CI cargo fmt --check gate mentioned in the PR description.

Automated PR Review: **Summary** This PR addresses a rustfmt compliance issue by reformatting the `map_err` closure in `list_storage_content_iso`. The change is purely cosmetic with no logic modifications. The code correctly handles error formatting and follows Rust best practices for error propagation. **Findings** No findings. The change is a standard formatting adjustment to satisfy `cargo fmt --check` in CI. The error handling pattern is correct: - The closure properly captures `node`, `storage`, and `e` in the format string - Error context is preserved and propagated correctly - No logic changes were made, only whitespace/line breaks **Verdict**: APPROVE --- **Note on Review Process**: Per the instructions, I launched 4 parallel analysis agents: - **Agent 1 & 2 (CLAUDE.md Compliance)**: No CLAUDE.md files were found in the provided codebase context that would override standard Rust formatting rules. The change complies with the project's stated lint policy: "ALWAYS run `cargo fmt` and `cargo clippy` after any Rust code change". - **Agent 3 & 4 (Bug Detection)**: No bugs detected. The `map_err` closure correctly transforms the error type and preserves context. The filtering logic for ISO content remains unchanged. - **Validation**: The formatting change is valid and necessary to pass the CI `cargo fmt --check` gate mentioned in the PR description.

sarman merged commit 41134d6f4c into beta

2026-06-23 00:23:32 +00:00

sarman deleted branch fix/proxmox-full-parity

2026-06-23 00:23:33 +00:00

sarman referenced this issue from a commit

2026-06-23 00:23:33 +00:00

Merge pull request 'fix(fmt): reformat storage.rs map_err closure for rustfmt compliance' (#133) from fix/proxmox-full-parity into beta

Sign in to join this conversation.

No reviewers