fix(proxmox): use camelCase clusterType for Tauri v2 IPC #123

sarman · 2026-06-19T22:39:18Z

sarman commented

2026-06-19 22:39:18 +00:00

The Tauri v2 IPC layer expects camelCase parameter names. The frontend
was sending cluster_type (snake_case), causing the deserialization
failure with error 'command add_proxmox_cluster missing required key
clusterType'.

Changed proxmoxClient.ts line 28 from:
cluster_type: clusterType
to:
clusterType

This aligns with the project's convention where all multi-word
parameters use camelCase (clusterId, nodeId, vmId, etc.).

Fixes the 'Failed to add remote' error when adding new Proxmox remotes.

The Tauri v2 IPC layer expects camelCase parameter names. The frontend was sending cluster_type (snake_case), causing the deserialization failure with error 'command add_proxmox_cluster missing required key clusterType'. Changed proxmoxClient.ts line 28 from: cluster_type: clusterType to: clusterType This aligns with the project's convention where all multi-word parameters use camelCase (clusterId, nodeId, vmId, etc.). Fixes the 'Failed to add remote' error when adding new Proxmox remotes.

sarman added 1 commit 2026-06-19 22:39:19 +00:00

fix(proxmox): use camelCase clusterType for Tauri v2 IPC

Test / frontend-tests (pull_request) Successful in 1m45s

Details

Test / frontend-typecheck (pull_request) Successful in 2m1s

Details

PR Review Automation / review (pull_request) Successful in 5m18s

Details

Test / rust-fmt-check (pull_request) Successful in 12m47s

Details

Test / rust-clippy (pull_request) Successful in 14m23s

Details

Test / rust-tests (pull_request) Successful in 16m12s

Details

f2a795772c

The Tauri v2 IPC layer expects camelCase parameter names. The frontend
was sending cluster_type (snake_case), causing the deserialization
failure with error 'command add_proxmox_cluster missing required key
clusterType'.

Changed proxmoxClient.ts line 28 from:
  cluster_type: clusterType
to:
  clusterType

This aligns with the project's convention where all multi-word
parameters use camelCase (clusterId, nodeId, vmId, etc.).

Fixes the 'Failed to add remote' error when adding new Proxmox remotes.

sarman reviewed 2026-06-19 22:44:35 +00:00

sarman left a comment

Automated PR Review (qwen3.5-122b-think via liteLLM):\n\n

Summary

The PR addresses a Tauri v2 IPC deserialization issue by changing cluster_type (snake_case) to clusterType (camelCase) in the frontend invoke call. This aligns with the project's established convention where all multi-word parameters use camelCase. The change is minimal, focused, and matches the documented fix for the Proxmox remote addition failure.

Findings

[SUGGESTION] src/lib/proxmoxClient.ts:28 - The PR only addresses the clusterType naming convention, but the associated ticket (TICKET-proxmox-add-remote.md) documents three distinct bugs including password type issues in Rust and URL construction problems. These may need separate PRs or should be confirmed as out-of-scope.
Evidence: Ticket mentions password: &str → String fix and URL builder issues in proxox/client.rs and AddRemoteForm.tsx
Fix: Either clarify this PR scope in the title/description, or confirm these are being handled separately
[WARNING] src/lib/proxmoxClient.ts:21-31 - The addProxmoxCluster function returns Promise<ClusterInfo> but the Rust command signature shows add_proxmox_cluster returns Result<ClusterInfo, String>. If the backend fails, the TypeScript side may not properly handle the error type.
Evidence: Function signature shows Promise<ClusterInfo> with no explicit error handling in the invoke wrapper
Fix: Consider adding explicit error type handling or ensure the invoke wrapper properly propagates Tauri errors

Verdict: APPROVE WITH COMMENTS

Automated PR Review (qwen3.5-122b-think via liteLLM):\n\n **Summary** The PR addresses a Tauri v2 IPC deserialization issue by changing `cluster_type` (snake_case) to `clusterType` (camelCase) in the frontend invoke call. This aligns with the project's established convention where all multi-word parameters use camelCase. The change is minimal, focused, and matches the documented fix for the Proxmox remote addition failure. **Findings** - [SUGGESTION] src/lib/proxmoxClient.ts:28 - The PR only addresses the `clusterType` naming convention, but the associated ticket (TICKET-proxmox-add-remote.md) documents three distinct bugs including password type issues in Rust and URL construction problems. These may need separate PRs or should be confirmed as out-of-scope. Evidence: Ticket mentions `password: &str` → `String` fix and URL builder issues in `proxox/client.rs` and `AddRemoteForm.tsx` Fix: Either clarify this PR scope in the title/description, or confirm these are being handled separately - [WARNING] src/lib/proxmoxClient.ts:21-31 - The `addProxmoxCluster` function returns `Promise<ClusterInfo>` but the Rust command signature shows `add_proxmox_cluster` returns `Result<ClusterInfo, String>`. If the backend fails, the TypeScript side may not properly handle the error type. Evidence: Function signature shows `Promise<ClusterInfo>` with no explicit error handling in the invoke wrapper Fix: Consider adding explicit error type handling or ensure the invoke wrapper properly propagates Tauri errors **Verdict**: APPROVE WITH COMMENTS

sarman added 1 commit 2026-06-20 01:09:36 +00:00

Merge branch 'beta' into fix/proxmox-add-remote

PR Review Automation / review (pull_request) Has been cancelled

Details

Test / frontend-typecheck (pull_request) Has been cancelled

Details

Test / frontend-tests (pull_request) Has been cancelled

Details

Test / rust-fmt-check (pull_request) Has been cancelled

Details

Test / rust-tests (pull_request) Has been cancelled

Details