sarman/tftsr-devops_investigation
1
1
Fork 0
Code Issues 4 Pull Requests Actions 34 Packages Projects 3 Releases 6 Wiki Activity

fix(build): add memset_explicit C shim for Windows MinGW libsodium linking #117

Merged
sarman merged 1 commits from fix/cargo-config-sodium into beta 2026-06-19 04:06:36 +00:00
Conversation 0 Commits 1 Files Changed 1 +8 -22
sarman commented 2026-06-19 03:58:38 +00:00
Owner
Copy Link
  1. memset_s_shim.c - C implementation of memset_explicit for Windows MinGW
  2. build.rs (restored) - Already configured to compile the shim for Windows targets
  3. auto-tag.yml & release-beta.yml - Installing libsodium-dev and rpm in build jobs
  4. PR review model - Switched to qwen3.5-122b-think
1. memset_s_shim.c - C implementation of memset_explicit for Windows MinGW 2. build.rs (restored) - Already configured to compile the shim for Windows targets 3. auto-tag.yml & release-beta.yml - Installing libsodium-dev and rpm in build jobs 4. PR review model - Switched to qwen3.5-122b-think
sarman added 1 commit 2026-06-19 03:58:39 +00:00
fix(build): add memset_explicit C shim for Windows MinGW libsodium linking
Some checks failed
PR Review Automation / review (pull_request) Successful in 4m53s
Details
Test / rust-tests (pull_request) Has been cancelled
Details
Test / rust-clippy (pull_request) Has been cancelled
Details
Test / rust-fmt-check (pull_request) Has been cancelled
Details
Test / frontend-tests (pull_request) Successful in 1m52s
Details
Test / frontend-typecheck (pull_request) Successful in 2m3s
Details
b6ecd49b52
sarman reviewed 2026-06-19 04:03:30 +00:00
sarman left a comment
Author
Owner
Copy Link

Automated PR Review (qwen3.5-122b-think via liteLLM):\n\n

Summary

The provided change implements a C shim for memset_explicit, addressing a linking issue with libsodium-sys-stable on Windows MinGW. The implementation correctly uses volatile to prevent compiler optimization of memory writes, which is the primary security requirement for secure memory clearing functions. No high-signal issues, syntax errors, or security vulnerabilities were detected in the provided C file.

Findings

No findings.

Verdict: APPROVE

Automated PR Review (qwen3.5-122b-think via liteLLM):\n\n **Summary** The provided change implements a C shim for `memset_explicit`, addressing a linking issue with `libsodium-sys-stable` on Windows MinGW. The implementation correctly uses `volatile` to prevent compiler optimization of memory writes, which is the primary security requirement for secure memory clearing functions. No high-signal issues, syntax errors, or security vulnerabilities were detected in the provided C file. **Findings** No findings. **Verdict**: APPROVE
sarman merged commit 144c811a7a into beta 2026-06-19 04:06:36 +00:00
sarman deleted branch fix/cargo-config-sodium 2026-06-19 04:06:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sarman/tftsr-devops_investigation#117
No description provided.
Delete Branch "fix/cargo-config-sodium"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?