fix(ci): use SODIUM_LIB_DIR to bypass pkg-config detection #105

Merged
sarman merged 4 commits from fix/libsodium-direct-path into beta 2026-06-14 20:04:47 +00:00

4 Commits

Author SHA1 Message Date
Shaun Arman
7b2377351a docs: update fix summary with commit history
All checks were successful
Test / frontend-tests (pull_request) Successful in 1m42s
Test / frontend-typecheck (pull_request) Successful in 1m51s
PR Review Automation / review (pull_request) Successful in 3m59s
Test / rust-fmt-check (pull_request) Successful in 11m21s
Test / rust-clippy (pull_request) Successful in 13m23s
Test / rust-tests (pull_request) Successful in 15m10s
2026-06-14 11:00:06 -05:00
Shaun Arman
1172f20137 refactor(ci): move SODIUM_LIB_DIR to job-level env
Some checks failed
PR Review Automation / review (pull_request) Successful in 3m20s
Test / rust-clippy (pull_request) Has been cancelled
Test / rust-fmt-check (pull_request) Has been cancelled
Test / frontend-typecheck (pull_request) Has been cancelled
Test / frontend-tests (pull_request) Has been cancelled
Test / rust-tests (pull_request) Has been cancelled
Moved SODIUM_LIB_DIR from per-step env blocks to job-level env for all
three Rust test jobs (rust-fmt-check, rust-clippy, rust-tests).

Benefits:
- Applies to ALL cargo commands in the job, including generate-lockfile
- More maintainable - single declaration per job
- Consistent with best practices for job-wide environment variables

Addresses automated review feedback.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-06-14 10:59:42 -05:00
Shaun Arman
b20deab391 fix: remove use-pkg-config feature conflicting with SODIUM_LIB_DIR
Some checks failed
Test / frontend-tests (pull_request) Successful in 1m39s
Test / frontend-typecheck (pull_request) Successful in 1m47s
PR Review Automation / review (pull_request) Successful in 3m43s
Test / rust-fmt-check (pull_request) Has been cancelled
Test / rust-tests (pull_request) Has been cancelled
Test / rust-clippy (pull_request) Has been cancelled
The use-pkg-config feature was added in the previous PR and conflicts
with SODIUM_LIB_DIR. The build script errors with:

  "SODIUM_LIB_DIR is incompatible with SODIUM_USE_PKG_CONFIG.
   Set the only one env variable"

Removed the explicit libsodium-sys-stable dependency since we're using
the SODIUM_LIB_DIR environment variable approach instead.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-06-14 10:52:55 -05:00
Shaun Arman
863868b2fc fix(ci): use SODIUM_LIB_DIR to bypass pkg-config detection
Some checks failed
Test / frontend-tests (pull_request) Successful in 1m40s
Test / frontend-typecheck (pull_request) Successful in 1m51s
PR Review Automation / review (pull_request) Successful in 3m32s
Test / rust-fmt-check (pull_request) Successful in 11m27s
Test / rust-tests (pull_request) Failing after 11m53s
Test / rust-clippy (pull_request) Failing after 11m55s
Directly specify libsodium library paths via SODIUM_LIB_DIR environment
variable instead of relying on pkg-config detection. This is the highest
priority method in libsodium-sys-stable's build.rs and bypasses all
pkg-config/vcpkg logic.

Platform-specific paths:
- Linux x86_64: /usr/lib/x86_64-linux-gnu
- Linux aarch64: /usr/lib/aarch64-linux-gnu
- Windows MinGW: /usr/x86_64-w64-mingw32/lib

Changes:
- test.yml: Add SODIUM_LIB_DIR to all cargo commands
- auto-tag.yml: Add SODIUM_LIB_DIR to all build jobs

This resolves "libsodium not found via pkg-config or vcpkg" by telling
the build script exactly where libsodium is installed.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-06-14 10:24:46 -05:00