tftsr-devops_investigation/src/components/Kubernetes/JobList.tsx
Shaun Arman f7b4e591f9 fix(performance): resolve memory leaks and add polish features
- Fix LogStreamPanel event listener cleanup with synchronous unlisten
- Fix eventBus async-unsafe unsubscribe with proper error handling
- Fix KubernetesPage infinite loading by resetting state on section change
- Add ErrorBoundary component with reset capability
- Add Badge component with multiple variants
- Add ResourceDetailsDrawer for slide-out details panel
- Add useFavorites hook with localStorage persistence
- Add useKeyboardShortcuts hook for declarative shortcuts
- Add comprehensive test coverage for all new components/hooks
- Add keyboard shortcuts documentation to README
- Wrap KubernetesPage with ErrorBoundary for crash recovery
- Install react-window for virtual scrolling support

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-06-09 13:28:30 -05:00

163 lines
5.3 KiB
TypeScript

import React, { useState } from "react";
import { Table, TableBody, TableCell, TableHead, TableHeader, TableRow } from "@/components/ui";
import { Pencil, Trash2, FileText } from "lucide-react";
import type { JobInfo } from "@/lib/tauriCommands";
import { deleteResourceCmd, getResourceYamlCmd } from "@/lib/tauriCommands";
import { ResourceActionMenu } from "./ResourceActionMenu";
import { ConfirmDeleteDialog } from "./ConfirmDeleteDialog";
import { EditResourceModal } from "./EditResourceModal";
import { WorkloadLogsModal } from "./WorkloadLogsModal";
interface JobListProps {
jobs: JobInfo[];
clusterId?: string;
_clusterId?: string;
namespace?: string;
_namespace?: string;
onRefresh?: () => void;
}
type ActiveModal =
| { type: "logs"; job: JobInfo }
| { type: "edit"; job: JobInfo; yaml: string }
| { type: "delete"; job: JobInfo }
| null;
export function JobList({
jobs,
clusterId,
_clusterId,
onRefresh,
}: JobListProps) {
const cid = clusterId ?? _clusterId ?? "";
const [activeModal, setActiveModal] = useState<ActiveModal>(null);
const [isDeleting, setIsDeleting] = useState(false);
const [actionError, setActionError] = useState<string | null>(null);
const openEdit = async (job: JobInfo) => {
setActionError(null);
try {
const yaml = await getResourceYamlCmd(cid, "jobs", job.namespace, job.name);
setActiveModal({ type: "edit", job, yaml });
} catch (err) {
setActionError(err instanceof Error ? err.message : String(err));
}
};
const handleDelete = async () => {
if (activeModal?.type !== "delete") return;
setIsDeleting(true);
try {
await deleteResourceCmd(cid, "jobs", activeModal.job.namespace, activeModal.job.name);
setActiveModal(null);
onRefresh?.();
} finally {
setIsDeleting(false);
}
};
return (
<>
{actionError && (
<p className="mb-2 text-sm text-destructive">{actionError}</p>
)}
<div className="overflow-x-auto">
<Table>
<TableHeader>
<TableRow>
<TableHead>Name</TableHead>
<TableHead>Namespace</TableHead>
<TableHead>Completions</TableHead>
<TableHead>Duration</TableHead>
<TableHead>Age</TableHead>
<TableHead>Labels</TableHead>
<TableHead className="text-right">Actions</TableHead>
</TableRow>
</TableHeader>
<TableBody>
{jobs.length === 0 ? (
<TableRow>
<TableCell colSpan={7} className="text-center text-muted-foreground">
No jobs found
</TableCell>
</TableRow>
) : (
jobs.map((job) => (
<TableRow key={`${job.name}-${job.namespace}`}>
<TableCell className="font-medium">{job.name}</TableCell>
<TableCell>{job.namespace}</TableCell>
<TableCell>{job.completions}</TableCell>
<TableCell>{job.duration}</TableCell>
<TableCell className="text-muted-foreground">{job.age}</TableCell>
<TableCell>
{Object.entries(job.labels)
.map(([k, v]) => `${k}=${v}`)
.join(", ")}
</TableCell>
<TableCell className="text-right">
<ResourceActionMenu
actions={[
{
label: "Logs",
icon: FileText,
onClick: () => setActiveModal({ type: "logs", job }),
},
{
label: "Edit",
icon: Pencil,
onClick: () => openEdit(job),
},
{
label: "Delete",
icon: Trash2,
variant: "destructive",
onClick: () => setActiveModal({ type: "delete", job }),
},
]}
/>
</TableCell>
</TableRow>
))
)}
</TableBody>
</Table>
</div>
{activeModal?.type === "logs" && (
<WorkloadLogsModal
open
onOpenChange={(o) => { if (!o) setActiveModal(null); }}
clusterId={cid}
namespace={activeModal.job.namespace}
workloadType="job"
workloadName={activeModal.job.name}
labels={activeModal.job.labels}
/>
)}
{activeModal?.type === "edit" && (
<EditResourceModal
isOpen
clusterId={cid}
namespace={activeModal.job.namespace}
resourceType="jobs"
resourceName={activeModal.job.name}
initialYaml={activeModal.yaml}
onClose={() => { setActiveModal(null); onRefresh?.(); }}
/>
)}
{activeModal?.type === "delete" && (
<ConfirmDeleteDialog
open
onOpenChange={(o) => { if (!o) setActiveModal(null); }}
resourceType="Job"
resourceName={activeModal.job.name}
isLoading={isDeleting}
onConfirm={handleDelete}
/>
)}
</>
);
}