tftsr-devops_investigation/src-tauri/src/state.rs
Shaun Arman 9ae89bf487
All checks were successful
Test / frontend-typecheck (pull_request) Successful in 1m49s
Test / frontend-tests (pull_request) Successful in 1m46s
PR Review Automation / review (pull_request) Successful in 4m24s
Test / rust-fmt-check (pull_request) Successful in 12m1s
Test / rust-clippy (pull_request) Successful in 13m46s
Test / rust-tests (pull_request) Successful in 15m8s
fix(security): address automated code review findings
BLOCKER fixes:
- Implement create_azuredevops_workitem instead of returning a stub error,
  reusing the existing create_work_item integration helper and writing an
  audit-log entry on success.
- Log kill failures in PtySession::Drop so leaked child processes surface
  in tracing rather than being silently swallowed.
- Add explicit PTY cleanup on every exit path of run_session_io (process
  exit, read error, write error, resize error, terminate command).
- Treat PTY resize failures as fatal: emit terminal-error to the frontend
  and break the session loop instead of just warning.

WARNING fixes:
- Remove the dead extract_json_path_value helper from commands/kube.rs.
- Wrap temp kubeconfig files in commands/metrics.rs in an RAII guard
  (TempKubeconfig) so they're removed on early-return / panic paths.
- Wrap temp kubeconfig files in commands/shell.rs PTY-session starters
  in a disarmable RAII guard (KubeconfigGuard); if kubectl resolution
  fails we no longer leak the file.
- Drop the `clear;` prefix from the kubectl-exec shell fallback so
  containers without `clear`/`tput` don't print a confusing error.

SUGGESTION fixes:
- Document why node CPU/memory percentages are 0.0 in metrics::client
  and link the gap to future work fetching node capacity.
- Add a module-level doc comment to AppState describing the
  synchronization expectations (std vs tokio Mutex) for each public
  field, and warn against holding std::sync MutexGuards across .await.

Verified: cargo fmt --check, cargo clippy -- -D warnings, and
cargo test (377 passed, 6 ignored) all pass.
2026-06-09 18:08:58 -05:00

191 lines
7.8 KiB
Rust

use serde::{Deserialize, Serialize};
use std::collections::HashMap;
use std::path::PathBuf;
use std::sync::{Arc, Mutex};
use tokio::sync::Mutex as TokioMutex;
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct ProviderConfig {
pub name: String,
#[serde(default)]
pub provider_type: String,
pub api_url: String,
pub api_key: String,
pub model: String,
/// Optional: Maximum tokens for response
#[serde(skip_serializing_if = "Option::is_none")]
pub max_tokens: Option<u32>,
/// Optional: Temperature (0.0-2.0) - controls randomness
#[serde(skip_serializing_if = "Option::is_none")]
pub temperature: Option<f64>,
/// Optional: Custom endpoint path (e.g., "" for no path, "/v1/chat" for custom path)
/// If None, defaults to "/chat/completions" for OpenAI compatibility
#[serde(skip_serializing_if = "Option::is_none")]
pub custom_endpoint_path: Option<String>,
/// Optional: Custom auth header name (e.g., "x-custom-api-key")
/// If None, defaults to "Authorization"
#[serde(skip_serializing_if = "Option::is_none")]
pub custom_auth_header: Option<String>,
/// Optional: Custom auth value prefix (e.g., "" for no prefix, "Bearer " for OpenAI)
/// If None, defaults to "Bearer "
#[serde(skip_serializing_if = "Option::is_none")]
pub custom_auth_prefix: Option<String>,
/// Optional: API format ("openai" or "custom_rest")
/// If None, defaults to "openai"
#[serde(skip_serializing_if = "Option::is_none")]
pub api_format: Option<String>,
/// Optional: Session ID for stateful custom REST APIs
#[serde(skip_serializing_if = "Option::is_none")]
pub session_id: Option<String>,
/// Optional: User ID for custom REST API cost tracking (CORE ID email)
#[serde(skip_serializing_if = "Option::is_none")]
pub user_id: Option<String>,
/// Optional: When true, file uploads go to GenAI datastore instead of prompt
#[serde(skip_serializing_if = "Option::is_none")]
pub use_datastore_upload: Option<bool>,
/// Optional: Whether this provider supports tool/function calling
/// If None, defaults to false (provider can only be used for chat)
#[serde(skip_serializing_if = "Option::is_none")]
pub supports_tool_calling: Option<bool>,
}
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct AppSettings {
pub theme: String,
pub ai_providers: Vec<ProviderConfig>,
pub active_provider: Option<String>,
pub default_provider: String,
pub default_model: String,
pub ollama_url: String,
}
impl Default for AppSettings {
fn default() -> Self {
AppSettings {
theme: "dark".to_string(),
ai_providers: vec![],
active_provider: None,
default_provider: "ollama".to_string(),
default_model: "llama3.2:3b".to_string(),
ollama_url: "http://localhost:11434".to_string(),
}
}
}
/// Approval response for shell command execution
#[derive(Debug, Clone)]
pub struct ApprovalResponse {
pub approved: bool,
pub decision: String, // "deny", "allow_once", "allow_session"
}
/// Application-wide shared state injected into every Tauri command via
/// `State<'_, AppState>`.
///
/// # Synchronization expectations
///
/// All fields except `app_data_dir` are wrapped in either a `std::sync::Mutex`
/// or a `tokio::sync::Mutex`. The choice is deliberate and **must** be
/// preserved by callers:
///
/// - **`std::sync::Mutex`** (e.g. `db`, `settings`, `integration_webviews`,
/// `watchers`): held for short, synchronous critical sections only. **Never
/// hold a `MutexGuard` across an `.await`** — `MutexGuard` is `!Send` and
/// the compiler will reject it. The standard pattern is to lock inside a
/// `{ }` block, take the data needed, drop the guard, then `.await`.
///
/// - **`tokio::sync::Mutex`** (e.g. `mcp_connections`, `pending_approvals`,
/// `clusters`, `port_forwards`, `refresh_registry`, `log_streams`): used
/// for state that must be held across an `.await` (network calls, channel
/// operations, etc.). These have an async `lock().await` API.
///
/// - **`Arc<crate::shell::SessionManager>`**: the manager itself owns its
/// internal locking via `RwLock`; callers do not lock the `Arc`.
///
/// - **`app_data_dir`**: immutable for the lifetime of the process; safe to
/// read without synchronization.
///
/// All fields are `pub` so command handlers in `commands/*.rs` can clone
/// individual `Arc`s into spawned tasks without taking the entire `AppState`.
/// Callers should treat the choice of mutex type as part of the API contract:
/// changing a `std::sync::Mutex` to a `tokio::sync::Mutex` (or vice-versa) is
/// a breaking change for every handler that touches the field.
pub struct AppState {
/// Encrypted SQLite (SQLCipher in release) connection. Short-lived locks
/// only; never held across `.await`.
pub db: Arc<Mutex<rusqlite::Connection>>,
/// In-memory copy of `AppSettings`. Persisted to disk via the settings
/// commands; lock for read/write but never across `.await`.
pub settings: Arc<Mutex<AppSettings>>,
/// Resolved data directory (`~/.local/share/tftsr` on Linux, etc.).
/// Immutable for the process lifetime — no locking needed.
pub app_data_dir: PathBuf,
/// Track open integration webview windows by service name -> window label.
/// Short-lived `std::sync::Mutex`.
pub integration_webviews: Arc<Mutex<HashMap<String, String>>>,
/// Live MCP server connections: server_id -> connection
pub mcp_connections:
Arc<TokioMutex<HashMap<String, Arc<TokioMutex<crate::mcp::client::McpConnection>>>>>,
/// Pending shell command approvals: approval_id -> response channel
pub pending_approvals:
Arc<TokioMutex<HashMap<String, tokio::sync::oneshot::Sender<ApprovalResponse>>>>,
/// Kubernetes cluster clients: cluster_id -> client
pub clusters: Arc<TokioMutex<HashMap<String, crate::kube::ClusterClient>>>,
/// Port forwarding sessions: session_id -> session
pub port_forwards: Arc<TokioMutex<HashMap<String, crate::kube::PortForwardSession>>>,
/// Refresh registry for domain-based data fetching
pub refresh_registry: Arc<TokioMutex<crate::kube::RefreshRegistry>>,
/// Resource watchers: unsubscribe_id -> receiver
pub watchers: Arc<Mutex<HashMap<String, tokio::sync::mpsc::Receiver<serde_json::Value>>>>,
/// Active pod log streaming tasks: stream_id -> abort handle
pub log_streams: Arc<TokioMutex<HashMap<String, tokio::task::AbortHandle>>>,
/// PTY session manager for interactive shells
pub pty_sessions: Arc<crate::shell::SessionManager>,
}
/// Determine the application data directory.
/// Returns None if the directory cannot be determined.
pub fn get_app_data_dir() -> Option<PathBuf> {
if let Ok(dir) = std::env::var("TFTSR_DATA_DIR") {
return Some(PathBuf::from(dir));
}
// Use platform-appropriate data directory
#[cfg(target_os = "linux")]
{
if let Ok(xdg) = std::env::var("XDG_DATA_HOME") {
return Some(PathBuf::from(xdg).join("tftsr"));
}
if let Ok(home) = std::env::var("HOME") {
return Some(
PathBuf::from(home)
.join(".local")
.join("share")
.join("tftsr"),
);
}
}
#[cfg(target_os = "macos")]
{
if let Ok(home) = std::env::var("HOME") {
return Some(
PathBuf::from(home)
.join("Library")
.join("Application Support")
.join("tftsr"),
);
}
}
#[cfg(target_os = "windows")]
{
if let Ok(appdata) = std::env::var("APPDATA") {
return Some(PathBuf::from(appdata).join("tftsr"));
}
}
// Fallback
Some(PathBuf::from("./tftsr-data"))
}