tftsr-devops_investigation/src-tauri
Shaun Arman 68439bcd64
All checks were successful
Test / frontend-typecheck (pull_request) Successful in 2m19s
Test / frontend-tests (pull_request) Successful in 2m10s
PR Review Automation / review (pull_request) Successful in 8m50s
Test / rust-fmt-check (pull_request) Successful in 16m20s
Test / rust-clippy (pull_request) Successful in 17m51s
Test / rust-tests (pull_request) Successful in 19m20s
fix: address PR review findings — race condition, real ping, atomic edit, listener cleanup
Race condition in get_proxmox_client_for_cluster: two concurrent callers
for an uncached cluster could both authenticate and insert, with the second
overwriting the first. Re-check under write lock before inserting so the
later caller returns the already-stored client instead of overwriting it.

handleConnectRemote used getProxmoxCluster (a DB-only lookup) to set status
'connected', which passed even when the Proxmox API was unreachable. Replace
with pingProxmoxCluster, a new command that authenticates and calls
GET /api2/json/version, providing a real end-to-end connectivity test.

handleEditRemote used remove-then-add, leaving a gap where the record was
absent and silently lost if addProxmoxCluster failed. Replace with
updateProxmoxCluster, a new command that issues a single SQL UPDATE (plus
in-memory pool eviction) so the record is never transiently missing.

ActionsMenu useEffect added the mousedown listener only when open=true but
the dependency array contained open, causing ambiguity about cleanup timing.
Attach the listener unconditionally on mount (empty dep array) so there is
always exactly one add and one remove with no conditional branches.

New Rust tests cover update_proxmox_cluster not-found logic and ping error
message format (420 Rust + 386 frontend, zero failures).
2026-06-19 22:26:33 -05:00
..
.cargo fix(build): remove SODIUM_USE_PKG_CONFIG from .cargo/config.toml [env] block 2026-06-17 21:22:55 -05:00
capabilities fix(proxmox): remove dummy data, fix add-remote, fix updater 2026-06-13 17:33:23 -05:00
gen/schemas chore: update Cargo.lock and schema for v1.2.4 2026-06-13 23:28:42 -05:00
icons feat: full copy from apollo_nxt-trcaa with complete sanitization 2026-06-05 14:12:43 -05:00
resources/ollama feat(ui): fix model dropdown, auth prefill, PII persistence, theme toggle, and Ollama bundle 2026-04-05 19:30:41 -05:00
src fix: address PR review findings — race condition, real ping, atomic edit, listener cleanup 2026-06-19 22:26:33 -05:00
tests/kube feat(k8s): implement clean-room Kubernetes management GUI 2026-06-06 20:27:39 -05:00
build.rs fix(windows): compile memset_shim to real .o via get_compiler() to fix MinGW link 2026-06-19 15:21:58 -05:00
Cargo.lock fix: remove use-pkg-config feature conflicting with SODIUM_LIB_DIR 2026-06-14 10:52:55 -05:00
Cargo.toml fix: remove use-pkg-config feature conflicting with SODIUM_LIB_DIR 2026-06-14 10:52:55 -05:00
memset_s_shim.c fix(windows): ensure memset_explicit symbol is properly exported for MinGW 2026-06-19 09:44:17 -05:00
tauri.conf.json chore: bump version to 1.2.4 2026-06-13 23:28:23 -05:00