Some checks failed
Test / frontend-tests (pull_request) Successful in 1m38s
Test / frontend-typecheck (pull_request) Successful in 1m46s
PR Review Automation / review (pull_request) Successful in 5m37s
Test / rust-fmt-check (pull_request) Failing after 12m26s
Test / rust-clippy (pull_request) Successful in 13m43s
Test / rust-tests (pull_request) Successful in 16m4s
- Storage: prevent double-slash ID when cluster/resources returns
shared storage without a node field (e.g. "storage//PBS_TFTSR"
→ "storage/PBS_TFTSR")
- Firewall: add comment explaining why rule_num is omitted from
add_rule — PVE assigns position (pos) automatically on creation
- Network: replace misleading "implementation pending" toasts with
an immediate warning; dialog no longer opens since backend commands
(POST/PUT/DELETE nodes/{node}/network) are not yet implemented
- Backup: same treatment for New Job — warns immediately instead of
opening a form that silently does nothing
- VMList: add comment explaining handleVMAction receives clusterId
from props (not a stale closure over state); add inline comment
clarifying the migration button disabled conditions
202 lines
7.0 KiB
TypeScript
202 lines
7.0 KiB
TypeScript
import React, { useState, useEffect, useCallback } from 'react';
|
|
import { Button } from '@/components/ui/index';
|
|
import { RefreshCw, Plus } from 'lucide-react';
|
|
import { BackupJobList } from '@/components/Proxmox';
|
|
import { listProxmoxClusters, listProxmoxBackupJobs } from '@/lib/proxmoxClient';
|
|
import type { ClusterInfo } from '@/lib/domain';
|
|
import { toast } from 'sonner';
|
|
import { Dialog, DialogContent, DialogHeader, DialogTitle, DialogFooter } from '@/components/ui/index';
|
|
import { Input } from '@/components/ui/index';
|
|
import { Label } from '@/components/ui/index';
|
|
|
|
export function ProxmoxBackupPage() {
|
|
const [clusters, setClusters] = useState<ClusterInfo[]>([]);
|
|
const [selectedClusterId, setSelectedClusterId] = useState<string>('');
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
const [jobs, setJobs] = useState<any[]>([]);
|
|
const [isLoading, setIsLoading] = useState(false);
|
|
const [showNewJobDialog, setShowNewJobDialog] = useState(false);
|
|
|
|
// New job form state
|
|
const [jobName, setJobName] = useState('');
|
|
const [jobNode, setJobNode] = useState('');
|
|
const [jobSchedule, setJobSchedule] = useState('');
|
|
const [jobVms, setJobVms] = useState('');
|
|
|
|
useEffect(() => {
|
|
listProxmoxClusters()
|
|
.then((cls) => {
|
|
setClusters(cls);
|
|
if (cls.length > 0) setSelectedClusterId(cls[0].id);
|
|
})
|
|
.catch((err) => {
|
|
console.error('Failed to load clusters:', err);
|
|
toast.error('Failed to load clusters');
|
|
});
|
|
}, []);
|
|
|
|
const loadJobs = useCallback(async (clusterId: string) => {
|
|
if (!clusterId) return;
|
|
setIsLoading(true);
|
|
try {
|
|
const raw = await listProxmoxBackupJobs(clusterId, '');
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
const normalized = (raw as any[]).map((job) => {
|
|
const enabledRaw = job.enabled ?? job.enable ?? 1;
|
|
const isEnabled = enabledRaw === 1 || enabledRaw === true || enabledRaw === '1';
|
|
const nextRunRaw = job['next-run'] ?? job.next_run ?? job.nextRun;
|
|
const nextRunStr = nextRunRaw
|
|
? new Date(Number(nextRunRaw) * 1000).toLocaleString()
|
|
: undefined;
|
|
return {
|
|
id: job.id || String(job.jobid || ''),
|
|
name: job.id || job.comment || `job-${job.jobid || '?'}`,
|
|
node: job.node || 'all',
|
|
schedule: job.schedule || '-',
|
|
status: isEnabled ? ('idle' as const) : ('idle' as const),
|
|
lastRun: undefined,
|
|
nextRun: nextRunStr,
|
|
size: undefined,
|
|
count: undefined,
|
|
enabled: isEnabled,
|
|
vmid: job.vmid,
|
|
storage: job.storage,
|
|
mode: job.mode,
|
|
compress: job.compress,
|
|
comment: job.comment,
|
|
};
|
|
});
|
|
setJobs(normalized);
|
|
} catch (err) {
|
|
console.error('Failed to load backup jobs:', err);
|
|
toast.error('Failed to load backup jobs');
|
|
} finally {
|
|
setIsLoading(false);
|
|
}
|
|
}, []);
|
|
|
|
useEffect(() => {
|
|
if (selectedClusterId) loadJobs(selectedClusterId);
|
|
}, [selectedClusterId, loadJobs]);
|
|
|
|
const handleNewJob = () => {
|
|
toast.warning(
|
|
'Backup job creation requires additional backend implementation (POST cluster/backup) and is not yet available.',
|
|
);
|
|
};
|
|
|
|
const handleSubmitNewJob = async () => {
|
|
toast.warning('Backup job creation is not yet available.');
|
|
setShowNewJobDialog(false);
|
|
};
|
|
|
|
if (clusters.length === 0 && !isLoading) {
|
|
return (
|
|
<div className="space-y-4">
|
|
<div>
|
|
<h1 className="text-2xl font-bold">Backup Jobs</h1>
|
|
<p className="text-muted-foreground">Manage Proxmox backup schedules</p>
|
|
</div>
|
|
<div className="text-center py-12 text-muted-foreground">
|
|
<p>No Proxmox clusters configured.</p>
|
|
<p className="text-sm mt-1">Add a remote connection first.</p>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
return (
|
|
<div className="space-y-4">
|
|
<div className="flex items-center justify-between">
|
|
<div>
|
|
<h1 className="text-2xl font-bold">Backup Jobs</h1>
|
|
<p className="text-muted-foreground">Manage Proxmox backup schedules</p>
|
|
</div>
|
|
<div className="flex items-center space-x-2">
|
|
{clusters.length > 1 && (
|
|
<select
|
|
className="rounded-md border px-3 py-1.5 text-sm bg-background"
|
|
value={selectedClusterId}
|
|
onChange={(e) => setSelectedClusterId(e.target.value)}
|
|
>
|
|
{clusters.map((c) => (
|
|
<option key={c.id} value={c.id}>{c.name}</option>
|
|
))}
|
|
</select>
|
|
)}
|
|
<Button variant="outline" size="sm" onClick={() => loadJobs(selectedClusterId)}>
|
|
<RefreshCw className="mr-2 h-4 w-4" />
|
|
Refresh
|
|
</Button>
|
|
<Button size="sm" onClick={handleNewJob}>
|
|
<Plus className="mr-2 h-4 w-4" />
|
|
New Job
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
|
|
<BackupJobList
|
|
jobs={jobs}
|
|
onRefresh={() => loadJobs(selectedClusterId)}
|
|
/>
|
|
|
|
<Dialog open={showNewJobDialog} onOpenChange={setShowNewJobDialog}>
|
|
<DialogContent>
|
|
<DialogHeader>
|
|
<DialogTitle>Create New Backup Job</DialogTitle>
|
|
</DialogHeader>
|
|
<div className="space-y-4 py-4">
|
|
<div className="space-y-2">
|
|
<Label htmlFor="jobName">Job Name</Label>
|
|
<Input
|
|
id="jobName"
|
|
value={jobName}
|
|
onChange={(e) => setJobName(e.target.value)}
|
|
placeholder="daily-backup"
|
|
/>
|
|
</div>
|
|
<div className="space-y-2">
|
|
<Label htmlFor="jobNode">Node</Label>
|
|
<Input
|
|
id="jobNode"
|
|
value={jobNode}
|
|
onChange={(e) => setJobNode(e.target.value)}
|
|
placeholder="pve"
|
|
/>
|
|
</div>
|
|
<div className="space-y-2">
|
|
<Label htmlFor="jobSchedule">Schedule (cron format)</Label>
|
|
<Input
|
|
id="jobSchedule"
|
|
value={jobSchedule}
|
|
onChange={(e) => setJobSchedule(e.target.value)}
|
|
placeholder="0 2 * * *"
|
|
/>
|
|
<p className="text-xs text-muted-foreground">
|
|
Example: "0 2 * * *" for daily at 2:00 AM
|
|
</p>
|
|
</div>
|
|
<div className="space-y-2">
|
|
<Label htmlFor="jobVms">VMs to Backup (comma-separated IDs)</Label>
|
|
<Input
|
|
id="jobVms"
|
|
value={jobVms}
|
|
onChange={(e) => setJobVms(e.target.value)}
|
|
placeholder="100, 101, 102"
|
|
/>
|
|
</div>
|
|
</div>
|
|
<DialogFooter>
|
|
<Button variant="outline" onClick={() => setShowNewJobDialog(false)}>
|
|
Cancel
|
|
</Button>
|
|
<Button onClick={handleSubmitNewJob}>
|
|
Create Job
|
|
</Button>
|
|
</DialogFooter>
|
|
</DialogContent>
|
|
</Dialog>
|
|
</div>
|
|
);
|
|
}
|