Some checks failed
Test / frontend-tests (pull_request) Successful in 1m23s
Test / frontend-typecheck (pull_request) Successful in 1m31s
Test / rust-fmt-check (pull_request) Successful in 11m33s
PR Review Automation / review (pull_request) Failing after 2m46s
Test / rust-clippy (pull_request) Successful in 13m16s
Test / rust-tests (pull_request) Has been cancelled
- Backend: kube module with ClusterClient, PortForwardSession, RefreshRegistry - 7 Tauri IPC commands: add_cluster, remove_cluster, list_clusters, start_port_forward, stop_port_forward, list_port_forwards, delete_port_forward, shutdown_port_forwards - AppState extended with clusters, port_forwards, refresh_registry fields - Version bumped to 1.1.0 in Cargo.toml and package.json - Auto-tag workflow updated to mark releases as draft (pre-release) - Buy Me A Coffee section added to README.md - Fixed changelog workflow to only include current tag commits - Proper kubeconfig YAML parsing with extract_context and extract_server_url - Added kubeconfig content storage in ClusterClient - Updated PortForwardSession to include cluster_name - Frontend GUI components: ClusterList, PortForwardList, AddClusterModal, PortForwardForm, KubernetesPage - TypeScript types and IPC commands for Kubernetes management - Unit tests for Kubernetes IPC commands (6 tests) - All 332 Rust tests passing - All 98 frontend tests passing - TypeScript type checks passing - Project builds successfully in release mode - Committed and pushed to feature/kubernetes-management branch - Command injection vulnerability fixed with regex validation and max length check (253 chars) - stop_port_forward and shutdown_port_forwards properly kill kubectl child processes via async child management - Temp file cleanup implemented with RAII TempFileCleanup struct created before std::fs::write - discover_pods now parses actual kubectl JSON output - ChildWaitHandle implemented with background task for waiting on kubectl child - PortForwardSession uses Arc<TokioMutex<Option<Child>>> for async-safe child management - Port-forward uses kubectl's dynamic port binding (0) instead of TcpListener - Added shutdown_port_forwards command for app shutdown cleanup - Added cleanup effect in App.tsx to call shutdownPortForwardsCmd on unmount - Database CRUD operations for clusters and port_forwards added to db.rs - validate_resource_name uses lazy_static! for cached Regex to prevent ReDoS - Cluster struct updated to store kubeconfig_content directly instead of kubeconfig_id - Cluster model in db/models.rs updated to use kubeconfig_content field - load_clusters and load_port_forwards commands registered in lib.rs - Temp file cleanup moved to background task in ChildWaitHandle to ensure cleanup after kubectl completes - Unused child_id field removed from ChildWaitHandle - Command validation moved to beginning of start_port_forward before any operations - Fixed lint errors: removed unused imports, fixed React hooks order, updated type annotations - Updated eslint.config.js to properly configure file patterns
381 lines
8.6 KiB
Rust
381 lines
8.6 KiB
Rust
// Cluster management integration tests
|
|
// Tests: add cluster, list clusters, remove cluster
|
|
|
|
use std::collections::HashMap;
|
|
use std::sync::Arc;
|
|
use std::sync::Mutex as StdMutex;
|
|
use tokio::sync::Mutex as TokioMutex;
|
|
|
|
fn setup_test_state() -> trcaa_lib::state::AppState {
|
|
let conn = rusqlite::Connection::open_in_memory().expect("Failed to create in-memory DB");
|
|
|
|
trcaa_lib::state::AppState {
|
|
db: Arc::new(StdMutex::new(conn)),
|
|
settings: Arc::new(StdMutex::new(trcaa_lib::state::AppSettings::default())),
|
|
app_data_dir: std::path::PathBuf::from("./test-data"),
|
|
integration_webviews: Arc::new(StdMutex::new(HashMap::new())),
|
|
mcp_connections: Arc::new(TokioMutex::new(HashMap::new())),
|
|
pending_approvals: Arc::new(TokioMutex::new(HashMap::new())),
|
|
clusters: Arc::new(TokioMutex::new(HashMap::new())),
|
|
port_forwards: Arc::new(TokioMutex::new(HashMap::new())),
|
|
refresh_registry: Arc::new(TokioMutex::new(trcaa_lib::kube::RefreshRegistry::new())),
|
|
}
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn test_add_cluster_success() {
|
|
let state = setup_test_state();
|
|
|
|
let kubeconfig = r#"
|
|
apiVersion: v1
|
|
kind: Config
|
|
clusters:
|
|
- cluster:
|
|
server: https://k8s.example.com:6443
|
|
name: production
|
|
contexts:
|
|
- context:
|
|
cluster: production
|
|
user: admin
|
|
namespace: default
|
|
name: production-context
|
|
current-context: production-context
|
|
users:
|
|
- name: admin
|
|
user:
|
|
token: test-token
|
|
"#;
|
|
|
|
let result = trcaa_lib::commands::kube::add_cluster(
|
|
"cluster-1".to_string(),
|
|
"Production Cluster".to_string(),
|
|
kubeconfig.to_string(),
|
|
trcaa_lib::State::new(&state),
|
|
)
|
|
.await;
|
|
|
|
assert!(result.is_ok());
|
|
let cluster_info = result.unwrap();
|
|
assert_eq!(cluster_info.id, "cluster-1");
|
|
assert_eq!(cluster_info.name, "Production Cluster");
|
|
assert_eq!(cluster_info.context, "production-context");
|
|
assert_eq!(cluster_info.cluster_url, "https://k8s.example.com:6443");
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn test_add_cluster_empty_content() {
|
|
let state = setup_test_state();
|
|
|
|
let result = trcaa_lib::commands::kube::add_cluster(
|
|
"cluster-1".to_string(),
|
|
"Empty Cluster".to_string(),
|
|
"".to_string(),
|
|
trcaa_lib::State::new(&state),
|
|
)
|
|
.await;
|
|
|
|
assert!(result.is_err());
|
|
assert!(result
|
|
.unwrap_err()
|
|
.contains("Kubeconfig content cannot be empty"));
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn test_add_cluster_missing_contexts() {
|
|
let state = setup_test_state();
|
|
|
|
let kubeconfig = r#"
|
|
apiVersion: v1
|
|
kind: Config
|
|
clusters:
|
|
- cluster:
|
|
server: https://k8s.example.com:6443
|
|
name: production
|
|
users:
|
|
- name: admin
|
|
user:
|
|
token: test-token
|
|
"#;
|
|
|
|
let result = trcaa_lib::commands::kube::add_cluster(
|
|
"cluster-1".to_string(),
|
|
"No Contexts".to_string(),
|
|
kubeconfig.to_string(),
|
|
trcaa_lib::State::new(&state),
|
|
)
|
|
.await;
|
|
|
|
assert!(result.is_err());
|
|
assert!(result.unwrap_err().contains("Missing 'contexts' field"));
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn test_add_cluster_no_contexts() {
|
|
let state = setup_test_state();
|
|
|
|
let kubeconfig = r#"
|
|
apiVersion: v1
|
|
kind: Config
|
|
clusters:
|
|
- cluster:
|
|
server: https://k8s.example.com:6443
|
|
name: production
|
|
contexts: []
|
|
users:
|
|
- name: admin
|
|
user:
|
|
token: test-token
|
|
"#;
|
|
|
|
let result = trcaa_lib::commands::kube::add_cluster(
|
|
"cluster-1".to_string(),
|
|
"Empty Contexts".to_string(),
|
|
kubeconfig.to_string(),
|
|
trcaa_lib::State::new(&state),
|
|
)
|
|
.await;
|
|
|
|
assert!(result.is_err());
|
|
assert!(result.unwrap_err().contains("No contexts found"));
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn test_add_cluster_missing_clusters() {
|
|
let state = setup_test_state();
|
|
|
|
let kubeconfig = r#"
|
|
apiVersion: v1
|
|
kind: Config
|
|
contexts:
|
|
- context:
|
|
cluster: production
|
|
user: admin
|
|
name: production-context
|
|
users:
|
|
- name: admin
|
|
user:
|
|
token: test-token
|
|
"#;
|
|
|
|
let result = trcaa_lib::commands::kube::add_cluster(
|
|
"cluster-1".to_string(),
|
|
"No Clusters".to_string(),
|
|
kubeconfig.to_string(),
|
|
trcaa_lib::State::new(&state),
|
|
)
|
|
.await;
|
|
|
|
assert!(result.is_err());
|
|
assert!(result.unwrap_err().contains("Missing 'clusters' field"));
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn test_add_cluster_invalid_yaml() {
|
|
let state = setup_test_state();
|
|
|
|
let kubeconfig = r#"
|
|
apiVersion: v1
|
|
kind: Config
|
|
invalid yaml here: [
|
|
missing closing bracket
|
|
"#;
|
|
|
|
let result = trcaa_lib::commands::kube::add_cluster(
|
|
"cluster-1".to_string(),
|
|
"Invalid YAML".to_string(),
|
|
kubeconfig.to_string(),
|
|
trcaa_lib::State::new(&state),
|
|
)
|
|
.await;
|
|
|
|
assert!(result.is_err());
|
|
assert!(result.unwrap_err().contains("Invalid kubeconfig YAML"));
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn test_list_clusters_empty() {
|
|
let state = setup_test_state();
|
|
|
|
let result = trcaa_lib::commands::kube::list_clusters(trcaa_lib::State::new(&state)).await;
|
|
|
|
assert!(result.is_ok());
|
|
let clusters = result.unwrap();
|
|
assert!(clusters.is_empty());
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn test_list_clusters_multiple() {
|
|
let state = setup_test_state();
|
|
|
|
// Add first cluster
|
|
let kubeconfig1 = r#"
|
|
apiVersion: v1
|
|
kind: Config
|
|
clusters:
|
|
- cluster:
|
|
server: https://k8s1.example.com:6443
|
|
name: cluster1
|
|
contexts:
|
|
- context:
|
|
cluster: cluster1
|
|
user: user1
|
|
name: context1
|
|
users:
|
|
- name: user1
|
|
user:
|
|
token: token1
|
|
"#;
|
|
|
|
trcaa_lib::commands::kube::add_cluster(
|
|
"cluster-1".to_string(),
|
|
"Cluster 1".to_string(),
|
|
kubeconfig1.to_string(),
|
|
trcaa_lib::State::new(&state),
|
|
)
|
|
.await
|
|
.unwrap();
|
|
|
|
// Add second cluster
|
|
let kubeconfig2 = r#"
|
|
apiVersion: v1
|
|
kind: Config
|
|
clusters:
|
|
- cluster:
|
|
server: https://k8s2.example.com:6443
|
|
name: cluster2
|
|
contexts:
|
|
- context:
|
|
cluster: cluster2
|
|
user: user2
|
|
name: context2
|
|
users:
|
|
- name: user2
|
|
user:
|
|
token: token2
|
|
"#;
|
|
|
|
trcaa_lib::commands::kube::add_cluster(
|
|
"cluster-2".to_string(),
|
|
"Cluster 2".to_string(),
|
|
kubeconfig2.to_string(),
|
|
trcaa_lib::State::new(&state),
|
|
)
|
|
.await
|
|
.unwrap();
|
|
|
|
// List clusters
|
|
let result = trcaa_lib::commands::kube::list_clusters(trcaa_lib::State::new(&state)).await;
|
|
|
|
assert!(result.is_ok());
|
|
let clusters = result.unwrap();
|
|
assert_eq!(clusters.len(), 2);
|
|
|
|
let cluster_names: Vec<&str> = clusters.iter().map(|c| c.name.as_str()).collect();
|
|
assert!(cluster_names.contains(&"Cluster 1"));
|
|
assert!(cluster_names.contains(&"Cluster 2"));
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn test_remove_cluster_success() {
|
|
let state = setup_test_state();
|
|
|
|
// Add a cluster
|
|
let kubeconfig = r#"
|
|
apiVersion: v1
|
|
kind: Config
|
|
clusters:
|
|
- cluster:
|
|
server: https://k8s.example.com:6443
|
|
name: production
|
|
contexts:
|
|
- context:
|
|
cluster: production
|
|
user: admin
|
|
name: prod-context
|
|
users:
|
|
- name: admin
|
|
user:
|
|
token: test-token
|
|
"#;
|
|
|
|
trcaa_lib::commands::kube::add_cluster(
|
|
"cluster-1".to_string(),
|
|
"Production".to_string(),
|
|
kubeconfig.to_string(),
|
|
trcaa_lib::State::new(&state),
|
|
)
|
|
.await
|
|
.unwrap();
|
|
|
|
// Verify cluster exists
|
|
let clusters = trcaa_lib::commands::kube::list_clusters(trcaa_lib::State::new(&state))
|
|
.await
|
|
.unwrap();
|
|
assert_eq!(clusters.len(), 1);
|
|
|
|
// Remove cluster
|
|
let result = trcaa_lib::commands::kube::remove_cluster(
|
|
"cluster-1".to_string(),
|
|
trcaa_lib::State::new(&state),
|
|
)
|
|
.await;
|
|
|
|
assert!(result.is_ok());
|
|
|
|
// Verify cluster is gone
|
|
let clusters = trcaa_lib::commands::kube::list_clusters(trcaa_lib::State::new(&state))
|
|
.await
|
|
.unwrap();
|
|
assert!(clusters.is_empty());
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn test_remove_cluster_not_found() {
|
|
let state = setup_test_state();
|
|
|
|
let result = trcaa_lib::commands::kube::remove_cluster(
|
|
"non-existent".to_string(),
|
|
trcaa_lib::State::new(&state),
|
|
)
|
|
.await;
|
|
|
|
assert!(result.is_err());
|
|
assert!(result
|
|
.unwrap_err()
|
|
.contains("Cluster non-existent not found"));
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn test_add_cluster_with_no_server_url() {
|
|
let state = setup_test_state();
|
|
|
|
let kubeconfig = r#"
|
|
apiVersion: v1
|
|
kind: Config
|
|
clusters:
|
|
- cluster:
|
|
# No server URL
|
|
name: production
|
|
contexts:
|
|
- context:
|
|
cluster: production
|
|
user: admin
|
|
name: prod-context
|
|
users:
|
|
- name: admin
|
|
user:
|
|
token: test-token
|
|
"#;
|
|
|
|
let result = trcaa_lib::commands::kube::add_cluster(
|
|
"cluster-1".to_string(),
|
|
"No Server".to_string(),
|
|
kubeconfig.to_string(),
|
|
trcaa_lib::State::new(&state),
|
|
)
|
|
.await;
|
|
|
|
assert!(result.is_err());
|
|
assert!(result.unwrap_err().contains("Server URL not found"));
|
|
}
|