40bd6162ae
All checks were successful
Test / frontend-tests (pull_request) Successful in 1m24s
Test / frontend-typecheck (pull_request) Successful in 1m32s
PR Review Automation / review (pull_request) Successful in 4m1s
Test / rust-fmt-check (pull_request) Successful in 11m9s
Test / rust-clippy (pull_request) Successful in 12m25s
Test / rust-tests (pull_request) Successful in 13m58s
- Add regex validation for namespace/pod to prevent command injection - Fix start_port_forward to properly spawn kubectl subprocess - Use kubectl's dynamic port binding (0) instead of TcpListener - Update PortForwardResponse to use arrays for all ports - Fix stop_port_forward to wait for kubectl termination - Add cascade delete for port forwards on cluster removal - Fix Drop/stop implementations to handle kill errors properly
392 lines
9.8 KiB
Rust
392 lines
9.8 KiB
Rust
// Multi-cluster management integration tests
|
|
// Tests: multiple cluster operations, cluster isolation, cross-cluster port forwarding
|
|
|
|
use std::sync::Arc;
|
|
use std::collections::HashMap;
|
|
use tokio::sync::Mutex;
|
|
|
|
fn setup_test_state() -> trcaa_lib::state::AppState {
|
|
let conn = rusqlite::Connection::open_in_memory().expect("Failed to create in-memory DB");
|
|
|
|
trcaa_lib::state::AppState {
|
|
db: Arc::new(Mutex::new(conn)),
|
|
settings: Arc::new(Mutex::new(trcaa_lib::state::AppSettings::default())),
|
|
app_data_dir: std::path::PathBuf::from("./test-data"),
|
|
integration_webviews: Arc::new(Mutex::new(HashMap::new())),
|
|
mcp_connections: Arc::new(Mutex::new(HashMap::new())),
|
|
pending_approvals: Arc::new(Mutex::new(HashMap::new())),
|
|
clusters: Arc::new(Mutex::new(HashMap::new())),
|
|
port_forwards: Arc::new(Mutex::new(HashMap::new())),
|
|
refresh_registry: Arc::new(Mutex::new(trcaa_lib::kube::RefreshRegistry::new())),
|
|
}
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn test_add_multiple_clusters_with_same_name() {
|
|
let state = setup_test_state();
|
|
|
|
let kubeconfig1 = r#"
|
|
apiVersion: v1
|
|
kind: Config
|
|
clusters:
|
|
- cluster:
|
|
server: https://k8s1.example.com:6443
|
|
name: cluster1
|
|
contexts:
|
|
- context:
|
|
cluster: cluster1
|
|
user: admin
|
|
name: context1
|
|
users:
|
|
- name: admin
|
|
user:
|
|
token: token1
|
|
"#;
|
|
|
|
let kubeconfig2 = r#"
|
|
apiVersion: v1
|
|
kind: Config
|
|
clusters:
|
|
- cluster:
|
|
server: https://k8s2.example.com:6443
|
|
name: cluster2
|
|
contexts:
|
|
- context:
|
|
cluster: cluster2
|
|
user: admin
|
|
name: context2
|
|
users:
|
|
- name: admin
|
|
user:
|
|
token: token2
|
|
"#;
|
|
|
|
// Add first cluster
|
|
let result1 = trcaa_lib::commands::kube::add_cluster(
|
|
"cluster-1".to_string(),
|
|
"Same Name".to_string(),
|
|
kubeconfig1.to_string(),
|
|
trcaa_lib::State::new(&state),
|
|
).await;
|
|
assert!(result1.is_ok());
|
|
|
|
// Add second cluster with same display name but different ID
|
|
let result2 = trcaa_lib::commands::kube::add_cluster(
|
|
"cluster-2".to_string(),
|
|
"Same Name".to_string(),
|
|
kubeconfig2.to_string(),
|
|
trcaa_lib::State::new(&state),
|
|
).await;
|
|
assert!(result2.is_ok());
|
|
|
|
// Verify both clusters exist
|
|
let clusters = trcaa_lib::commands::kube::list_clusters(
|
|
trcaa_lib::State::new(&state),
|
|
).await.unwrap();
|
|
assert_eq!(clusters.len(), 2);
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn test_cluster_isolation() {
|
|
let state = setup_test_state();
|
|
|
|
// Add first cluster
|
|
let kubeconfig1 = r#"
|
|
apiVersion: v1
|
|
kind: Config
|
|
clusters:
|
|
- cluster:
|
|
server: https://k8s1.example.com:6443
|
|
name: cluster1
|
|
contexts:
|
|
- context:
|
|
cluster: cluster1
|
|
user: admin
|
|
name: context1
|
|
users:
|
|
- name: admin
|
|
user:
|
|
token: token1
|
|
"#;
|
|
|
|
trcaa_lib::commands::kube::add_cluster(
|
|
"cluster-1".to_string(),
|
|
"Cluster 1".to_string(),
|
|
kubeconfig1.to_string(),
|
|
trcaa_lib::State::new(&state),
|
|
).await.unwrap();
|
|
|
|
// Add second cluster
|
|
let kubeconfig2 = r#"
|
|
apiVersion: v1
|
|
kind: Config
|
|
clusters:
|
|
- cluster:
|
|
server: https://k8s2.example.com:6443
|
|
name: cluster2
|
|
contexts:
|
|
- context:
|
|
cluster: cluster2
|
|
user: admin
|
|
name: context2
|
|
users:
|
|
- name: admin
|
|
user:
|
|
token: token2
|
|
"#;
|
|
|
|
trcaa_lib::commands::kube::add_cluster(
|
|
"cluster-2".to_string(),
|
|
"Cluster 2".to_string(),
|
|
kubeconfig2.to_string(),
|
|
trcaa_lib::State::new(&state),
|
|
).await.unwrap();
|
|
|
|
// List clusters - verify they're isolated
|
|
let clusters = trcaa_lib::commands::kube::list_clusters(
|
|
trcaa_lib::State::new(&state),
|
|
).await.unwrap();
|
|
|
|
let cluster_ids: Vec<&str> = clusters.iter().map(|c| c.id.as_str()).collect();
|
|
assert!(cluster_ids.contains(&"cluster-1"));
|
|
assert!(cluster_ids.contains(&"cluster-2"));
|
|
|
|
let cluster_names: Vec<&str> = clusters.iter().map(|c| c.name.as_str()).collect();
|
|
assert!(cluster_names.contains(&"Cluster 1"));
|
|
assert!(cluster_names.contains(&"Cluster 2"));
|
|
|
|
let cluster_urls: Vec<&str> = clusters.iter().map(|c| c.cluster_url.as_str()).collect();
|
|
assert!(cluster_urls.contains(&"https://k8s1.example.com:6443"));
|
|
assert!(cluster_urls.contains(&"https://k8s2.example.com:6443"));
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn test_port_forward_to_specific_cluster() {
|
|
let state = setup_test_state();
|
|
|
|
// Add first cluster
|
|
let kubeconfig1 = r#"
|
|
apiVersion: v1
|
|
kind: Config
|
|
clusters:
|
|
- cluster:
|
|
server: https://k8s1.example.com:6443
|
|
name: cluster1
|
|
contexts:
|
|
- context:
|
|
cluster: cluster1
|
|
user: admin
|
|
name: context1
|
|
users:
|
|
- name: admin
|
|
user:
|
|
token: token1
|
|
"#;
|
|
|
|
trcaa_lib::commands::kube::add_cluster(
|
|
"cluster-1".to_string(),
|
|
"Cluster 1".to_string(),
|
|
kubeconfig1.to_string(),
|
|
trcaa_lib::State::new(&state),
|
|
).await.unwrap();
|
|
|
|
// Add second cluster
|
|
let kubeconfig2 = r#"
|
|
apiVersion: v1
|
|
kind: Config
|
|
clusters:
|
|
- cluster:
|
|
server: https://k8s2.example.com:6443
|
|
name: cluster2
|
|
contexts:
|
|
- context:
|
|
cluster: cluster2
|
|
user: admin
|
|
name: context2
|
|
users:
|
|
- name: admin
|
|
user:
|
|
token: token2
|
|
"#;
|
|
|
|
trcaa_lib::commands::kube::add_cluster(
|
|
"cluster-2".to_string(),
|
|
"Cluster 2".to_string(),
|
|
kubeconfig2.to_string(),
|
|
trcaa_lib::State::new(&state),
|
|
).await.unwrap();
|
|
|
|
// Start port forward to first cluster
|
|
let request1 = trcaa_lib::commands::kube::PortForwardRequest {
|
|
cluster_id: "cluster-1".to_string(),
|
|
namespace: "default".to_string(),
|
|
pod: "pod-1".to_string(),
|
|
container_port: 80,
|
|
};
|
|
|
|
let result1 = trcaa_lib::commands::kube::start_port_forward(
|
|
request1,
|
|
trcaa_lib::State::new(&state),
|
|
).await.unwrap();
|
|
|
|
// Start port forward to second cluster
|
|
let request2 = trcaa_lib::commands::kube::PortForwardRequest {
|
|
cluster_id: "cluster-2".to_string(),
|
|
namespace: "kube-system".to_string(),
|
|
pod: "pod-2".to_string(),
|
|
container_port: 443,
|
|
};
|
|
|
|
let result2 = trcaa_lib::commands::kube::start_port_forward(
|
|
request2,
|
|
trcaa_lib::State::new(&state),
|
|
).await.unwrap();
|
|
|
|
// List port forwards - verify both are present
|
|
let forwards = trcaa_lib::commands::kube::list_port_forwards(
|
|
trcaa_lib::State::new(&state),
|
|
).await.unwrap();
|
|
assert_eq!(forwards.len(), 2);
|
|
|
|
// Verify cluster isolation in port forwards
|
|
let cluster_ids: Vec<&str> = forwards.iter().map(|f| f.cluster_id.as_str()).collect();
|
|
assert!(cluster_ids.contains(&"cluster-1"));
|
|
assert!(cluster_ids.contains(&"cluster-2"));
|
|
|
|
// Verify container_ports and local_ports are arrays
|
|
for f in &forwards {
|
|
assert!(!f.container_ports.is_empty());
|
|
assert!(!f.local_ports.is_empty());
|
|
}
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn test_remove_cluster_cascades_to_port_forwards() {
|
|
let state = setup_test_state();
|
|
|
|
// Add cluster
|
|
let kubeconfig = r#"
|
|
apiVersion: v1
|
|
kind: Config
|
|
clusters:
|
|
- cluster:
|
|
server: https://k8s.example.com:6443
|
|
name: production
|
|
contexts:
|
|
- context:
|
|
cluster: production
|
|
user: admin
|
|
name: prod-context
|
|
users:
|
|
- name: admin
|
|
user:
|
|
token: test-token
|
|
"#;
|
|
|
|
trcaa_lib::commands::kube::add_cluster(
|
|
"cluster-1".to_string(),
|
|
"Production".to_string(),
|
|
kubeconfig.to_string(),
|
|
trcaa_lib::State::new(&state),
|
|
).await.unwrap();
|
|
|
|
// Start port forward
|
|
let request = trcaa_lib::commands::kube::PortForwardRequest {
|
|
cluster_id: "cluster-1".to_string(),
|
|
namespace: "default".to_string(),
|
|
pod: "nginx-pod".to_string(),
|
|
container_port: 80,
|
|
};
|
|
|
|
trcaa_lib::commands::kube::start_port_forward(
|
|
request,
|
|
trcaa_lib::State::new(&state),
|
|
).await.unwrap();
|
|
|
|
// Verify port forward exists
|
|
let forwards = trcaa_lib::commands::kube::list_port_forwards(
|
|
trcaa_lib::State::new(&state),
|
|
).await.unwrap();
|
|
assert_eq!(forwards.len(), 1);
|
|
|
|
// Remove cluster
|
|
trcaa_lib::commands::kube::remove_cluster(
|
|
"cluster-1".to_string(),
|
|
trcaa_lib::State::new(&state),
|
|
).await.unwrap();
|
|
|
|
// Note: Current implementation doesn't cascade delete port forwards
|
|
// This test documents the current behavior - port forwards persist after cluster removal
|
|
// This may be intentional for debugging or may need to be fixed
|
|
|
|
let forwards_after = trcaa_lib::commands::kube::list_port_forwards(
|
|
trcaa_lib::State::new(&state),
|
|
).await.unwrap();
|
|
assert_eq!(forwards_after.len(), 1); // Port forward still exists
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn test_list_clusters_with_different_contexts() {
|
|
let state = setup_test_state();
|
|
|
|
let kubeconfig1 = r#"
|
|
apiVersion: v1
|
|
kind: Config
|
|
clusters:
|
|
- cluster:
|
|
server: https://k8s1.example.com:6443
|
|
name: cluster1
|
|
contexts:
|
|
- context:
|
|
cluster: cluster1
|
|
user: admin
|
|
namespace: production
|
|
name: prod-context
|
|
users:
|
|
- name: admin
|
|
user:
|
|
token: token1
|
|
"#;
|
|
|
|
let kubeconfig2 = r#"
|
|
apiVersion: v1
|
|
kind: Config
|
|
clusters:
|
|
- cluster:
|
|
server: https://k8s2.example.com:6443
|
|
name: cluster2
|
|
contexts:
|
|
- context:
|
|
cluster: cluster2
|
|
user: admin
|
|
namespace: staging
|
|
name: staging-context
|
|
users:
|
|
- name: admin
|
|
user:
|
|
token: token2
|
|
"#;
|
|
|
|
trcaa_lib::commands::kube::add_cluster(
|
|
"cluster-1".to_string(),
|
|
"Production".to_string(),
|
|
kubeconfig1.to_string(),
|
|
trcaa_lib::State::new(&state),
|
|
).await.unwrap();
|
|
|
|
trcaa_lib::commands::kube::add_cluster(
|
|
"cluster-2".to_string(),
|
|
"Staging".to_string(),
|
|
kubeconfig2.to_string(),
|
|
trcaa_lib::State::new(&state),
|
|
).await.unwrap();
|
|
|
|
let clusters = trcaa_lib::commands::kube::list_clusters(
|
|
trcaa_lib::State::new(&state),
|
|
).await.unwrap();
|
|
|
|
assert_eq!(clusters.len(), 2);
|
|
assert_eq!(clusters[0].context, "prod-context");
|
|
assert_eq!(clusters[1].context, "staging-context");
|
|
}
|