tftsr-devops_investigation/src-tauri
Shaun Arman 276fdae104
Some checks failed
Test / rust-fmt-check (pull_request) Successful in 2m19s
Test / rust-clippy (pull_request) Failing after 4m15s
Test / frontend-typecheck (pull_request) Successful in 2m35s
Test / frontend-tests (pull_request) Failing after 1m47s
Test / rust-tests (pull_request) Successful in 6m17s
PR Review Automation / review (pull_request) Successful in 8m17s
fix: address valid PR review findings
Fix two valid issues identified in automated code review:

1. Fix OAuth callback AppState to preserve pending_approvals
   - Clone existing pending_approvals instead of creating empty HashMap
   - Prevents loss of shell approval requests during OAuth flow

2. Add validation to activate_kubeconfig
   - Check that kubeconfig ID exists before activation
   - Return error if ID not found to prevent silent failure

Invalid findings clarified:
- Ollama retry logic is correct (anyhow::bail exits immediately)
- systemctl classification already handles subcommands correctly
  (lines 230-239: status/is-active/is-enabled are Tier 1)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-06-05 09:04:28 -05:00
..
.cargo fix: resolve clippy format-args failures and OpenSSL vendoring issue 2026-04-04 15:05:13 -05:00
capabilities chore: add MIT license, security hardening, and repo hygiene 2026-04-07 12:50:13 -05:00
gen/schemas feat: add image attachment support with PII detection 2026-04-08 20:03:34 -05:00
icons fix: replace empty icon placeholder files with real app icons 2026-03-15 20:31:52 -05:00
resources/ollama feat(ui): fix model dropdown, auth prefill, PII persistence, theme toggle, and Ollama bundle 2026-04-05 19:30:41 -05:00
src fix: address valid PR review findings 2026-06-05 09:04:28 -05:00
build.rs fix: remove invalid --locked flag from cargo commands and fix format string 2026-04-14 20:50:47 -05:00
Cargo.lock feat: add kubectl binary bundling for cross-platform support 2026-06-05 08:22:54 -05:00
Cargo.toml feat: add kubectl binary bundling for cross-platform support 2026-06-05 08:22:54 -05:00
tauri.conf.json fix: bump tauri.conf.json version to 0.3.0 2026-05-23 17:36:38 -05:00