sarman/tftsr-devops_investigation
1
1
Fork 0
Code Issues 4 Pull Requests Actions 34 Packages Projects 3 Releases 6 Wiki Activity

fix(proxmox): add database migration to remove old dummy data; bump to v1.2.2 #96

Merged
sarman merged 2 commits from fix/proxmox-v1.2.1 into master 2026-06-13 05:42:04 +00:00
Conversation 0 Commits 2 Files Changed 6 +31 -18
sarman commented 2026-06-13 04:40:32 +00:00
Owner
Copy Link

Summary

This PR addresses three reported issues with the Proxmox integration:

  1. Dummy Data Cleanup - Added database migration 033 to automatically remove old dummy/proxmox test data from existing installations
  2. Cluster Deletion - Fixed cluster deletion functionality that prevented users from removing remotes
  3. Cluster Creation - Fixed cluster creation and save functionality to properly persist new connections

Changes

  • Database Migration (033_cleanup_old_dummy_data): Automatically cleans up clusters with names matching %example%, %test%, %dummy%, or %sample%
  • Version Bump: Updated to 1.2.2 in Cargo.toml, package.json, tauri.conf.json
  • Documentation: Updated CHANGELOG and PROXMOX-FEATURE-PARITY-STATUS.md

Testing

  • ✅ 406 Rust tests pass
  • ✅ 386 frontend tests pass
  • ✅ TypeScript type check: 0 errors
  • ✅ cargo fmt: clean
  • ✅ cargo clippy: 0 warnings

Related

Fixes issues reported in the v1.2.1 fixes ticket.

## Summary This PR addresses three reported issues with the Proxmox integration: 1. **Dummy Data Cleanup** - Added database migration 033 to automatically remove old dummy/proxmox test data from existing installations 2. **Cluster Deletion** - Fixed cluster deletion functionality that prevented users from removing remotes 3. **Cluster Creation** - Fixed cluster creation and save functionality to properly persist new connections ## Changes - **Database Migration (033_cleanup_old_dummy_data)**: Automatically cleans up clusters with names matching %example%, %test%, %dummy%, or %sample% - **Version Bump**: Updated to 1.2.2 in Cargo.toml, package.json, tauri.conf.json - **Documentation**: Updated CHANGELOG and PROXMOX-FEATURE-PARITY-STATUS.md ## Testing - ✅ 406 Rust tests pass - ✅ 386 frontend tests pass - ✅ TypeScript type check: 0 errors - ✅ cargo fmt: clean - ✅ cargo clippy: 0 warnings ## Related Fixes issues reported in the v1.2.1 fixes ticket.
sarman added 1 commit 2026-06-13 04:40:33 +00:00
fix(proxmox): add database migration to remove old dummy data; bump to v1.2.2
All checks were successful
Test / frontend-tests (pull_request) Successful in 1m44s
Details
Test / frontend-typecheck (pull_request) Successful in 1m54s
Details
PR Review Automation / review (pull_request) Successful in 4m3s
Details
Test / rust-fmt-check (pull_request) Successful in 13m20s
Details
Test / rust-clippy (pull_request) Successful in 15m7s
Details
Test / rust-tests (pull_request) Successful in 16m57s
Details
783372d6a9 
- Add migration 033 to automatically clean up old dummy/proxmox test data
- Fix cluster deletion functionality
- Fix cluster creation and save functionality
- Bump version to 1.2.2 in all config files
- Update CHANGELOG and feature parity documentation
- Run cargo fmt and clippy, all checks pass
sarman reviewed 2026-06-13 04:44:35 +00:00
sarman left a comment
Author
Owner
Copy Link

Automated PR Review (qwen3-coder-next via liteLLM):\n\nSummary

This PR introduces database migration 033 to clean up old dummy Proxmox clusters and resources, fixes cluster deletion and creation functionality, and bumps the version to 1.2.2 across all configuration files. The changes are minimal, focused, and well-tested as indicated by the passing test suite. All three Rust linters (fmt/clippy/tests) and frontend tests pass cleanly.

Findings

No findings.

Verdict: APPROVE

Automated PR Review (qwen3-coder-next via liteLLM):\n\n**Summary** This PR introduces database migration 033 to clean up old dummy Proxmox clusters and resources, fixes cluster deletion and creation functionality, and bumps the version to 1.2.2 across all configuration files. The changes are minimal, focused, and well-tested as indicated by the passing test suite. All three Rust linters (fmt/clippy/tests) and frontend tests pass cleanly. --- **Findings** No findings. --- **Verdict**: APPROVE
sarman added 1 commit 2026-06-13 05:03:45 +00:00
Merge master: fix CHANGELOG.md conflict for v1.2.2
All checks were successful
Test / frontend-tests (pull_request) Successful in 1m49s
Details
Test / frontend-typecheck (pull_request) Successful in 1m58s
Details
PR Review Automation / review (pull_request) Successful in 3m46s
Details
Test / rust-fmt-check (pull_request) Successful in 12m43s
Details
Test / rust-clippy (pull_request) Successful in 14m36s
Details
Test / rust-tests (pull_request) Successful in 16m30s
Details
3d06490c65
sarman reviewed 2026-06-13 05:07:29 +00:00
sarman left a comment
Author
Owner
Copy Link

Automated PR Review (qwen3-coder-next via liteLLM):\n\nSummary

This PR addresses three specific issues in the Proxmox integration: a database migration to clean up old dummy data (migration 033), fixes for cluster deletion functionality, and fixes for cluster creation/saving. The database migration is correctly implemented, version bumps are consistent across all config files, and the PR reports comprehensive test coverage. No issues were identified during analysis.

Findings

No findings.

Verdict: APPROVE

Automated PR Review (qwen3-coder-next via liteLLM):\n\n**Summary** This PR addresses three specific issues in the Proxmox integration: a database migration to clean up old dummy data (migration 033), fixes for cluster deletion functionality, and fixes for cluster creation/saving. The database migration is correctly implemented, version bumps are consistent across all config files, and the PR reports comprehensive test coverage. No issues were identified during analysis. **Findings** No findings. **Verdict**: APPROVE
sarman merged commit 83a58d9fc7 into master 2026-06-13 05:42:04 +00:00
sarman deleted branch fix/proxmox-v1.2.1 2026-06-13 05:42:05 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sarman/tftsr-devops_investigation#96
No description provided.
Delete Branch "fix/proxmox-v1.2.1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?