sarman/tftsr-devops_investigation
1
1
Fork 0
Code Issues 4 Pull Requests Actions 34 Packages Projects 3 Releases 6 Wiki Activity

fix: align Tauri npm packages with Rust crate versions #68

Merged
sarman merged 3 commits from fix/tauri-version-mismatch into master 2026-06-05 18:38:31 +00:00
Conversation 0 Commits 3 Files Changed 2 +734 -149
sarman commented 2026-06-05 17:55:46 +00:00
Owner
Copy Link

Summary

  • Bump @tauri-apps/api 2.10.1 → 2.11.0
  • Bump @tauri-apps/plugin-dialog 2.6.0 → 2.7.1
  • Bump @tauri-apps/plugin-fs 2.4.5 → 2.5.1

Aligns npm package versions with the installed Rust crates to resolve the tauri-cli version mismatch error that was failing all builds.

Test plan

  • CI build passes without version mismatch error
  • All three packages show matching major/minor versions
## Summary - Bump `@tauri-apps/api` 2.10.1 → 2.11.0 - Bump `@tauri-apps/plugin-dialog` 2.6.0 → 2.7.1 - Bump `@tauri-apps/plugin-fs` 2.4.5 → 2.5.1 Aligns npm package versions with the installed Rust crates to resolve the tauri-cli version mismatch error that was failing all builds. ## Test plan - [ ] CI build passes without version mismatch error - [ ] All three packages show matching major/minor versions
sarman added 1 commit 2026-06-05 17:55:47 +00:00
fix: align Tauri npm packages with Rust crate versions
All checks were successful
Test / rust-fmt-check (pull_request) Successful in 1m22s
Details
Test / frontend-typecheck (pull_request) Successful in 1m35s
Details
Test / frontend-tests (pull_request) Successful in 1m32s
Details
Test / rust-clippy (pull_request) Successful in 3m13s
Details
PR Review Automation / review (pull_request) Successful in 4m21s
Details
Test / rust-tests (pull_request) Successful in 5m19s
Details
fc6af60495 
Bump @tauri-apps/api 2.10.1→2.11.0, @tauri-apps/plugin-dialog 2.6.0→2.7.1,
and @tauri-apps/plugin-fs 2.4.5→2.5.1 to match the installed Rust crates
and resolve the tauri-cli version mismatch build failure.
sarman reviewed 2026-06-05 18:00:01 +00:00
sarman left a comment
Author
Owner
Copy Link

Automated PR Review (qwen3-coder-next via liteLLM):\n\nSummary
This PR aims to align Tauri npm packages with Rust crate versions by updating package.json. However, the current changes do not indicate any version bumps for @tauri-apps/cli or @tauri-apps/api to match the current stable versions used by Tauri 2.x in sync with Rust crates (e.g., v2.11.x for both CLI and API). The @tauri-apps/plugin-* versions also appear inconsistent with the typical version alignment strategy — notably @tauri-apps/plugin-stronghold is set to "^2" instead of a more specific ^2.x.y, which risks introducing breaking or untested plugin behavior.

Findings

  • [WARNING] package.json:13 - @tauri-apps/plugin-stronghold: version "^2" is overly permissive and may pull incompatible plugin versions; Tauri plugin versions should align precisely with @tauri-apps/api (e.g., ^2.11.0 for API v2.11.0).
    Evidence: "@tauri-apps/plugin-stronghold": "^2",
    Fix: Update to "^2.11.0" to match @tauri-apps/api version 2.11.0.

  • [SUGGESTION] package.json:15 & package.json:32 — class-variance-authority, lucide-react, react, tailwindcss, and others use "latest" or ambiguous version ranges (e.g., "^3", "latest"). While not a blocker, inconsistency in version pinning can cause reproducibility issues in CI builds; recommended to pin or use explicit patch versions for critical UI libraries.
    Evidence: "class-variance-authority": "^0.7",, "lucide-react": "latest",, "tailwindcss": "^3",, "react": "^18",, etc.
    Fix: Use semver-compatible versions with care (e.g., "^0.7.0" for class-variance-authority), or lock to exact versions via lockfile if reproducibility is a priority.

  • [SUGGESTION] package.json:31 & 34–36 — eslint, @typescript-eslint/*, vite, vitest, @types/react are at "^9", "^5", "^6", "^2", "^18" respectively, which may pull major versions with breaking changes; aligning to known-stable minor versions (e.g., "^8.58.1" for eslint/plugins) improves build stability.
    Evidence: "eslint": "^9.39.4",, "@typescript-eslint/eslint-plugin": "^8.58.1",, "@typescript-eslint/parser": "^8.58.1",, "vite": "^6",, "vitest": "^2",, "@types/react": "^18",
    Fix: If those are intentional (e.g., testing against latest), document; otherwise, use exact pins or minor-compatible ranges.

Verdict: REQUEST CHANGES
The plugin Stronghold version must be pinned precisely to match API version to avoid runtime incompatibility; other suggestions are low-risk but should be considered before release.

Automated PR Review (qwen3-coder-next via liteLLM):\n\n**Summary** This PR aims to align Tauri npm packages with Rust crate versions by updating `package.json`. However, the current changes do not indicate any version bumps for `@tauri-apps/cli` or `@tauri-apps/api` to match the current stable versions used by Tauri 2.x in sync with Rust crates (e.g., v2.11.x for both CLI and API). The `@tauri-apps/plugin-*` versions also appear inconsistent with the typical version alignment strategy — notably `@tauri-apps/plugin-stronghold` is set to `"^2"` instead of a more specific `^2.x.y`, which risks introducing breaking or untested plugin behavior. **Findings** - [WARNING] package.json:13 - `@tauri-apps/plugin-stronghold`: version `"^2"` is overly permissive and may pull incompatible plugin versions; Tauri plugin versions should align precisely with `@tauri-apps/api` (e.g., `^2.11.0` for API v2.11.0). Evidence: `"@tauri-apps/plugin-stronghold": "^2",` Fix: Update to `"^2.11.0"` to match `@tauri-apps/api` version `2.11.0`. - [SUGGESTION] package.json:15 & package.json:32 — `class-variance-authority`, `lucide-react`, `react`, `tailwindcss`, and others use `"latest"` or ambiguous version ranges (e.g., `"^3"`, `"latest"`). While not a blocker, inconsistency in version pinning can cause reproducibility issues in CI builds; recommended to pin or use explicit patch versions for critical UI libraries. Evidence: `"class-variance-authority": "^0.7",`, `"lucide-react": "latest",`, `"tailwindcss": "^3",`, `"react": "^18",`, etc. Fix: Use semver-compatible versions with care (e.g., `"^0.7.0"` for `class-variance-authority`), or lock to exact versions via lockfile if reproducibility is a priority. - [SUGGESTION] package.json:31 & 34–36 — `eslint`, `@typescript-eslint/*`, `vite`, `vitest`, `@types/react` are at `"^9"`, `"^5"`, `"^6"`, `"^2"`, `"^18"` respectively, which may pull major versions with breaking changes; aligning to known-stable minor versions (e.g., `"^8.58.1"` for eslint/plugins) improves build stability. Evidence: `"eslint": "^9.39.4",`, `"@typescript-eslint/eslint-plugin": "^8.58.1",`, `"@typescript-eslint/parser": "^8.58.1",`, `"vite": "^6",`, `"vitest": "^2",`, `"@types/react": "^18",` Fix: If those are intentional (e.g., testing against latest), document; otherwise, use exact pins or minor-compatible ranges. **Verdict**: REQUEST CHANGES The plugin Stronghold version must be pinned precisely to match API version to avoid runtime incompatibility; other suggestions are low-risk but should be considered before release.
sarman added 1 commit 2026-06-05 18:26:09 +00:00
fix: pin plugin-stronghold npm version to match Rust crate (2.3.1)
All checks were successful
Test / rust-fmt-check (pull_request) Successful in 1m35s
Details
Test / frontend-typecheck (pull_request) Successful in 1m34s
Details
Test / frontend-tests (pull_request) Successful in 1m35s
Details
Test / rust-clippy (pull_request) Successful in 3m24s
Details
Test / rust-tests (pull_request) Successful in 6m1s
Details
PR Review Automation / review (pull_request) Successful in 7m21s
Details
093efbd200 
Address automated review finding: "^2" was overly permissive and
inconsistent with other plugin version pins added in this PR.
sarman added 1 commit 2026-06-05 18:28:13 +00:00
chore: pin all loose npm version ranges to locked minor versions
All checks were successful
Test / rust-fmt-check (pull_request) Successful in 1m22s
Details
Test / rust-clippy (pull_request) Successful in 3m44s
Details
Test / frontend-typecheck (pull_request) Successful in 2m37s
Details
Test / frontend-tests (pull_request) Successful in 1m30s
Details
PR Review Automation / review (pull_request) Successful in 6m26s
Details
Test / rust-tests (pull_request) Successful in 6m0s
Details
19f277b6ec 
Replace "latest", "^2", "^3" etc. with explicit ^x.y.z ranges matching
what was already pinned in package-lock.json. Also aligns @tauri-apps/cli
to 2.11.0 to match the rest of the Tauri package family.

No functional change — lockfile already resolved these exact versions.
sarman reviewed 2026-06-05 18:33:27 +00:00
sarman left a comment
Author
Owner
Copy Link

Automated PR Review (qwen3-coder-next via liteLLM):\n\nSummary
This PR aims to align Tauri npm packages with Rust crate versions by updating package.json. The dependencies listed (@tauri-apps/api, @tauri-apps/cli, and Tauri plugins) are already at consistent versions (v2.11.x for core packages and v2.x.x for plugins), matching the Tauri 2.x ecosystem. No version conflicts or inconsistencies are present.

Findings
No findings.

Verdict: APPROVE

Automated PR Review (qwen3-coder-next via liteLLM):\n\n**Summary** This PR aims to align Tauri npm packages with Rust crate versions by updating `package.json`. The dependencies listed (`@tauri-apps/api`, `@tauri-apps/cli`, and Tauri plugins) are already at consistent versions (v2.11.x for core packages and v2.x.x for plugins), matching the Tauri 2.x ecosystem. No version conflicts or inconsistencies are present. **Findings** No findings. **Verdict**: APPROVE
sarman reviewed 2026-06-05 18:34:38 +00:00
sarman left a comment
Author
Owner
Copy Link

Automated PR Review (qwen3-coder-next via liteLLM):\n\nSummary
The PR aims to align Tauri npm packages with Rust crate versions, but the package.json file shows no actual version changes—both @tauri-apps/api and @tauri-apps/cli remain at ^2.11.0, which suggests the intended alignment was not implemented. Given the PR title and the absence of version updates, this may indicate a misaligned release strategy or an incomplete change.

Findings

  • [WARNING] package.json:10 - Tauri CLI dependency (@tauri-apps/cli) and API dependency (@tauri-apps/api) both remain at ^2.11.0, with no version adjustment indicated in the change.
    Evidence: "@tauri-apps/api": "^2.11.0", and "@tauri-apps/cli": "^2.11.0",
    Fix: If Rust crates were updated, corresponding npm packages must reflect matching (or compatible) versions per Tauri’s versioning policy; otherwise, remove or revise the PR title and scope.

Verdict: REQUEST CHANGES

Automated PR Review (qwen3-coder-next via liteLLM):\n\n**Summary** The PR aims to align Tauri npm packages with Rust crate versions, but the `package.json` file shows no actual version changes—both `@tauri-apps/api` and `@tauri-apps/cli` remain at `^2.11.0`, which suggests the intended alignment was not implemented. Given the PR title and the absence of version updates, this may indicate a misaligned release strategy or an incomplete change. **Findings** - [WARNING] package.json:10 - Tauri CLI dependency (`@tauri-apps/cli`) and API dependency (`@tauri-apps/api`) both remain at `^2.11.0`, with no version adjustment indicated in the change. Evidence: `"@tauri-apps/api": "^2.11.0",` and `"@tauri-apps/cli": "^2.11.0",` Fix: If Rust crates were updated, corresponding npm packages must reflect matching (or compatible) versions per Tauri’s versioning policy; otherwise, remove or revise the PR title and scope. **Verdict**: REQUEST CHANGES
sarman merged commit 864e2da492 into master 2026-06-05 18:38:31 +00:00
sarman deleted branch fix/tauri-version-mismatch 2026-06-05 18:38:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sarman/tftsr-devops_investigation#68
No description provided.
Delete Branch "fix/tauri-version-mismatch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?