chore: bump version to 1.0.8 in Cargo.toml and tauri.conf.json #67
No reviewers
Labels
No Label
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: sarman/tftsr-devops_investigation#67
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "fix/version-1.0.8"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Update version in all project files to 1.0.8:
This ensures auto-tag workflow creates correct v1.0.8 release tag.
Automated PR Review (qwen3-coder-next via liteLLM):\n\nSummary
The PR bumps the application version to 1.0.8 in both
Cargo.tomlandtauri.conf.json, as expected. However, the version bump is automatically coupled with changes to schema files (acl-manifests.json,desktop-schema.json,macOS-schema.json) that introduce new permission entries for previously unexposed commands such assupports_multiple_windows,activity_name,scene_identifier,set_icon_with_as_template,start_accessing_security_scoped_resource, andstop_accessing_security_scoped_resource. These commands are not registered in the Tauri command list, which indicates the schema files were likely auto-generated from a newer or mismatched Tauri version — but not from the current codebase, making them inconsistent and potentially unsafe for deployment.Findings
[BLOCKER] src-tauri/gen/schemas/acl-manifests.json:0 - The schema file introduces new permissions for commands (
supports_multiple_windows,activity_name,scene_identifier,set_icon_with_as_template,start_accessing_security_scoped_resource,stop_accessing_security_scoped_resource) that are not registered in thegenerate_handler!list.Evidence: acl-manifests.json contains entries like
"allow-supports-multiple-windows"(incore:app),"allow-activity-name"(incore:window), etc., but no corresponding command handlers exist in the list of registered commands.Fix: Regenerate the schema files using the current Tauri CLI version matching the project’s build setup (ideally
@tauri-apps/cli@^2.x) to ensure only actual command permissions are present, and verify that no unintended permissions are exposed.[BLOCKER] src-tauri/gen/schemas/desktop-schema.json:0 - Same issue as above but for desktop-specific schema; contains permission definitions for unimplemented commands.
Evidence: desktop-schema.json includes
"allow-activity-name"and"allow-scene-identifier"undercore:windowidentifiers (lines ~3587 and ~3591), but no such commands exist incommands::windowor any public Rust function handler.[BLOCKER] src-tauri/gen/schemas/macOS-schema.json:0 - Same issue as above for macOS schema; contains permission definitions for unimplemented commands.
Evidence: macOS-schema.json duplicates the same unregistered command permissions in identical locations (e.g.,
"allow-activity-name"at ~3587), confirming schema drift.[BLOCKER] src-tauri/Cargo.toml:2 - Version bump to 1.0.8 without corresponding dependency version updates or changelog, but since schema changes expose unimplemented APIs, versioning could be misleading.
Evidence:
Cargo.tomlversion field updated to"1.0.8"but schema files expose permissions for commands that do not exist.Fix: Ensure all schema-generating CLI and build tools are in sync with current codebase. If this version bump is for unrelated bug fixes, consider lowering the version or waiting until schema integrity is restored.
Verdict: REQUEST CHANGES
Automated PR Review (qwen3-coder-next via liteLLM):\n\nSummary
This version bump PR (1.0.7 → 1.0.8) modifies
Cargo.tomlandtauri.conf.jsonas intended, but also regenerate schema files (acl-manifests.json,desktop-schema.json,macOS-schema.json) with non-trivial changes. The changes to the schema files introduce new permissions (fs:allow-start-accessing-security-scoped-resource,fs:allow-stop-accessing-security-scoped-resource,core:app:allow-supports-multiple-windows,core:tray:allow-set-icon-with-as-template,core:window:allow-activity-name,core:window:allow-scene-identifier, and their deny counterparts), as well as deprecation notices foraskandconfirmdialog commands. While these changes appear to reflect updates in the Tauri 2 framework and are likely safe, they introduce new permissions without corresponding review in the current PR.Findings
[WARNING] src-tauri/gen/schemas/acl-manifests.json:0 - Schema files contain many new permissions not previously in use; these must be reviewed for over-permissiveness or unexpected side effects.
Evidence: Added
"fs:allow-start-accessing-security-scoped-resource"and"fs:allow-stop-accessing-security-scoped-resource"in multiple files.Fix: Confirm these permissions are required and intentionally granted.
[WARNING] src-tauri/gen/schemas/desktop-schema.json:1126-1138 (and similar in macOS-schema.json) - New FS permissions for macOS security-scoped resources are introduced; not used in codebase index, may expose unnecessary file system access.
Evidence:
"const": "fs:allow-start-accessing-security-scoped-resource"and"fs:allow-stop-accessing-security-scoped-resource"added.Fix: Ensure these are required by the new version (e.g., sandboxedmacOS compatibility) and document their usage.
[WARNING] src-tauri/gen/schemas/desktop-schema.json:2317 (and macOS-schema.json) - Core app permission set now includes
allow-supports-multiple-windows, while no corresponding Tauri command or API usage is registered.Evidence:
"const": "core:app:allow-supports-multiple-windows"added toIdentifieroneOf list.Fix: Verify that
supports_multiple_windowsis intended to be exposed in this release and document its purpose.[WARNING] src-tauri/gen/schemas/desktop-schema.json:3027 (and macOS-schema.json) - Window plugin now includes
activity_nameandscene_identifiercommands in default and individual permissions; not present in registered commands list.Evidence:
"const": "core:window:allow-activity-name"and"const": "core:window:allow-scene-identifier"are now permitted.Fix: Confirm if these commands are implemented or if they are no-ops; otherwise, remove until needed.
[WARNING] src-tauri/gen/schemas/desktop-schema.json:3085 (and macOS-schema.json) - Dialog plugin deprecation notices added for
allow-askandallow-confirm, but no migration path is enforced or documented.Evidence:
"description": "Enables the ask command without any pre-configured scope. (**DEPRECATED**: This is now an alias toallow-messageand will be removed in v3)".Fix: Add migration guidance to changelog or update usage of dialog commands accordingly.
Verdict: REQUEST CHANGES