sarman/tftsr-devops_investigation
1
0
Fork 0
Code Issues 1 Pull Requests Actions 34 Packages Projects 3 Releases 11 Wiki Activity

fix(test): await async data in auditLog test #51

Merged
sarman merged 1 commits from fix/audit-log-test into master 2026-04-20 01:21:57 +00:00
Conversation 0 Commits 1 Files Changed 1 +6 -12
sarman commented 2026-04-20 00:57:05 +00:00
Owner
Copy Link

Summary

  • Fix flaky auditLog.test.tsx that queries role="table" synchronously before async mock data resolves
  • Use findByRole("table") instead of findByText("Audit Log") + getByRole("table") to properly wait for data

Test plan

  • npm run test:run — 94/94 pass (18/18 files)
  • auditLog.test.tsx — 3/3 pass consistently
## Summary - Fix flaky `auditLog.test.tsx` that queries `role="table"` synchronously before async mock data resolves - Use `findByRole("table")` instead of `findByText("Audit Log")` + `getByRole("table")` to properly wait for data ## Test plan - [x] `npm run test:run` — 94/94 pass (18/18 files) - [x] `auditLog.test.tsx` — 3/3 pass consistently
sarman added 1 commit 2026-04-20 00:57:06 +00:00
fix(test): await async data in auditLog test to prevent race condition
Some checks failed
PR Review Automation / review (pull_request) Has been cancelled
Details
Test / rust-fmt-check (pull_request) Successful in 1m7s
Details
Test / frontend-typecheck (pull_request) Successful in 1m16s
Details
Test / frontend-tests (pull_request) Successful in 1m48s
Details
Test / rust-clippy (pull_request) Successful in 8m28s
Details
Test / rust-tests (pull_request) Successful in 10m48s
Details
1db21ae3c1
sarman force-pushed fix/audit-log-test from 1db21ae3c1 to 4a0c7957ec 2026-04-20 01:21:45 +00:00 Compare
sarman merged commit 5a12718566 into master 2026-04-20 01:21:57 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sarman/tftsr-devops_investigation#51
No description provided.
Delete Branch "fix/audit-log-test"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?