sarman/tftsr-devops_investigation
1
1
Fork 0
Code Issues 4 Pull Requests Actions 34 Packages Projects 3 Releases 6 Wiki Activity

fix(ci): unset SODIUM_USE_PKG_CONFIG before cargo builds (beta) #110

Merged
sarman merged 1 commits from fix/unset-sodium-pkg-config-beta into beta 2026-06-18 01:23:10 +00:00
Conversation 0 Commits 1 Files Changed 1 +3
sarman commented 2026-06-18 01:12:38 +00:00
Owner
Copy Link

Problem

The libsodium-sys-stable build script panics when both SODIUM_LIB_DIR and SODIUM_USE_PKG_CONFIG are set simultaneously. The runner infrastructure at 172.0.0.29 has SODIUM_USE_PKG_CONFIG present in the container environment (confirmed: not in any workflow YAML, not in any Dockerfile ENV layer, not a Gitea repository variable — must be runner-level config). This caused the incompatibility panic on every linux-amd64, windows, and arm64 build.

Fix

Add unset SODIUM_USE_PKG_CONFIG to the shell at the start of each platform build step in release-beta.yml. Safe as a no-op if the variable is absent; cleanly neutralises any ambient value when present. SODIUM_LIB_DIR remains set and libsodium links directly from the pre-installed paths in the Docker images.

Platforms fixed

  • linux-amd64: SODIUM_LIB_DIR=/usr/lib/x86_64-linux-gnu
  • windows-amd64: SODIUM_LIB_DIR=/usr/x86_64-w64-mingw32/lib
  • linux-arm64: SODIUM_LIB_DIR=/usr/lib/aarch64-linux-gnu
## Problem The `libsodium-sys-stable` build script panics when both `SODIUM_LIB_DIR` and `SODIUM_USE_PKG_CONFIG` are set simultaneously. The runner infrastructure at `172.0.0.29` has `SODIUM_USE_PKG_CONFIG` present in the container environment (confirmed: not in any workflow YAML, not in any Dockerfile ENV layer, not a Gitea repository variable — must be runner-level config). This caused the incompatibility panic on every linux-amd64, windows, and arm64 build. ## Fix Add `unset SODIUM_USE_PKG_CONFIG` to the shell at the start of each platform build step in `release-beta.yml`. Safe as a no-op if the variable is absent; cleanly neutralises any ambient value when present. `SODIUM_LIB_DIR` remains set and libsodium links directly from the pre-installed paths in the Docker images. ## Platforms fixed - linux-amd64: `SODIUM_LIB_DIR=/usr/lib/x86_64-linux-gnu` - windows-amd64: `SODIUM_LIB_DIR=/usr/x86_64-w64-mingw32/lib` - linux-arm64: `SODIUM_LIB_DIR=/usr/lib/aarch64-linux-gnu`
sarman added 1 commit 2026-06-18 01:12:39 +00:00
fix(ci): unset SODIUM_USE_PKG_CONFIG before cargo builds on all platforms
Some checks failed
PR Review Automation / review (pull_request) Has been cancelled
Details
Test / rust-clippy (pull_request) Has been cancelled
Details
Test / rust-tests (pull_request) Has been cancelled
Details
Test / frontend-typecheck (pull_request) Has been cancelled
Details
Test / rust-fmt-check (pull_request) Has been cancelled
Details
Test / frontend-tests (pull_request) Has been cancelled
Details
0b13b3ebe2 
The libsodium-sys-stable build.rs panics if both SODIUM_LIB_DIR and
SODIUM_USE_PKG_CONFIG are set simultaneously. The runner infrastructure
at 172.0.0.29 has SODIUM_USE_PKG_CONFIG in its container environment
(not traceable to any workflow file or Docker image ENV layer), which
conflicts with the SODIUM_LIB_DIR approach used for cross-compilation.

Explicitly unset SODIUM_USE_PKG_CONFIG in the shell before npm/cargo
runs on all three platforms (linux-amd64, windows-amd64, linux-arm64)
in both release-beta.yml and auto-tag.yml. This is a defensive no-op
when the variable is absent, and a clean fix when it is present.
sarman force-pushed fix/unset-sodium-pkg-config-beta from 0b13b3ebe2 to fffd0b7400 2026-06-18 01:22:44 +00:00 Compare
sarman merged commit a49fbd7ebe into beta 2026-06-18 01:23:10 +00:00
sarman deleted branch fix/unset-sodium-pkg-config-beta 2026-06-18 01:23:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sarman/tftsr-devops_investigation#110
No description provided.
Delete Branch "fix/unset-sodium-pkg-config-beta"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?