sarman/tftsr-devops_investigation
1
1
Fork 0
Code Issues 4 Pull Requests Actions 36 Packages Projects 3 Releases 6 Wiki Activity

fix(ci): correct SODIUM_LIB_DIR config in release-beta.yml #109

Merged
sarman merged 1 commits from fix/beta-sodium-libdir into beta 2026-06-18 00:48:51 +00:00
Conversation 0 Commits 1 Files Changed 1 +2 -1
sarman commented 2026-06-18 00:47:13 +00:00
Owner
Copy Link

Summary

  • Locally tested with Ubuntu 22.04 arm64 + libsodium-sys-stable 1.24.0 to confirm behavior before submitting
  • No env vars → tries to compile libsodium from source, fails (make not in slim containers)
  • SODIUM_LIB_DIR alone → works immediately when libsodium is installed in the Docker image
  • SODIUM_LIB_DIR + SODIUM_USE_PKG_CONFIG → immediate panic (incompatible by design in the crate)

Three changes

  1. linux-amd64: missing all sodium config → add SODIUM_LIB_DIR: /usr/lib/x86_64-linux-gnu
  2. windows: had incompatible SODIUM_LIB_DIR + SODIUM_USE_PKG_CONFIG: no → remove SODIUM_USE_PKG_CONFIG
  3. linux-arm64: missing sodium config → add SODIUM_LIB_DIR: /usr/lib/aarch64-linux-gnu

Test plan

  • linux-amd64 beta build succeeds
  • windows beta build succeeds
  • linux-arm64 beta build succeeds
  • mac continues to work (unchanged)
## Summary - Locally tested with Ubuntu 22.04 arm64 + libsodium-sys-stable 1.24.0 to confirm behavior before submitting - **No env vars** → tries to compile libsodium from source, fails (`make` not in slim containers) - **`SODIUM_LIB_DIR` alone** → works immediately when libsodium is installed in the Docker image - **`SODIUM_LIB_DIR` + `SODIUM_USE_PKG_CONFIG`** → immediate panic (incompatible by design in the crate) ## Three changes 1. **linux-amd64**: missing all sodium config → add `SODIUM_LIB_DIR: /usr/lib/x86_64-linux-gnu` 2. **windows**: had incompatible `SODIUM_LIB_DIR` + `SODIUM_USE_PKG_CONFIG: no` → remove `SODIUM_USE_PKG_CONFIG` 3. **linux-arm64**: missing sodium config → add `SODIUM_LIB_DIR: /usr/lib/aarch64-linux-gnu` ## Test plan - [ ] linux-amd64 beta build succeeds - [ ] windows beta build succeeds - [ ] linux-arm64 beta build succeeds - [ ] mac continues to work (unchanged)
sarman added 1 commit 2026-06-18 00:47:15 +00:00
fix(ci): correct SODIUM_LIB_DIR config in release-beta.yml
Some checks failed
PR Review Automation / review (pull_request) Has been cancelled
Details
Test / rust-tests (pull_request) Has been cancelled
Details
Test / rust-fmt-check (pull_request) Has been cancelled
Details
Test / frontend-typecheck (pull_request) Has been cancelled
Details
Test / rust-clippy (pull_request) Has been cancelled
Details
Test / frontend-tests (pull_request) Has been cancelled
Details
648adf082e 
Tested locally with Ubuntu 22.04 + libsodium-sys-stable 1.24.0:
- No env vars → install_from_source() needs 'make', fails in slim containers
- SODIUM_LIB_DIR alone → works when libsodium is installed in the image
- SODIUM_LIB_DIR + SODIUM_USE_PKG_CONFIG → immediate panic (incompatible by design)

Fixes three broken build targets introduced by the merge conflict resolution:
- linux-amd64: was missing all sodium config, add SODIUM_LIB_DIR
- windows: had SODIUM_LIB_DIR + SODIUM_USE_PKG_CONFIG (incompatible), remove the latter
- linux-arm64: was missing sodium config, add SODIUM_LIB_DIR
sarman merged commit 85f26225ba into beta 2026-06-18 00:48:51 +00:00
sarman deleted branch fix/beta-sodium-libdir 2026-06-18 00:48:51 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sarman/tftsr-devops_investigation#109
No description provided.
Delete Branch "fix/beta-sodium-libdir"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?