Merge pull request 'fix(build): remove SODIUM_USE_PKG_CONFIG from .cargo/config.toml [env] block' (#114 ) from fix/cargo-config-sodium into beta

Reviewed-on: #114
fix(build): remove SODIUM_USE_PKG_CONFIG from .cargo/config.toml [env] block
2026-06-18 02:24:58 +00:00 · 2026-06-17 21:22:55 -05:00 · 2026-06-18 02:09:02 +00:00
1 changed files with 0 additions and 3 deletions
--- a/src-tauri/.cargo/config.toml
+++ b/src-tauri/.cargo/config.toml
@ -9,7 +9,4 @@ rustflags = ["-C", "link-arg=-Wl,--exclude-all-symbols"]
 # Use system OpenSSL instead of vendoring from source (which requires Perl modules
 # unavailable on some environments and breaks clippy/check).
 OPENSSL_NO_VENDOR = "1"
-
-# Force libsodium to use minimal mode which avoids memset_explicit on Windows
-SODIUM_USE_PKG_CONFIG = "0"
 SODIUM_STATIC = "1"
Author	SHA1	Message	Date
sarman	ee909c9cf5	Merge pull request 'fix(build): remove SODIUM_USE_PKG_CONFIG from .cargo/config.toml [env] block' (#114 ) from fix/cargo-config-sodium into beta Some checks failed Release Beta / autotag (push) Successful in 22s Details Test / frontend-tests (push) Successful in 1m56s Details Release Beta / changelog (push) Successful in 1m41s Details Test / frontend-typecheck (push) Successful in 2m5s Details Release Beta / build-linux-amd64 (push) Failing after 5m34s Details Release Beta / build-linux-arm64 (push) Failing after 6m31s Details Release Beta / build-windows-amd64 (push) Successful in 12m20s Details Test / rust-fmt-check (push) Successful in 15m50s Details Test / rust-clippy (push) Successful in 17m51s Details Test / rust-tests (push) Successful in 19m43s Details Release Beta / build-macos-arm64 (push) Failing after 11m41s Details Renovate / renovate (push) Failing after 28s Details Reviewed-on: #114	2026-06-18 02:24:58 +00:00
Shaun Arman	8c29e7a7e3	fix(build): remove SODIUM_USE_PKG_CONFIG from .cargo/config.toml [env] block Some checks failed PR Review Automation / review (pull_request) Has been cancelled Details Test / rust-clippy (pull_request) Has been cancelled Details Test / frontend-tests (pull_request) Has been cancelled Details Test / frontend-typecheck (pull_request) Has been cancelled Details Test / rust-fmt-check (pull_request) Has been cancelled Details Test / rust-tests (pull_request) Has been cancelled Details Cargo injects [env] entries directly into build script environments, bypassing shell-level unset and env -u entirely. SODIUM_USE_PKG_CONFIG was set to "0" in [env], which libsodium-sys-stable build.rs treats as "pkg-config enabled" (env::var().is_ok() returns true for any value including "0"). Combined with SODIUM_LIB_DIR set in the workflow, this triggered the incompatibility panic on every build. The original comment claiming this "avoids memset_explicit on Windows" was incorrect — SODIUM_USE_PKG_CONFIG controls detection strategy, not link behaviour. The actual Windows memset_explicit fix is handled via SODIUM_LIB_DIR pointing to pre-built MinGW sodium.	2026-06-17 21:22:55 -05:00
sarman	cd7bea9ec5	Merge pull request 'fix(ci): use env -u instead of unset to drop SODIUM_USE_PKG_CONFIG' (#113 ) from fix/env-u-sodium into beta Some checks failed Release Beta / autotag (push) Successful in 14s Details Release Beta / changelog (push) Successful in 1m26s Details Test / frontend-tests (push) Successful in 1m53s Details Test / frontend-typecheck (push) Successful in 2m0s Details Release Beta / build-linux-amd64 (push) Failing after 5m4s Details Release Beta / build-windows-amd64 (push) Failing after 5m50s Details Release Beta / build-linux-arm64 (push) Failing after 5m54s Details Release Beta / build-macos-arm64 (push) Successful in 8m19s Details Test / rust-fmt-check (push) Has been cancelled Details Test / rust-tests (push) Has been cancelled Details Test / rust-clippy (push) Has been cancelled Details Reviewed-on: #113	2026-06-18 02:09:02 +00:00