Compare commits

...

2 Commits

Author SHA1 Message Date
b4d8dfc154 Merge pull request 'fix(ci): remove explicit docker.sock mount — act_runner mounts it automatically' (#22) from fix/build-images-duplicate-socket into master
All checks were successful
Auto Tag / autotag (push) Successful in 52s
Auto Tag / wiki-sync (push) Successful in 59s
Auto Tag / build-windows-amd64 (push) Successful in 15m41s
Auto Tag / build-linux-amd64 (push) Successful in 29m29s
Auto Tag / build-linux-arm64 (push) Successful in 29m55s
Auto Tag / build-macos-arm64 (push) Successful in 5m5s
Reviewed-on: #22
2026-04-06 02:18:55 +00:00
Shaun Arman
b0c1167b20 fix(ci): remove explicit docker.sock mount — act_runner mounts it automatically
Some checks failed
Test / rust-fmt-check (pull_request) Has been cancelled
Test / frontend-typecheck (pull_request) Has been cancelled
Test / frontend-tests (pull_request) Has been cancelled
Test / rust-tests (pull_request) Has been cancelled
Test / rust-clippy (pull_request) Has been cancelled
2026-04-05 21:18:11 -05:00
2 changed files with 4 additions and 5 deletions

View File

@ -38,7 +38,6 @@ jobs:
runs-on: linux-amd64 runs-on: linux-amd64
container: container:
image: docker:24-cli image: docker:24-cli
options: -v /var/run/docker.sock:/var/run/docker.sock
steps: steps:
- name: Checkout - name: Checkout
run: | run: |
@ -62,7 +61,6 @@ jobs:
runs-on: linux-amd64 runs-on: linux-amd64
container: container:
image: docker:24-cli image: docker:24-cli
options: -v /var/run/docker.sock:/var/run/docker.sock
steps: steps:
- name: Checkout - name: Checkout
run: | run: |
@ -86,7 +84,6 @@ jobs:
runs-on: linux-amd64 runs-on: linux-amd64
container: container:
image: docker:24-cli image: docker:24-cli
options: -v /var/run/docker.sock:/var/run/docker.sock
steps: steps:
- name: Checkout - name: Checkout
run: | run: |

View File

@ -111,8 +111,10 @@ describe("build-images.yml workflow", () => {
expect(wf).toContain("workflow_dispatch:"); expect(wf).toContain("workflow_dispatch:");
}); });
it("mounts the host Docker socket for image builds", () => { it("does not explicitly mount the Docker socket (act_runner mounts it automatically)", () => {
expect(wf).toContain("-v /var/run/docker.sock:/var/run/docker.sock"); // act_runner already mounts /var/run/docker.sock; an explicit options: mount
// causes a 'Duplicate mount point' error and must not be present.
expect(wf).not.toContain("-v /var/run/docker.sock:/var/run/docker.sock");
}); });
it("authenticates to the local Gitea registry before pushing", () => { it("authenticates to the local Gitea registry before pushing", () => {