7 Commits

Author	SHA1	Message	Date
Shaun Arman	0536a6767b	fix(ci): use env -u instead of unset to drop SODIUM_USE_PKG_CONFIG ... bash unset modifies the current shell's environment but the act_runner at 172.0.0.29 re-injects runner-level environment variables before each cargo invocation, making unset ineffective. env -u removes the variable from the child process's environment at the exec() level, bypassing any runner re-injection entirely. Applies to all three non-macOS platforms (linux-amd64, windows-amd64, linux-arm64) in both release-beta.yml and auto-tag.yml.	2026-06-17 20:35:50 -05:00
Shaun Arman	fffd0b7400	fix(ci): unset SODIUM_USE_PKG_CONFIG before cargo builds on all platforms ... The libsodium-sys-stable build.rs panics if both SODIUM_LIB_DIR and SODIUM_USE_PKG_CONFIG are set simultaneously. The runner infrastructure at 172.0.0.29 has SODIUM_USE_PKG_CONFIG in its container environment (not traceable to any workflow file or Docker image ENV layer), which conflicts with the SODIUM_LIB_DIR approach used for cross-compilation. Explicitly unset SODIUM_USE_PKG_CONFIG in the shell before npm/cargo runs on all three platforms (linux-amd64, windows-amd64, linux-arm64) in both release-beta.yml and auto-tag.yml. This is a defensive no-op when the variable is absent, and a clean fix when it is present.	2026-06-17 20:22:35 -05:00
Shaun Arman	648adf082e	fix(ci): correct SODIUM_LIB_DIR config in release-beta.yml ... Tested locally with Ubuntu 22.04 + libsodium-sys-stable 1.24.0: - No env vars → install_from_source() needs 'make', fails in slim containers - SODIUM_LIB_DIR alone → works when libsodium is installed in the image - SODIUM_LIB_DIR + SODIUM_USE_PKG_CONFIG → immediate panic (incompatible by design) Fixes three broken build targets introduced by the merge conflict resolution: - linux-amd64: was missing all sodium config, add SODIUM_LIB_DIR - windows: had SODIUM_LIB_DIR + SODIUM_USE_PKG_CONFIG (incompatible), remove the latter - linux-arm64: was missing sodium config, add SODIUM_LIB_DIR	2026-06-17 19:46:58 -05:00
Shaun Arman	44ba1bd4e7	fix(ci): use vendored libsodium build instead of pkg-config ... ## Problem Previous approach with SODIUM_USE_PKG_CONFIG=1 still failed: "libsodium not found via pkg-config or vcpkg" pkg-config couldn't locate libsodium.pc in CI containers despite libsodium-dev being installed. ## Solution Use vendored build approach: Remove all SODIUM_* environment variables and let libsodium-sys-stable build from source automatically. ## Changes - **release-beta.yml**: Removed SODIUM_USE_PKG_CONFIG from linux-amd64 and linux-arm64 - **auto-tag.yml**: Removed SODIUM_USE_PKG_CONFIG from linux-amd64 and linux-arm64 - **Windows**: Kept SODIUM_LIB_DIR approach (uses pre-built from Dockerfile) ## Why This Works libsodium-sys-stable build priority: 1. SODIUM_LIB_DIR (if set) → use pre-built 2. SODIUM_USE_PKG_CONFIG (if set) → use pkg-config 3. Neither set → build from source (vendored) ✅ Vendored builds are more reliable in CI as they don't depend on system package installation or pkg-config configuration. ## Validation ✅ Local clean build with vendored libsodium: passed ⏳ CI validation: pending Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>	2026-06-14 04:48:51 -05:00
Shaun Arman	7316339ae2	fix(ci): resolve libsodium pkg-config detection across all platforms ... ## Problem All three CI build platforms (linux-amd64, windows-amd64, linux-arm64) were failing with libsodium detection errors in release-beta.yml: - Linux: "libsodium not found via pkg-config or vcpkg" - Windows: "SODIUM_LIB_DIR is incompatible with SODIUM_USE_PKG_CONFIG" ## Root Cause The libsodium-sys-stable crate requires explicit environment configuration: - Linux needs SODIUM_USE_PKG_CONFIG=1 to find libsodium-dev packages - Windows needs SODIUM_LIB_DIR pointing to pre-built libs OR pkg-config (not both) - Cross-compilation requires complete PKG_CONFIG_PATH for arch-specific .pc files ## Solution ### release-beta.yml fixes: 1. **linux-amd64**: Added SODIUM_USE_PKG_CONFIG=1 2. **windows-amd64**: - Set SODIUM_LIB_DIR=/usr/x86_64-w64-mingw32/lib (was "") - Added SODIUM_USE_PKG_CONFIG=no (explicit disable) - Standardized SODIUM_STATIC=1 (was "yes") 3. **linux-arm64**: - Added SODIUM_USE_PKG_CONFIG=1 - Extended PKG_CONFIG_PATH to include /usr/aarch64-linux-gnu/lib/pkgconfig ### auto-tag.yml fixes: - **linux-arm64**: Extended PKG_CONFIG_PATH (same as release-beta.yml) ## Additional Fix Fixed flaky test `shell::pty::tests::test_is_alive` by adding retry logic for process reaping to handle OS timing variations (macOS was timing out). ## Validation ✅ Local build: cargo check passed ✅ Rust tests: 416 passed, 6 ignored ✅ Frontend tests: 386 passed (45 files) ✅ Linting: cargo clippy + eslint passed ⏳ CI validation: pending push to beta branch Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>	2026-06-14 04:36:44 -05:00
Shaun Arman	9e3e3766e7	fix(build): resolve Windows MinGW memset_explicit linking error ... libsodium-sys requires memset_explicit which is not available in older MinGW toolchains. Added a C shim that provides a fallback implementation using volatile pointers to prevent compiler optimization. Changes: - Added memset_s_shim.c with fallback memset_explicit implementation - Updated build.rs to compile shim for Windows GNU targets - Added cc crate as build dependency - Set CFLAGS in CI to target Windows 8+ (_WIN32_WINNT=0x0602) - Set SODIUM_STATIC=yes to force static libsodium build Fixes linking error: undefined reference to memset_explicit Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>	2026-06-13 23:36:54 -05:00
Shaun Arman	c5cacfd57d	feat(ci): add beta release channel with two-track pipeline ... - Add release-beta.yml: triggers on push to beta, creates v{CARGO}-beta.N pre-release tags with prerelease: true, builds all four platforms; tag counter resets when Cargo.toml version bumps - Add beta to test.yml push triggers so CI runs on direct pushes to beta (pull_request already covers PRs targeting beta) - Implement update_channel in AppSettings (state.rs) with serde default "stable"; wire get/set_update_channel commands to AppState instead of returning hardcoded stubs - Implement channel-aware check_app_updates: queries /releases?limit=20 and picks first non-draft release matching the active channel (stable = !prerelease, beta = prerelease), skipping drafts - Document two-channel strategy in docs/wiki/CICD-Pipeline.md Manual steps still required in Gitea UI: 1. Create beta branch from master 2. Apply same branch protection rules as master to beta 3. Set repo default PR target branch to beta	2026-06-13 17:59:36 -05:00