Commit Graph

1 Commits

Author SHA1 Message Date
Shaun Arman
03c4d5b2f1 refactor(proxmox): extract URL parsing helper and document edit limitation
Some checks failed
Test / frontend-tests (pull_request) Successful in 1m49s
Test / frontend-typecheck (pull_request) Successful in 1m59s
PR Review Automation / review (pull_request) Successful in 7m9s
Test / rust-tests (pull_request) Has been cancelled
Test / rust-clippy (pull_request) Has been cancelled
Test / rust-fmt-check (pull_request) Has been cancelled
Address automated PR review feedback:
- Extract parseRemoteUrl() helper to eliminate code duplication in handleAddRemote and handleEditRemote
- Add JSDoc documentation for the helper function
- Document known architectural limitation in edit operation (remove-then-add pattern)
- Fix pre-existing issue: install missing node_modules dependencies (sonner, monaco-editor)

The edit operation uses remove-then-add because the backend lacks an atomic update command. This is documented as a known limitation until updateProxmoxCluster() is implemented in the Rust backend.

Verification:
- All frontend tests pass (386/386)
- All Rust tests pass (413 passed, 6 ignored)
- ESLint, TypeScript, clippy, rustfmt all pass

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-06-13 23:49:15 -05:00