4 Commits

Author	SHA1	Message	Date
Shaun Arman	82d7f350db	fix(mcp): change plaintext env input to type=text ... Change plaintext_env input field from type='password' to type='text' since this field is explicitly for non-sensitive values (DEBUG, LOG_LEVEL, etc.). Using password type for plaintext config was misleading and prevented copy/paste of legitimate non-sensitive configuration. Only the encrypted_env and http_headers fields remain as type='password' for sensitive values like API keys and tokens.	2026-06-01 12:06:04 -05:00
Shaun Arman	ad42d40365	fix(mcp): improve UX clarity for encrypted env vars during edit ... Add clearer placeholder and helper text to explain that encrypted environment variables are never displayed for security reasons. When editing an existing server, the encrypted_env field shows a placeholder explaining that leaving it blank will preserve existing values. Also apply cargo fmt formatting fixes to store.rs.	2026-06-01 11:58:52 -05:00
Shaun Arman	8b354bb861	fix(mcp): add environment variable and HTTP header support for MCP servers ... Add dual-mode environment variable support for stdio MCP servers and custom HTTP headers for HTTP-based MCP servers to enable proper authentication and configuration. Backend changes (Rust): - Add migration 023 for env_config column in mcp_servers table - Add env_config field to McpServer, CreateMcpServerRequest, UpdateMcpServerRequest - Encrypt env_config using AES-256-GCM on create/update in store.rs - Add get_server_env_config() helper to decrypt and parse env vars - Parse plaintext env from transport_config.env (stdio only) - Parse custom headers from transport_config.headers (HTTP only) - Merge plaintext and encrypted env vars (encrypted takes precedence) - Update connect_stdio() to accept HashMap<String, String> for env vars - Update connect_http() to accept HashMap<String, String> for headers - Apply env vars to tokio::process::Command via .env() method - Add warning for HTTP headers (rmcp v1.7.0 limitation - no .header() method) - Add comprehensive tests for encryption, merging, and clearing Frontend changes (TypeScript/React): - Add env_config field to CreateMcpServerRequest and UpdateMcpServerRequest - Add plaintext_env, encrypted_env, http_headers to ServerForm interface - Add parsing helpers: parseEnvVars(), formatEnvVars(), parseHeaders(), formatHeaders() - Update startEdit() to extract and format env vars/headers from transport_config - Update handleSave() to build transport_config with env/headers and env_config JSON - Add conditional UI fields: stdio (plaintext + encrypted env), HTTP (custom headers) - Use password input type for all sensitive fields Security: - Encrypted env vars stored using AES-256-GCM (matching auth_value pattern) - Plaintext env vars in transport_config for non-sensitive values - UI masks all env/header fields with password input type - Never display decrypted values when editing Fixes inability to configure MCP servers that require environment variables (e.g., GitHub MCP server with GITHUB_PERSONAL_ACCESS_TOKEN). Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>	2026-06-01 08:32:51 -05:00
Shaun Arman	3588399dfd	feat(mcp): add MCP Server Support with TDD implementation ... Adds full Model Context Protocol (MCP) server management, enabling the AI assistant to discover and call tools from external MCP servers during triage conversations. Backend (Rust): - rmcp 1.7.0 dependency (client + stdio + Streamable HTTP transports) - Migration 018: mcp_servers, mcp_tools, mcp_resources tables with CHECK constraints for transport_type, auth_type, discovery_status - src/mcp/ module: models, store, client, adapter, discovery, commands, transport/{stdio,http} - AppState gains mcp_connections: Arc<TokioMutex<HashMap<...>>> - .setup() hook auto-discovers enabled servers at startup - 8 new Tauri commands wired into invoke_handler - execute_mcp_tool_call: PII scan + mandatory audit_log before execution - Auth values encrypted at rest via integrations::auth::encrypt_token(); scrubbed before any frontend response Frontend: - MCPServers.tsx settings page (/settings/mcp) with server list, status badges, Discover Now, Add/Edit modal, enable/disable toggle - tauriCommands.ts: McpServer, McpTool, McpServerStatus types + 8 cmds - App.tsx: Plug icon, /settings/mcp route, sidebar nav entry Tests (TDD): 15 new tests, all green - 5 migration tests (written before migration, red → green) - 5 store CRUD + encryption tests - 5 adapter sanitization + conversion tests Verification: 185/185 Rust, 94/94 Vitest, clippy -D warnings: 0	2026-05-23 16:23:48 -05:00