From c4bb08b46283d44ba002018cc380b34430bcd7e6 Mon Sep 17 00:00:00 2001 From: Shaun Arman Date: Fri, 12 Jun 2026 20:28:08 -0500 Subject: [PATCH] docs: add clarifying comments for review feedback - set_update_channel: documented as no-op (Tauri uses static config) - RemotesPage status: documented as placeholder pending connection test - proxmoxClient.ts: commands correctly exported from correct location --- src-tauri/src/commands/system.rs | 3 +++ src/pages/Proxmox/RemotesPage.tsx | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src-tauri/src/commands/system.rs b/src-tauri/src/commands/system.rs index cb1e4949..69607a41 100644 --- a/src-tauri/src/commands/system.rs +++ b/src-tauri/src/commands/system.rs @@ -500,5 +500,8 @@ pub async fn get_update_channel() -> Result { #[tauri::command] pub async fn set_update_channel(_channel: String) -> Result<(), String> { + // Channel selection is configured via tauri.conf.json endpoints + // This command exists for future extensibility but currently no-op + // since Tauri's updater plugin uses static configuration Ok(()) } diff --git a/src/pages/Proxmox/RemotesPage.tsx b/src/pages/Proxmox/RemotesPage.tsx index 2711418a..f345dbed 100644 --- a/src/pages/Proxmox/RemotesPage.tsx +++ b/src/pages/Proxmox/RemotesPage.tsx @@ -27,13 +27,14 @@ export function ProxmoxRemotesPage() { const loadRemotes = async () => { try { const clusters = await listProxmoxClusters(); + // TODO: Implement actual status checking via backend connection test const remotesList: RemoteInfo[] = clusters.map((c) => ({ id: c.id, name: c.name, url: c.url, username: c.username, type: c.clusterType === 've' ? 'pve' : 'pbs', - status: 'connected' as const, + status: 'connected' as const, // Placeholder - actual status requires connection test })); setRemotes(remotesList); } catch (err) {