sarman/tftsr-devops_investigation
1
0
Fork 0
Code Issues 1 Pull Requests Actions 34 Packages Projects 3 Releases 9 Wiki Activity

Merge pull request 'fix(ci): remove explicit docker.sock mount — act_runner mounts it automatically' (#22) from fix/build-images-duplicate-socket into master
All checks were successful
Auto Tag / autotag (push) Successful in 1m39s
Details
Auto Tag / build-macos-arm64 (push) Successful in 4m42s
Details
Auto Tag / build-windows-amd64 (push) Successful in 16m15s
Details
Auto Tag / build-linux-arm64 (push) Successful in 28m32s
Details
Auto Tag / wiki-sync (push) Successful in 1m44s
Details
Auto Tag / build-linux-amd64 (push) Successful in 26m57s
Details

Browse Source 
Reviewed-on: #22
This commit is contained in:
sarman 2026-04-06 02:18:55 +00:00
commit 9f730304cc
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.gitea/workflows/build-images.yml
View File

@ -38,7 +38,6 @@ jobs:
runs-on: linux-amd64 runs-on: linux-amd64
container: container:
image: docker:24-cli image: docker:24-cli
options: -v /var/run/docker.sock:/var/run/docker.sock
steps: steps:
- name: Checkout - name: Checkout
run: | run: |
@ -62,7 +61,6 @@ jobs:
runs-on: linux-amd64 runs-on: linux-amd64
container: container:
image: docker:24-cli image: docker:24-cli
options: -v /var/run/docker.sock:/var/run/docker.sock
steps: steps:
- name: Checkout - name: Checkout
run: | run: |
@ -86,7 +84,6 @@ jobs:
runs-on: linux-amd64 runs-on: linux-amd64
container: container:
image: docker:24-cli image: docker:24-cli
options: -v /var/run/docker.sock:/var/run/docker.sock
steps: steps:
- name: Checkout - name: Checkout
run: | run: |

6
tests/unit/ciDockerBuilders.test.ts
View File

@ -111,8 +111,10 @@ describe("build-images.yml workflow", () => {
expect(wf).toContain("workflow_dispatch:"); expect(wf).toContain("workflow_dispatch:");
}); });
it("mounts the host Docker socket for image builds", () => { it("does not explicitly mount the Docker socket (act_runner mounts it automatically)", () => {
expect(wf).toContain("-v /var/run/docker.sock:/var/run/docker.sock"); // act_runner already mounts /var/run/docker.sock; an explicit options: mount
// causes a 'Duplicate mount point' error and must not be present.
expect(wf).not.toContain("-v /var/run/docker.sock:/var/run/docker.sock");
}); });
it("authenticates to the local Gitea registry before pushing", () => { it("authenticates to the local Gitea registry before pushing", () => {