sarman/tftsr-devops_investigation
1
1
Fork 0
Code Issues 4 Pull Requests Actions 34 Packages Projects 3 Releases 6 Wiki Activity

fix(build): remove SODIUM_USE_PKG_CONFIG from .cargo/config.toml [env] block
Some checks failed
PR Review Automation / review (pull_request) Has been cancelled
Details
Test / rust-clippy (pull_request) Has been cancelled
Details
Test / frontend-tests (pull_request) Has been cancelled
Details
Test / frontend-typecheck (pull_request) Has been cancelled
Details
Test / rust-fmt-check (pull_request) Has been cancelled
Details
Test / rust-tests (pull_request) Has been cancelled
Details

Browse Source 
Cargo injects [env] entries directly into build script environments,
bypassing shell-level unset and env -u entirely. SODIUM_USE_PKG_CONFIG
was set to "0" in [env], which libsodium-sys-stable build.rs treats as
"pkg-config enabled" (env::var().is_ok() returns true for any value
including "0"). Combined with SODIUM_LIB_DIR set in the workflow, this
triggered the incompatibility panic on every build.

The original comment claiming this "avoids memset_explicit on Windows"
was incorrect — SODIUM_USE_PKG_CONFIG controls detection strategy, not
link behaviour. The actual Windows memset_explicit fix is handled via
SODIUM_LIB_DIR pointing to pre-built MinGW sodium.
This commit is contained in:
Shaun Arman 2026-06-17 21:20:06 -05:00
parent cd7bea9ec5
commit 8c29e7a7e3
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src-tauri/.cargo/config.toml
View File

@ -9,7 +9,4 @@ rustflags = ["-C", "link-arg=-Wl,--exclude-all-symbols"]
# Use system OpenSSL instead of vendoring from source (which requires Perl modules # Use system OpenSSL instead of vendoring from source (which requires Perl modules
# unavailable on some environments and breaks clippy/check). # unavailable on some environments and breaks clippy/check).
OPENSSL_NO_VENDOR = "1" OPENSSL_NO_VENDOR = "1"
# Force libsodium to use minimal mode which avoids memset_explicit on Windows
SODIUM_USE_PKG_CONFIG = "0"
SODIUM_STATIC = "1" SODIUM_STATIC = "1"