sarman/tftsr-devops_investigation
1
1
Fork 0
Code Issues 4 Pull Requests Actions 34 Packages Projects 3 Releases 6 Wiki Activity

refactor(ci): move SODIUM_LIB_DIR to job-level env
Some checks failed
PR Review Automation / review (pull_request) Successful in 3m20s
Details
Test / rust-clippy (pull_request) Has been cancelled
Details
Test / rust-fmt-check (pull_request) Has been cancelled
Details
Test / frontend-typecheck (pull_request) Has been cancelled
Details
Test / frontend-tests (pull_request) Has been cancelled
Details
Test / rust-tests (pull_request) Has been cancelled
Details

Browse Source 
Moved SODIUM_LIB_DIR from per-step env blocks to job-level env for all
three Rust test jobs (rust-fmt-check, rust-clippy, rust-tests).

Benefits:
- Applies to ALL cargo commands in the job, including generate-lockfile
- More maintainable - single declaration per job
- Consistent with best practices for job-wide environment variables

Addresses automated review feedback.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
Shaun Arman 2026-06-14 10:59:42 -05:00
parent b20deab391
commit 1172f20137
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
.gitea/workflows/test.yml
View File

@ -12,6 +12,8 @@ jobs:
runs-on: ubuntu-latest
container:
image: rustlang/rust:nightly
env:
SODIUM_LIB_DIR: /usr/lib/x86_64-linux-gnu
steps:
- name: Checkout
run: |
@ -63,16 +65,14 @@ jobs:
- name: Update version from Git
run: node scripts/update-version.mjs
- run: cargo generate-lockfile --manifest-path src-tauri/Cargo.toml
env:
SODIUM_LIB_DIR: /usr/lib/x86_64-linux-gnu
- run: cargo fmt --manifest-path src-tauri/Cargo.toml --check
env:
SODIUM_LIB_DIR: /usr/lib/x86_64-linux-gnu
rust-clippy:
runs-on: ubuntu-latest
container:
image: rustlang/rust:nightly
env:
SODIUM_LIB_DIR: /usr/lib/x86_64-linux-gnu
steps:
- name: Checkout
run: |
@ -106,13 +106,13 @@ jobs:
- name: Install clippy
run: rustup component add clippy
- run: cargo clippy --manifest-path src-tauri/Cargo.toml -- -D warnings
env:
SODIUM_LIB_DIR: /usr/lib/x86_64-linux-gnu
rust-tests:
runs-on: ubuntu-latest
container:
image: rustlang/rust:nightly
env:
SODIUM_LIB_DIR: /usr/lib/x86_64-linux-gnu
steps:
- name: Checkout
run: |
@ -144,13 +144,9 @@ jobs:
libsodium-dev \
pkg-config
- run: cargo test --manifest-path src-tauri/Cargo.toml -- --test-threads=1
env:
SODIUM_LIB_DIR: /usr/lib/x86_64-linux-gnu
- name: Run shell module tests
run: 'cargo test --manifest-path src-tauri/Cargo.toml "shell::" -- --test-threads=1'
env:
SODIUM_LIB_DIR: /usr/lib/x86_64-linux-gnu
frontend-typecheck:
runs-on: ubuntu-latest