Merge pull request 'feat: add image attachment support with PII detection' (#27) from feat/image-attachments into master
Some checks failed
Auto Tag / autotag (push) Successful in 6s
Auto Tag / wiki-sync (push) Successful in 6s
Auto Tag / build-windows-amd64 (push) Successful in 13m26s
Auto Tag / build-macos-arm64 (push) Failing after 19s
Auto Tag / build-linux-amd64 (push) Successful in 26m30s
Auto Tag / build-linux-arm64 (push) Successful in 27m31s
Some checks failed
Auto Tag / autotag (push) Successful in 6s
Auto Tag / wiki-sync (push) Successful in 6s
Auto Tag / build-windows-amd64 (push) Successful in 13m26s
Auto Tag / build-macos-arm64 (push) Failing after 19s
Auto Tag / build-linux-amd64 (push) Successful in 26m30s
Auto Tag / build-linux-arm64 (push) Successful in 27m31s
Reviewed-on: #27
This commit is contained in:
commit
093bc6ea15
@ -1,175 +0,0 @@
|
||||
# Integration Authentication Guide
|
||||
|
||||
## Overview
|
||||
|
||||
The TRCAA application supports three integration authentication methods, with automatic fallback between them:
|
||||
|
||||
1. **API Tokens** (Manual) - Recommended ✅
|
||||
2. **OAuth 2.0** - Fully automated (when configured)
|
||||
3. **Browser Cookies** - Partially working ⚠️
|
||||
|
||||
## Authentication Priority
|
||||
|
||||
When you ask an AI question, the system attempts authentication in this order:
|
||||
|
||||
```
|
||||
1. Extract cookies from persistent browser window
|
||||
↓ (if fails)
|
||||
2. Use stored API token from database
|
||||
↓ (if fails)
|
||||
3. Skip that integration and log guidance
|
||||
```
|
||||
|
||||
## HttpOnly Cookie Limitation
|
||||
|
||||
**Problem**: Confluence, ServiceNow, and Azure DevOps use **HttpOnly cookies** for security. These cookies:
|
||||
- ✅ Exist in the persistent browser window
|
||||
- ✅ Are sent automatically by the browser
|
||||
- ❌ **Cannot be extracted by JavaScript** (security feature)
|
||||
- ❌ **Cannot be used in separate HTTP requests**
|
||||
|
||||
**Impact**: Cookie extraction via the persistent browser window **fails** for HttpOnly cookies, even though you're logged in.
|
||||
|
||||
## Recommended Solution: Use API Tokens
|
||||
|
||||
### Confluence Personal Access Token
|
||||
|
||||
1. Log into Confluence
|
||||
2. Go to **Profile → Settings → Personal Access Tokens**
|
||||
3. Click **Create token**
|
||||
4. Copy the generated token
|
||||
5. In TRCAA app:
|
||||
- Go to **Settings → Integrations**
|
||||
- Find your Confluence integration
|
||||
- Click **"Save Manual Token"**
|
||||
- Paste the token
|
||||
- Token Type: `Bearer`
|
||||
|
||||
### ServiceNow API Key
|
||||
|
||||
1. Log into ServiceNow
|
||||
2. Go to **System Security → Application Registry**
|
||||
3. Click **New → OAuth API endpoint for external clients**
|
||||
4. Configure and generate API key
|
||||
5. In TRCAA app:
|
||||
- Go to **Settings → Integrations**
|
||||
- Find your ServiceNow integration
|
||||
- Click **"Save Manual Token"**
|
||||
- Paste the API key
|
||||
|
||||
### Azure DevOps Personal Access Token (PAT)
|
||||
|
||||
1. Log into Azure DevOps
|
||||
2. Click **User Settings (top right) → Personal Access Tokens**
|
||||
3. Click **New Token**
|
||||
4. Scopes: Select **Read** for:
|
||||
- Code (for wiki)
|
||||
- Work Items (for work item search)
|
||||
5. Click **Create** and copy the token
|
||||
6. In TRCAA app:
|
||||
- Go to **Settings → Integrations**
|
||||
- Find your Azure DevOps integration
|
||||
- Click **"Save Manual Token"**
|
||||
- Paste the token
|
||||
- Token Type: `Bearer`
|
||||
|
||||
## Verification
|
||||
|
||||
After adding API tokens, test the integration:
|
||||
|
||||
1. Open or create an issue
|
||||
2. Go to Triage page
|
||||
3. Ask a question like: "How do I upgrade Vesta NXT to 1.0.12"
|
||||
4. Check the logs for:
|
||||
```
|
||||
INFO Using stored cookies for confluence (count: 1)
|
||||
INFO Found X integration sources for AI context
|
||||
```
|
||||
|
||||
If successful, the AI response should include:
|
||||
- Content from internal documentation
|
||||
- Source citations with URLs
|
||||
- Links to Confluence/ServiceNow/Azure DevOps pages
|
||||
|
||||
## Troubleshooting
|
||||
|
||||
### No search results found
|
||||
|
||||
**Symptom**: AI gives generic answers instead of internal documentation
|
||||
|
||||
**Check logs for**:
|
||||
```
|
||||
WARN Unable to search confluence - no authentication available
|
||||
```
|
||||
|
||||
**Solution**: Add an API token (see above)
|
||||
|
||||
### Cookie extraction timeout
|
||||
|
||||
**Symptom**: Logs show:
|
||||
```
|
||||
WARN Failed to extract cookies from confluence: Timeout extracting cookies
|
||||
```
|
||||
|
||||
**Why**: HttpOnly cookies cannot be extracted via JavaScript
|
||||
|
||||
**Solution**: Use API tokens instead
|
||||
|
||||
### Integration not configured
|
||||
|
||||
**Symptom**: No integration searches at all
|
||||
|
||||
**Check**: Settings → Integrations - ensure integration is added with:
|
||||
- Base URL configured
|
||||
- Either browser window open OR API token saved
|
||||
|
||||
## Future Enhancements
|
||||
|
||||
### Native Cookie Extraction (Planned)
|
||||
|
||||
We plan to implement platform-specific native cookie extraction that can access HttpOnly cookies directly from the webview's cookie store:
|
||||
|
||||
- **macOS**: Use WKWebView's HTTPCookieStore (requires `cocoa`/`objc` crates)
|
||||
- **Windows**: Use WebView2's cookie manager (requires `windows` crate)
|
||||
- **Linux**: Use WebKitGTK cookie manager (requires `webkit2gtk` binding)
|
||||
|
||||
This will make the persistent browser approach fully automatic, even with HttpOnly cookies.
|
||||
|
||||
### Webview-Based Search (Experimental)
|
||||
|
||||
Another approach is to make search requests FROM within the authenticated webview using JavaScript fetch, which automatically includes HttpOnly cookies. This requires reliable IPC communication between JavaScript and Rust.
|
||||
|
||||
## Security Notes
|
||||
|
||||
### Token Storage
|
||||
|
||||
API tokens are:
|
||||
- ✅ **Encrypted** using AES-256-GCM before storage
|
||||
- ✅ **Hashed** (SHA-256) for audit logging
|
||||
- ✅ Stored in encrypted SQLite database
|
||||
- ✅ Never exposed to frontend JavaScript
|
||||
|
||||
### Cookie Storage (when working)
|
||||
|
||||
Extracted cookies are:
|
||||
- ✅ Encrypted before database storage
|
||||
- ✅ Only retrieved when making API requests
|
||||
- ✅ Transmitted only over HTTPS
|
||||
|
||||
### Audit Trail
|
||||
|
||||
All integration authentication attempts are logged:
|
||||
- Cookie extraction attempts
|
||||
- Token usage
|
||||
- Search requests
|
||||
- Authentication failures
|
||||
|
||||
Check **Settings → Security → Audit Log** to review activity.
|
||||
|
||||
## Summary
|
||||
|
||||
**For reliable integration search NOW**: Use API tokens (Option 1)
|
||||
|
||||
**For automatic integration search LATER**: Native cookie extraction will be implemented in a future update
|
||||
|
||||
**Current workaround**: API tokens provide full functionality without browser dependency
|
||||
27
README.md
27
README.md
@ -4,8 +4,7 @@ A structured, AI-backed desktop tool for IT incident triage, 5-Whys root cause a
|
||||
|
||||
Built with **Tauri 2** (Rust + WebView), **React 18**, **TypeScript**, and **SQLCipher AES-256** encrypted storage.
|
||||
|
||||
[](./LICENSE)
|
||||
|
||||
**CI status:**  — all checks green (rustfmt · clippy · 64 Rust tests · tsc · vitest)
|
||||
|
||||
---
|
||||
|
||||
@ -19,6 +18,7 @@ Built with **Tauri 2** (Rust + WebView), **React 18**, **TypeScript**, and **SQL
|
||||
- **Ollama Management** — Hardware detection, model recommendations, pull/delete models in-app
|
||||
- **Audit Trail** — Every external data send logged with SHA-256 hash
|
||||
- **Domain System Prompts** — Pre-built expert context for 8 IT domains (Linux, Windows, Network, Kubernetes, Databases, Virtualization, Hardware, Observability)
|
||||
- **Image Attachments** — Upload and manage image files with PII detection and mandatory user approval
|
||||
- **Integrations** *(v0.2, coming soon)* — Confluence, ServiceNow, Azure DevOps
|
||||
|
||||
---
|
||||
@ -131,7 +131,6 @@ Launch the app and go to **Settings → AI Providers** to add a provider:
|
||||
| Ollama (local) | `http://localhost:11434` | No key needed — fully offline |
|
||||
| Azure OpenAI | `https://<resource>.openai.azure.com/openai/deployments/<deployment>` | Requires API key |
|
||||
| **AWS Bedrock (via LiteLLM)** | `http://localhost:8000/v1` | See [LiteLLM + AWS Bedrock](#litellm--aws-bedrock-setup) below |
|
||||
| **Custom REST Gateway** | Your gateway URL | See [Custom REST format](docs/wiki/AI-Providers.md) |
|
||||
|
||||
For offline use, install [Ollama](https://ollama.com) and pull a model:
|
||||
```bash
|
||||
@ -289,9 +288,9 @@ All data is stored locally in a SQLCipher-encrypted database at:
|
||||
|
||||
| OS | Path |
|
||||
|---|---|
|
||||
| Linux | `~/.local/share/trcaa/trcaa.db` |
|
||||
| macOS | `~/Library/Application Support/trcaa/trcaa.db` |
|
||||
| Windows | `%APPDATA%\trcaa\trcaa.db` |
|
||||
| Linux | `~/.local/share/tftsr/tftsr.db` |
|
||||
| macOS | `~/Library/Application Support/tftsr/tftsr.db` |
|
||||
| Windows | `%APPDATA%\tftsr\tftsr.db` |
|
||||
|
||||
Override with the `TFTSR_DATA_DIR` environment variable.
|
||||
|
||||
@ -302,8 +301,8 @@ Override with the `TFTSR_DATA_DIR` environment variable.
|
||||
| Variable | Default | Purpose |
|
||||
|---|---|---|
|
||||
| `TFTSR_DATA_DIR` | Platform data dir | Override database location |
|
||||
| `TFTSR_DB_KEY` | _(auto-generated)_ | Database encryption key override — auto-generated at first launch if unset |
|
||||
| `TFTSR_ENCRYPTION_KEY` | _(auto-generated)_ | Credential encryption key override — auto-generated at first launch if unset |
|
||||
| `TFTSR_DB_KEY` | _(none)_ | Database encryption key (required in release builds) |
|
||||
| `TFTSR_ENCRYPTION_KEY` | _(none)_ | Credential encryption key (required in release builds) |
|
||||
| `RUST_LOG` | `info` | Tracing log level (`debug`, `info`, `warn`, `error`) |
|
||||
|
||||
---
|
||||
@ -327,16 +326,6 @@ Override with the `TFTSR_DATA_DIR` environment variable.
|
||||
|
||||
---
|
||||
|
||||
## Support
|
||||
|
||||
If this tool has been useful to you, consider buying me a coffee!
|
||||
|
||||
[](https://buymeacoffee.com/tftsr)
|
||||
|
||||
---
|
||||
|
||||
## License
|
||||
|
||||
MIT © 2025 [Shaun Arman](https://github.com/sarman)
|
||||
|
||||
See [LICENSE](./LICENSE) for the full text. You are free to use, modify, and distribute this software — personal, commercial, or enterprise — as long as the original copyright notice is retained.
|
||||
Private — internal tooling. All rights reserved.
|
||||
|
||||
@ -1,254 +0,0 @@
|
||||
# Ticket Summary - Persistent Browser Windows for Integration Authentication
|
||||
|
||||
## Description
|
||||
|
||||
Implement persistent browser window sessions for integration authentication (Confluence, Azure DevOps, ServiceNow). Browser windows now persist across application restarts, eliminating the need to extract HttpOnly cookies via JavaScript (which fails due to browser security restrictions).
|
||||
|
||||
This follows a Playwright-style "piggyback" authentication approach where the browser window maintains its own internal cookie store, allowing the user to log in once and have the session persist indefinitely until they manually close the window.
|
||||
|
||||
## Acceptance Criteria
|
||||
|
||||
- [x] Integration browser windows persist to database when created
|
||||
- [x] Browser windows are automatically restored on app startup
|
||||
- [x] Cookies are maintained automatically by the browser's internal store (no JavaScript extraction of HttpOnly cookies)
|
||||
- [x] Windows can be manually closed by the user, which removes them from persistence
|
||||
- [x] Database migration creates `persistent_webviews` table
|
||||
- [x] Window close events are handled to update database and in-memory tracking
|
||||
|
||||
## Work Implemented
|
||||
|
||||
### 1. Database Migration for Persistent Webviews
|
||||
|
||||
**Files Modified:**
|
||||
- `src-tauri/src/db/migrations.rs:154-167`
|
||||
|
||||
**Changes:**
|
||||
- Added migration `013_create_persistent_webviews` to create the `persistent_webviews` table
|
||||
- Table schema includes:
|
||||
- `id` (TEXT PRIMARY KEY)
|
||||
- `service` (TEXT with CHECK constraint for 'confluence', 'servicenow', 'azuredevops')
|
||||
- `webview_label` (TEXT - the Tauri window identifier)
|
||||
- `base_url` (TEXT - the integration base URL)
|
||||
- `last_active` (TEXT timestamp, defaults to now)
|
||||
- `window_x`, `window_y`, `window_width`, `window_height` (INTEGER - for future window position persistence)
|
||||
- UNIQUE constraint on `service` (one browser window per integration)
|
||||
|
||||
### 2. Webview Persistence on Creation
|
||||
|
||||
**Files Modified:**
|
||||
- `src-tauri/src/commands/integrations.rs:531-591`
|
||||
|
||||
**Changes:**
|
||||
- Modified `authenticate_with_webview` command to persist webview state to database after creation
|
||||
- Stores service name, webview label, and base URL
|
||||
- Logs persistence operation for debugging
|
||||
- Sets up window close event handler to remove webview from tracking and database
|
||||
- Event handler properly clones Arc fields for `'static` lifetime requirement
|
||||
- Updated success message to inform user that window persists across restarts
|
||||
|
||||
### 3. Webview Restoration on App Startup
|
||||
|
||||
**Files Modified:**
|
||||
- `src-tauri/src/commands/integrations.rs:793-865` - Added `restore_persistent_webviews` function
|
||||
- `src-tauri/src/lib.rs:60-84` - Added `.setup()` hook to call restoration
|
||||
|
||||
**Changes:**
|
||||
- Added `restore_persistent_webviews` async function that:
|
||||
- Queries `persistent_webviews` table for all saved webviews
|
||||
- Recreates each webview window by calling `authenticate_with_webview`
|
||||
- Updates in-memory tracking map
|
||||
- Removes from database if restoration fails
|
||||
- Logs all operations for debugging
|
||||
- Updated `lib.rs` to call restoration in `.setup()` hook:
|
||||
- Clones Arc fields from `AppState` for `'static` lifetime
|
||||
- Spawns async task to restore webviews
|
||||
- Logs warnings if restoration fails
|
||||
|
||||
### 4. Window Close Event Handling
|
||||
|
||||
**Files Modified:**
|
||||
- `src-tauri/src/commands/integrations.rs:559-591`
|
||||
|
||||
**Changes:**
|
||||
- Added `on_window_event` listener to detect window close events
|
||||
- On `CloseRequested` event:
|
||||
- Spawns async task to clean up
|
||||
- Removes service from in-memory `integration_webviews` map
|
||||
- Deletes entry from `persistent_webviews` database table
|
||||
- Logs all cleanup operations
|
||||
- Properly handles Arc cloning to avoid lifetime issues in spawned task
|
||||
|
||||
### 5. Removed Auto-Close Behavior
|
||||
|
||||
**Files Modified:**
|
||||
- `src-tauri/src/commands/integrations.rs:606-618`
|
||||
|
||||
**Changes:**
|
||||
- Removed automatic window closing in `extract_cookies_from_webview`
|
||||
- Windows now stay open after cookie extraction
|
||||
- Updated success message to inform user that window persists for future use
|
||||
|
||||
### 6. Frontend UI Update - Removed "Complete Login" Button
|
||||
|
||||
**Files Modified:**
|
||||
- `src/pages/Settings/Integrations.tsx:371-409` - Updated webview authentication UI
|
||||
- `src/pages/Settings/Integrations.tsx:140-165` - Simplified `handleConnectWebview`
|
||||
- `src/pages/Settings/Integrations.tsx:167-200` - Removed `handleCompleteWebviewLogin` function
|
||||
- `src/pages/Settings/Integrations.tsx:16-26` - Removed unused `extractCookiesFromWebviewCmd` import
|
||||
- `src/pages/Settings/Integrations.tsx:670-677` - Updated authentication method comparison text
|
||||
|
||||
**Changes:**
|
||||
- Removed "Complete Login" button that tried to extract cookies via JavaScript
|
||||
- Updated UI to show success message when browser opens, explaining persistence
|
||||
- Removed confusing two-step flow (open browser → complete login)
|
||||
- New flow: click "Open Browser" → log in → leave window open (that's it!)
|
||||
- Updated description text to explain persistent window behavior
|
||||
- Mark integration as "connected" immediately when browser opens
|
||||
- Removed unused function and import for cookie extraction
|
||||
|
||||
### 7. Unused Import Cleanup
|
||||
|
||||
**Files Modified:**
|
||||
- `src-tauri/src/integrations/webview_auth.rs:2`
|
||||
- `src-tauri/src/lib.rs:13` - Added `use tauri::Manager;`
|
||||
|
||||
**Changes:**
|
||||
- Removed unused `Listener` import from webview_auth.rs
|
||||
- Added `Manager` trait import to lib.rs for `.state()` method
|
||||
|
||||
## Testing Needed
|
||||
|
||||
### Manual Testing
|
||||
|
||||
1. **Initial Browser Window Creation**
|
||||
- [ ] Navigate to Settings > Integrations
|
||||
- [ ] Configure a Confluence integration with base URL
|
||||
- [ ] Click "Open Browser" button
|
||||
- [ ] Verify browser window opens with Confluence login page
|
||||
- [ ] Complete login in the browser window
|
||||
- [ ] Verify window stays open after login
|
||||
|
||||
2. **Window Persistence Across Restarts**
|
||||
- [ ] With Confluence browser window open, close the main application
|
||||
- [ ] Relaunch the application
|
||||
- [ ] Verify Confluence browser window is automatically restored
|
||||
- [ ] Verify you are still logged in (cookies maintained)
|
||||
- [ ] Navigate to different pages in Confluence to verify session works
|
||||
|
||||
3. **Manual Window Close**
|
||||
- [ ] With browser window open, manually close it (X button)
|
||||
- [ ] Restart the application
|
||||
- [ ] Verify browser window does NOT reopen (removed from persistence)
|
||||
|
||||
4. **Database Verification**
|
||||
- [ ] Open database: `sqlite3 ~/Library/Application\ Support/trcaa/data.db`
|
||||
- [ ] Run: `SELECT * FROM persistent_webviews;`
|
||||
- [ ] Verify entry exists when window is open
|
||||
- [ ] Close window and verify entry is removed
|
||||
|
||||
5. **Multiple Integration Windows**
|
||||
- [ ] Open browser window for Confluence
|
||||
- [ ] Open browser window for Azure DevOps
|
||||
- [ ] Restart application
|
||||
- [ ] Verify both windows are restored
|
||||
- [ ] Close one window
|
||||
- [ ] Verify only one is removed from database
|
||||
- [ ] Restart and verify remaining window still restores
|
||||
|
||||
6. **Cookie Persistence (No HttpOnly Extraction Needed)**
|
||||
- [ ] Log into Confluence browser window
|
||||
- [ ] Close main application
|
||||
- [ ] Relaunch application
|
||||
- [ ] Navigate to a Confluence page that requires authentication
|
||||
- [ ] Verify you are still logged in (cookies maintained by browser)
|
||||
|
||||
### Automated Testing
|
||||
|
||||
```bash
|
||||
# Type checking
|
||||
npx tsc --noEmit
|
||||
|
||||
# Rust compilation
|
||||
cargo check --manifest-path src-tauri/Cargo.toml
|
||||
|
||||
# Rust tests
|
||||
cargo test --manifest-path src-tauri/Cargo.toml
|
||||
|
||||
# Rust linting
|
||||
cargo clippy --manifest-path src-tauri/Cargo.toml -- -D warnings
|
||||
```
|
||||
|
||||
### Edge Cases to Test
|
||||
|
||||
- Application crash while browser window is open (verify restoration on next launch)
|
||||
- Database corruption (verify graceful handling of restore failures)
|
||||
- Window already exists when trying to create duplicate (verify existing window is focused)
|
||||
- Network connectivity lost during window restoration (verify error handling)
|
||||
- Multiple rapid window open/close cycles (verify database consistency)
|
||||
|
||||
## Architecture Notes
|
||||
|
||||
### Design Decision: Persistent Windows vs Cookie Extraction
|
||||
|
||||
**Problem:** HttpOnly cookies cannot be accessed via JavaScript (`document.cookie`), which broke the original cookie extraction approach for Confluence and other services.
|
||||
|
||||
**Solution:** Instead of extracting cookies, keep the browser window alive across app restarts:
|
||||
- Browser maintains its own internal cookie store (includes HttpOnly cookies)
|
||||
- Cookies are automatically sent with all HTTP requests from the browser
|
||||
- No need for JavaScript extraction or manual token management
|
||||
- Matches Playwright's approach of persistent browser contexts
|
||||
|
||||
### Lifecycle Flow
|
||||
|
||||
1. **Window Creation:** User clicks "Open Browser" → `authenticate_with_webview` creates window → State saved to database
|
||||
2. **App Running:** Window stays open, user can browse freely, cookies maintained by browser
|
||||
3. **Window Close:** User closes window → Event handler removes from database and memory
|
||||
4. **App Restart:** `restore_persistent_webviews` queries database → Recreates all windows → Windows resume with original cookies
|
||||
|
||||
### Database Schema
|
||||
|
||||
```sql
|
||||
CREATE TABLE persistent_webviews (
|
||||
id TEXT PRIMARY KEY,
|
||||
service TEXT NOT NULL CHECK(service IN ('confluence','servicenow','azuredevops')),
|
||||
webview_label TEXT NOT NULL,
|
||||
base_url TEXT NOT NULL,
|
||||
last_active TEXT NOT NULL DEFAULT (datetime('now')),
|
||||
window_x INTEGER,
|
||||
window_y INTEGER,
|
||||
window_width INTEGER,
|
||||
window_height INTEGER,
|
||||
UNIQUE(service)
|
||||
);
|
||||
```
|
||||
|
||||
### Future Enhancements
|
||||
|
||||
- [ ] Save and restore window position/size (columns already exist in schema)
|
||||
- [ ] Add "last_active" timestamp updates on window focus events
|
||||
- [ ] Implement "Close All Windows" command for cleanup
|
||||
- [ ] Add visual indicator in main UI showing which integrations have active browser windows
|
||||
- [ ] Implement session timeout logic (close windows after X days of inactivity)
|
||||
|
||||
## Related Files
|
||||
|
||||
- `src-tauri/src/db/migrations.rs` - Database schema migration
|
||||
- `src-tauri/src/commands/integrations.rs` - Webview persistence and restoration logic
|
||||
- `src-tauri/src/integrations/webview_auth.rs` - Browser window creation
|
||||
- `src-tauri/src/lib.rs` - App startup hook for restoration
|
||||
- `src-tauri/src/state.rs` - AppState structure with `integration_webviews` map
|
||||
|
||||
## Security Considerations
|
||||
|
||||
- Cookie storage remains in the browser's internal secure store (not extracted to database)
|
||||
- Database only stores window metadata (service, label, URL)
|
||||
- No credential information persisted beyond what the browser already maintains
|
||||
- Audit log still tracks all integration API calls separately
|
||||
|
||||
## Migration Path
|
||||
|
||||
Users upgrading to this version will:
|
||||
1. See new database migration `013_create_persistent_webviews` applied automatically
|
||||
2. Existing integrations continue to work (migration is additive only)
|
||||
3. First time opening a browser window will persist it for future sessions
|
||||
4. No manual action required from users
|
||||
@ -1,178 +0,0 @@
|
||||
# Ticket Summary - AI Disclaimer Modal
|
||||
|
||||
## Description
|
||||
|
||||
Added a mandatory AI disclaimer warning that users must accept before creating new issues. This ensures users understand the risks and limitations of AI-assisted triage and accept responsibility for any actions taken based on AI recommendations.
|
||||
|
||||
## Acceptance Criteria
|
||||
|
||||
- [x] Disclaimer appears automatically on first visit to New Issue page
|
||||
- [x] Modal blocks interaction with page until user accepts or cancels
|
||||
- [x] Acceptance is persisted across sessions
|
||||
- [x] Clear, professional warning about AI limitations
|
||||
- [x] Covers key risks: mistakes, hallucinations, incorrect commands
|
||||
- [x] Emphasizes user responsibility and accountability
|
||||
- [x] Includes best practices for safe AI usage
|
||||
- [x] Cancel button returns user to dashboard
|
||||
- [x] Modal re-appears if user tries to create issue without accepting
|
||||
|
||||
## Work Implemented
|
||||
|
||||
### Frontend Changes
|
||||
**File:** `src/pages/NewIssue/index.tsx`
|
||||
|
||||
1. **Modal Component:**
|
||||
- Full-screen overlay with backdrop
|
||||
- Centered modal dialog (max-width 2xl)
|
||||
- Scrollable content area for long disclaimer text
|
||||
- Professional styling with proper contrast
|
||||
|
||||
2. **Disclaimer Content:**
|
||||
- **Header:** "AI-Assisted Triage Disclaimer"
|
||||
- **Warning Section** (red background):
|
||||
- AI can provide incorrect, incomplete, or outdated information
|
||||
- AI can hallucinate false information
|
||||
- Recommendations may not apply to specific environments
|
||||
- Commands may have unintended consequences (data loss, downtime, security issues)
|
||||
- **Responsibility Section** (yellow background):
|
||||
- User is solely responsible for all actions taken
|
||||
- Must verify AI suggestions against documentation
|
||||
- Must test in non-production first
|
||||
- Must understand commands before executing
|
||||
- Must have backups and rollback plans
|
||||
- **Best Practices:**
|
||||
- Treat AI as starting point, not definitive answer
|
||||
- Consult senior engineers for critical systems
|
||||
- Review AI content for accuracy
|
||||
- Maintain change control processes
|
||||
- Document decisions
|
||||
- **Legal acknowledgment**
|
||||
|
||||
3. **State Management:**
|
||||
- `showDisclaimer` state controls modal visibility
|
||||
- `useEffect` hook checks localStorage on page load
|
||||
- Acceptance stored as `tftsr-ai-disclaimer-accepted` in localStorage
|
||||
- Persists across sessions and app restarts
|
||||
|
||||
4. **User Flow:**
|
||||
- User visits New Issue → Modal appears
|
||||
- User clicks "I Understand and Accept" → Modal closes, localStorage updated
|
||||
- User clicks "Cancel" → Navigates back to dashboard
|
||||
- User tries to create issue without accepting → Modal re-appears
|
||||
- After acceptance, modal never shows again (unless localStorage cleared)
|
||||
|
||||
### Technical Details
|
||||
|
||||
**Storage:** `localStorage.getItem("tftsr-ai-disclaimer-accepted")`
|
||||
- Key: `tftsr-ai-disclaimer-accepted`
|
||||
- Value: `"true"` when accepted
|
||||
- Scope: Per-browser, persists across sessions
|
||||
|
||||
**Validation Points:**
|
||||
1. Page load - Shows modal if not accepted
|
||||
2. "Start Triage" button click - Re-checks acceptance before proceeding
|
||||
|
||||
**Styling:**
|
||||
- Dark overlay: `bg-black/50`
|
||||
- Modal: `bg-background` with border and shadow
|
||||
- Red warning box: `bg-destructive/10 border-destructive/20`
|
||||
- Yellow responsibility box: `bg-yellow-500/10 border-yellow-500/20`
|
||||
- Scrollable content: `max-h-[60vh] overflow-y-auto`
|
||||
|
||||
## Testing Needed
|
||||
|
||||
### Manual Testing
|
||||
|
||||
1. **First Visit Flow:**
|
||||
- [ ] Navigate to New Issue page
|
||||
- [ ] Verify modal appears automatically
|
||||
- [ ] Verify page content is blocked/dimmed
|
||||
- [ ] Verify modal is scrollable
|
||||
- [ ] Verify all sections are visible and readable
|
||||
|
||||
2. **Acceptance Flow:**
|
||||
- [ ] Click "I Understand and Accept"
|
||||
- [ ] Verify modal closes
|
||||
- [ ] Verify can now create issues
|
||||
- [ ] Refresh page
|
||||
- [ ] Verify modal does NOT re-appear
|
||||
|
||||
3. **Cancel Flow:**
|
||||
- [ ] Clear localStorage: `localStorage.removeItem("tftsr-ai-disclaimer-accepted")`
|
||||
- [ ] Go to New Issue page
|
||||
- [ ] Click "Cancel" button
|
||||
- [ ] Verify redirected to dashboard
|
||||
- [ ] Go back to New Issue page
|
||||
- [ ] Verify modal appears again
|
||||
|
||||
4. **Rejection Flow:**
|
||||
- [ ] Clear localStorage
|
||||
- [ ] Go to New Issue page
|
||||
- [ ] Close modal without accepting (if possible)
|
||||
- [ ] Fill in issue details
|
||||
- [ ] Click "Start Triage"
|
||||
- [ ] Verify modal re-appears before issue creation
|
||||
|
||||
5. **Visual Testing:**
|
||||
- [ ] Test in light theme - verify text contrast
|
||||
- [ ] Test in dark theme - verify text contrast
|
||||
- [ ] Test on mobile viewport - verify modal fits
|
||||
- [ ] Test with very long issue title - verify modal remains on top
|
||||
- [ ] Verify warning colors are distinct (red vs yellow boxes)
|
||||
|
||||
6. **Accessibility:**
|
||||
- [ ] Verify modal can be navigated with keyboard
|
||||
- [ ] Verify "Accept" button can be focused and activated with Enter
|
||||
- [ ] Verify "Cancel" button can be focused
|
||||
- [ ] Verify modal traps focus (Tab doesn't leave modal)
|
||||
- [ ] Verify text is readable at different zoom levels
|
||||
|
||||
### Browser Testing
|
||||
|
||||
Test localStorage persistence across:
|
||||
- [ ] Chrome/Edge
|
||||
- [ ] Firefox
|
||||
- [ ] Safari
|
||||
- [ ] Browser restart
|
||||
- [ ] Tab close and reopen
|
||||
|
||||
### Edge Cases
|
||||
|
||||
- [ ] Multiple browser tabs - verify acceptance in one tab reflects in others on reload
|
||||
- [ ] Incognito/private browsing - verify modal appears every session
|
||||
- [ ] localStorage quota exceeded - verify graceful degradation
|
||||
- [ ] Disabled JavaScript - app won't work, but no crashes
|
||||
- [ ] Fast double-click on Accept - verify no duplicate localStorage writes
|
||||
|
||||
## Security Considerations
|
||||
|
||||
**Disclaimer Bypass Risk:**
|
||||
Users could theoretically bypass the disclaimer by:
|
||||
1. Manually setting localStorage: `localStorage.setItem("tftsr-ai-disclaimer-accepted", "true")`
|
||||
2. Using browser dev tools
|
||||
|
||||
**Mitigation:** This is acceptable because:
|
||||
- The disclaimer is for liability protection, not security
|
||||
- Users who bypass it are technical enough to understand the risks
|
||||
- The disclaimer is shown prominently and is hard to miss accidentally
|
||||
- Acceptance is logged client-side (could be enhanced to log server-side for audit)
|
||||
|
||||
**Future Enhancement:**
|
||||
- Log acceptance event to backend with timestamp
|
||||
- Store acceptance in database tied to user session
|
||||
- Require periodic re-acceptance (e.g., every 90 days)
|
||||
- Add version tracking to re-show on disclaimer updates
|
||||
|
||||
## Legal Notes
|
||||
|
||||
This disclaimer should be reviewed by legal counsel to ensure:
|
||||
- Adequate liability protection
|
||||
- Compliance with jurisdiction-specific requirements
|
||||
- Appropriate language for organizational use
|
||||
- Clear "Use at your own risk" messaging
|
||||
|
||||
**Recommended additions (by legal):**
|
||||
- Add version number/date to disclaimer
|
||||
- Log acceptance with timestamp for audit trail
|
||||
- Consider adding "This is an experimental tool" if applicable
|
||||
- Add specific disclaimer for any regulated environments (healthcare, finance, etc.)
|
||||
@ -29,8 +29,7 @@ TFTSR uses a Tauri 2.x architecture: a Rust backend runs natively, and a React/T
|
||||
pub struct AppState {
|
||||
pub db: Arc<Mutex<rusqlite::Connection>>,
|
||||
pub settings: Arc<Mutex<AppSettings>>,
|
||||
pub app_data_dir: PathBuf, // ~/.local/share/trcaa on Linux
|
||||
pub integration_webviews: Arc<Mutex<HashMap<String, String>>>,
|
||||
pub app_data_dir: PathBuf, // ~/.local/share/tftsr on Linux
|
||||
}
|
||||
```
|
||||
|
||||
@ -47,10 +46,11 @@ All command handlers receive `State<'_, AppState>` as a Tauri-injected parameter
|
||||
| `commands/analysis.rs` | Log file upload, PII detection, redaction |
|
||||
| `commands/docs.rs` | RCA and post-mortem generation, document export |
|
||||
| `commands/system.rs` | Ollama management, hardware probe, settings, audit log |
|
||||
| `commands/integrations.rs` | Confluence / ServiceNow / ADO — OAuth2, WebView auth, tool calling |
|
||||
| `commands/image.rs` | Image attachment upload, list, delete, paste |
|
||||
| `commands/integrations.rs` | Confluence / ServiceNow / ADO — v0.2 stubs |
|
||||
| `ai/provider.rs` | `Provider` trait + `create_provider()` factory |
|
||||
| `pii/detector.rs` | Multi-pattern PII scanner with overlap resolution |
|
||||
| `db/migrations.rs` | Versioned schema (14 migrations tracked in `_migrations` table) |
|
||||
| `db/migrations.rs` | Versioned schema (12 migrations in `_migrations` table) |
|
||||
| `db/models.rs` | All DB types — see `IssueDetail` note below |
|
||||
| `docs/rca.rs` + `docs/postmortem.rs` | Markdown template builders |
|
||||
| `audit/log.rs` | `write_audit_event()` — called before every external send |
|
||||
@ -75,6 +75,7 @@ src-tauri/src/
|
||||
│ ├── analysis.rs
|
||||
│ ├── docs.rs
|
||||
│ ├── system.rs
|
||||
│ ├── image.rs
|
||||
│ └── integrations.rs
|
||||
├── pii/
|
||||
│ ├── patterns.rs
|
||||
@ -179,30 +180,22 @@ Use `detail.issue.title`, **not** `detail.title`.
|
||||
|
||||
```
|
||||
1. Initialize tracing (RUST_LOG controls level)
|
||||
2. Determine data directory (state::get_app_data_dir() or TFTSR_DATA_DIR)
|
||||
3. Auto-generate or load .dbkey / .enckey (mode 0600) — see ADR-005
|
||||
4. Open / create SQLCipher encrypted database
|
||||
- If plain SQLite detected (debug→release upgrade): auto-migrate + backup
|
||||
5. Run DB migrations (14 schema versions)
|
||||
6. Create AppState (db + settings + app_data_dir + integration_webviews)
|
||||
7. Register Tauri plugins (stronghold, dialog, fs, shell, http)
|
||||
8. Register all IPC command handlers via generate_handler![]
|
||||
9. Start WebView with React app
|
||||
2. Determine data directory (~/.local/share/tftsr or TFTSR_DATA_DIR)
|
||||
3. Open / create SQLite database (run migrations)
|
||||
4. Create AppState (db + settings + app_data_dir)
|
||||
5. Register Tauri plugins (stronghold, dialog, fs, shell, http, cli, updater)
|
||||
6. Register all 39 IPC command handlers
|
||||
7. Start WebView with React app
|
||||
```
|
||||
|
||||
## Architecture Documentation
|
||||
## Image Attachments
|
||||
|
||||
Full architecture documentation with C4 diagrams, data flow diagrams, and Architecture Decision Records (ADRs) is available in [`docs/architecture/`](../architecture/README.md):
|
||||
The app supports uploading and managing image files (screenshots, diagrams) as attachments:
|
||||
|
||||
| Document | Contents |
|
||||
|----------|----------|
|
||||
| [Architecture Overview](../architecture/README.md) | C4 diagrams, data flows, security model |
|
||||
| [ADR-001](../architecture/adrs/ADR-001-tauri-desktop-framework.md) | Why Tauri over Electron |
|
||||
| [ADR-002](../architecture/adrs/ADR-002-sqlcipher-encrypted-database.md) | SQLCipher encryption choices |
|
||||
| [ADR-003](../architecture/adrs/ADR-003-provider-trait-pattern.md) | AI provider trait design |
|
||||
| [ADR-004](../architecture/adrs/ADR-004-pii-regex-aho-corasick.md) | PII detection implementation |
|
||||
| [ADR-005](../architecture/adrs/ADR-005-auto-generate-encryption-keys.md) | Key auto-generation design |
|
||||
| [ADR-006](../architecture/adrs/ADR-006-zustand-state-management.md) | Frontend state management |
|
||||
1. **Upload** via `upload_image_attachmentCmd()` or `upload_paste_imageCmd()` (clipboard paste)
|
||||
2. **PII detection** runs automatically on upload
|
||||
3. **User approval** required before image is stored
|
||||
4. **Database storage** in `image_attachments` table with SHA-256 hash
|
||||
|
||||
## Data Flow
|
||||
|
||||
|
||||
@ -2,7 +2,7 @@
|
||||
|
||||
## Overview
|
||||
|
||||
TFTSR uses **SQLite** via `rusqlite` with the `bundled-sqlcipher` feature for AES-256 encryption in production. 11 versioned migrations are tracked in the `_migrations` table.
|
||||
TFTSR uses **SQLite** via `rusqlite` with the `bundled-sqlcipher` feature for AES-256 encryption in production. 12 versioned migrations are tracked in the `_migrations` table.
|
||||
|
||||
**DB file location:** `{app_data_dir}/tftsr.db`
|
||||
|
||||
@ -211,6 +211,29 @@ CREATE TABLE integration_config (
|
||||
);
|
||||
```
|
||||
|
||||
### 012 — image_attachments (v0.2.7+)
|
||||
|
||||
```sql
|
||||
CREATE TABLE image_attachments (
|
||||
id TEXT PRIMARY KEY,
|
||||
issue_id TEXT NOT NULL REFERENCES issues(id) ON DELETE CASCADE,
|
||||
file_name TEXT NOT NULL,
|
||||
file_path TEXT NOT NULL DEFAULT '',
|
||||
file_size INTEGER NOT NULL DEFAULT 0,
|
||||
mime_type TEXT NOT NULL DEFAULT 'image/png',
|
||||
upload_hash TEXT NOT NULL DEFAULT '',
|
||||
uploaded_at TEXT NOT NULL DEFAULT (datetime('now')),
|
||||
pii_warning_acknowledged INTEGER NOT NULL DEFAULT 1,
|
||||
is_paste INTEGER NOT NULL DEFAULT 0
|
||||
);
|
||||
```
|
||||
|
||||
**Features:**
|
||||
- Image file metadata stored in database
|
||||
- `upload_hash`: SHA-256 hash of file content (for deduplication)
|
||||
- `pii_warning_acknowledged`: User confirmation that PII may be present
|
||||
- `is_paste`: Flag for screenshots copied from clipboard
|
||||
|
||||
**Encryption:**
|
||||
- OAuth2 tokens encrypted with AES-256-GCM
|
||||
- Key derived from `TFTSR_DB_KEY` environment variable
|
||||
|
||||
@ -32,12 +32,14 @@
|
||||
- **Ollama Management** — Hardware detection, model recommendations, in-app model management
|
||||
- **Audit Trail** — Every external data send logged with SHA-256 hash
|
||||
- **Domain-Specific Prompts** — 8 IT domains: Linux, Windows, Network, Kubernetes, Databases, Virtualization, Hardware, Observability
|
||||
- **Image Attachments** — Upload and manage image files with PII detection and mandatory user approval
|
||||
|
||||
## Releases
|
||||
|
||||
| Version | Status | Highlights |
|
||||
|---------|--------|-----------|
|
||||
| v0.2.6 | 🚀 Latest | Custom REST AI gateway support, OAuth2 shell permissions, user ID tracking |
|
||||
| v0.2.5 | Released | Image attachments with PII detection and approval workflow |
|
||||
| v0.2.3 | Released | Confluence/ServiceNow/ADO REST API clients (19 TDD tests) |
|
||||
| v0.1.1 | Released | Core application with PII detection, RCA generation |
|
||||
|
||||
|
||||
@ -99,6 +99,34 @@ Rewrites file content with approved redactions. Records SHA-256 in audit log. Re
|
||||
|
||||
---
|
||||
|
||||
## Image Attachment Commands
|
||||
|
||||
### `upload_image_attachment`
|
||||
```typescript
|
||||
uploadImageAttachmentCmd(issueId: string, filePath: string, piiWarningAcknowledged: boolean) → ImageAttachment
|
||||
```
|
||||
Uploads an image file. Computes SHA-256, stores metadata in DB. Returns `ImageAttachment` record.
|
||||
|
||||
### `list_image_attachments`
|
||||
```typescript
|
||||
listImageAttachmentsCmd(issueId: string) → ImageAttachment[]
|
||||
```
|
||||
Lists all image attachments for an issue.
|
||||
|
||||
### `delete_image_attachment`
|
||||
```typescript
|
||||
deleteImageAttachmentCmd(imageId: string) → void
|
||||
```
|
||||
Deletes an image attachment from disk and database.
|
||||
|
||||
### `upload_paste_image`
|
||||
```typescript
|
||||
uploadPasteImageCmd(issueId: string, base64Data: string, fileName: string, piiWarningAcknowledged: boolean) → ImageAttachment
|
||||
```
|
||||
Uploads an image from clipboard paste (base64). Returns `ImageAttachment` record.
|
||||
|
||||
---
|
||||
|
||||
## AI Commands
|
||||
|
||||
### `analyze_logs`
|
||||
|
||||
96
src-tauri/Cargo.lock
generated
96
src-tauri/Cargo.lock
generated
@ -263,12 +263,6 @@ dependencies = [
|
||||
"constant_time_eq 0.4.2",
|
||||
]
|
||||
|
||||
[[package]]
|
||||
name = "block"
|
||||
version = "0.1.6"
|
||||
source = "registry+https://github.com/rust-lang/crates.io-index"
|
||||
checksum = "0d8c1fef690941d3e7788d328517591fecc684c084084702d6ff1641e993699a"
|
||||
|
||||
[[package]]
|
||||
name = "block-buffer"
|
||||
version = "0.10.4"
|
||||
@ -526,36 +520,6 @@ dependencies = [
|
||||
"zeroize",
|
||||
]
|
||||
|
||||
[[package]]
|
||||
name = "cocoa"
|
||||
version = "0.25.0"
|
||||
source = "registry+https://github.com/rust-lang/crates.io-index"
|
||||
checksum = "f6140449f97a6e97f9511815c5632d84c8aacf8ac271ad77c559218161a1373c"
|
||||
dependencies = [
|
||||
"bitflags 1.3.2",
|
||||
"block",
|
||||
"cocoa-foundation",
|
||||
"core-foundation 0.9.4",
|
||||
"core-graphics 0.23.2",
|
||||
"foreign-types 0.5.0",
|
||||
"libc",
|
||||
"objc",
|
||||
]
|
||||
|
||||
[[package]]
|
||||
name = "cocoa-foundation"
|
||||
version = "0.1.2"
|
||||
source = "registry+https://github.com/rust-lang/crates.io-index"
|
||||
checksum = "8c6234cbb2e4c785b456c0644748b1ac416dd045799740356f8363dfe00c93f7"
|
||||
dependencies = [
|
||||
"bitflags 1.3.2",
|
||||
"block",
|
||||
"core-foundation 0.9.4",
|
||||
"core-graphics-types 0.1.3",
|
||||
"libc",
|
||||
"objc",
|
||||
]
|
||||
|
||||
[[package]]
|
||||
name = "color_quant"
|
||||
version = "1.1.0"
|
||||
@ -684,19 +648,6 @@ version = "0.8.7"
|
||||
source = "registry+https://github.com/rust-lang/crates.io-index"
|
||||
checksum = "773648b94d0e5d620f64f280777445740e61fe701025087ec8b57f45c791888b"
|
||||
|
||||
[[package]]
|
||||
name = "core-graphics"
|
||||
version = "0.23.2"
|
||||
source = "registry+https://github.com/rust-lang/crates.io-index"
|
||||
checksum = "c07782be35f9e1140080c6b96f0d44b739e2278479f64e02fdab4e32dfd8b081"
|
||||
dependencies = [
|
||||
"bitflags 1.3.2",
|
||||
"core-foundation 0.9.4",
|
||||
"core-graphics-types 0.1.3",
|
||||
"foreign-types 0.5.0",
|
||||
"libc",
|
||||
]
|
||||
|
||||
[[package]]
|
||||
name = "core-graphics"
|
||||
version = "0.25.0"
|
||||
@ -705,22 +656,11 @@ checksum = "064badf302c3194842cf2c5d61f56cc88e54a759313879cdf03abdd27d0c3b97"
|
||||
dependencies = [
|
||||
"bitflags 2.11.0",
|
||||
"core-foundation 0.10.1",
|
||||
"core-graphics-types 0.2.0",
|
||||
"core-graphics-types",
|
||||
"foreign-types 0.5.0",
|
||||
"libc",
|
||||
]
|
||||
|
||||
[[package]]
|
||||
name = "core-graphics-types"
|
||||
version = "0.1.3"
|
||||
source = "registry+https://github.com/rust-lang/crates.io-index"
|
||||
checksum = "45390e6114f68f718cc7a830514a96f903cccd70d02a8f6d9f643ac4ba45afaf"
|
||||
dependencies = [
|
||||
"bitflags 1.3.2",
|
||||
"core-foundation 0.9.4",
|
||||
"libc",
|
||||
]
|
||||
|
||||
[[package]]
|
||||
name = "core-graphics-types"
|
||||
version = "0.2.0"
|
||||
@ -2476,6 +2416,15 @@ dependencies = [
|
||||
"serde_core",
|
||||
]
|
||||
|
||||
[[package]]
|
||||
name = "infer"
|
||||
version = "0.15.0"
|
||||
source = "registry+https://github.com/rust-lang/crates.io-index"
|
||||
checksum = "cb33622da908807a06f9513c19b3c1ad50fab3e4137d82a78107d502075aa199"
|
||||
dependencies = [
|
||||
"cfb",
|
||||
]
|
||||
|
||||
[[package]]
|
||||
name = "infer"
|
||||
version = "0.19.0"
|
||||
@ -2892,15 +2841,6 @@ version = "0.1.1"
|
||||
source = "registry+https://github.com/rust-lang/crates.io-index"
|
||||
checksum = "c41e0c4fef86961ac6d6f8a82609f55f31b05e4fce149ac5710e439df7619ba4"
|
||||
|
||||
[[package]]
|
||||
name = "malloc_buf"
|
||||
version = "0.0.6"
|
||||
source = "registry+https://github.com/rust-lang/crates.io-index"
|
||||
checksum = "62bb907fe88d54d8d9ce32a3cceab4218ed2f6b7d35617cafe9adf84e43919cb"
|
||||
dependencies = [
|
||||
"libc",
|
||||
]
|
||||
|
||||
[[package]]
|
||||
name = "markup5ever"
|
||||
version = "0.14.1"
|
||||
@ -3216,15 +3156,6 @@ dependencies = [
|
||||
"syn 2.0.117",
|
||||
]
|
||||
|
||||
[[package]]
|
||||
name = "objc"
|
||||
version = "0.2.7"
|
||||
source = "registry+https://github.com/rust-lang/crates.io-index"
|
||||
checksum = "915b1b472bc21c53464d6c8461c9d3af805ba1ef837e1cac254428f4a77177b1"
|
||||
dependencies = [
|
||||
"malloc_buf",
|
||||
]
|
||||
|
||||
[[package]]
|
||||
name = "objc2"
|
||||
version = "0.6.4"
|
||||
@ -5330,7 +5261,7 @@ dependencies = [
|
||||
"bitflags 2.11.0",
|
||||
"block2",
|
||||
"core-foundation 0.10.1",
|
||||
"core-graphics 0.25.0",
|
||||
"core-graphics",
|
||||
"crossbeam-channel",
|
||||
"dispatch2",
|
||||
"dlopen2",
|
||||
@ -5689,7 +5620,7 @@ dependencies = [
|
||||
"glob",
|
||||
"html5ever 0.29.1",
|
||||
"http 1.4.0",
|
||||
"infer",
|
||||
"infer 0.19.0",
|
||||
"json-patch",
|
||||
"kuchikiki",
|
||||
"log",
|
||||
@ -6215,14 +6146,13 @@ dependencies = [
|
||||
"async-trait",
|
||||
"base64 0.22.1",
|
||||
"chrono",
|
||||
"cocoa",
|
||||
"dirs 5.0.1",
|
||||
"docx-rs",
|
||||
"futures",
|
||||
"hex",
|
||||
"infer 0.15.0",
|
||||
"lazy_static",
|
||||
"mockito",
|
||||
"objc",
|
||||
"printpdf",
|
||||
"rand 0.8.5",
|
||||
"regex",
|
||||
|
||||
@ -43,11 +43,7 @@ rand = "0.8"
|
||||
lazy_static = "1.4"
|
||||
warp = "0.3"
|
||||
urlencoding = "2"
|
||||
|
||||
# Platform-specific dependencies for native cookie extraction
|
||||
[target.'cfg(target_os = "macos")'.dependencies]
|
||||
cocoa = "0.25"
|
||||
objc = "0.2"
|
||||
infer = "0.15"
|
||||
|
||||
[dev-dependencies]
|
||||
tokio-test = "0.4"
|
||||
|
||||
@ -1 +1 @@
|
||||
{"default":{"identifier":"default","description":"Default capabilities for TFTSR — least-privilege","local":true,"windows":["main"],"permissions":["core:path:default","core:event:default","core:window:default","core:app:default","core:resources:default","core:menu:default","core:tray:default","dialog:allow-open","dialog:allow-save","fs:allow-read-text-file","fs:allow-write-text-file","fs:allow-read","fs:allow-write","fs:allow-mkdir","fs:allow-app-read-recursive","fs:allow-app-write-recursive","fs:allow-temp-read-recursive","fs:allow-temp-write-recursive","fs:scope-app-recursive","fs:scope-temp-recursive","shell:allow-open","http:default"]}}
|
||||
{"default":{"identifier":"default","description":"Default capabilities for TFTSR — least-privilege","local":true,"windows":["main"],"permissions":["core:path:default","core:event:default","core:window:default","core:app:default","core:resources:default","core:menu:default","core:tray:default","dialog:allow-open","dialog:allow-save","fs:allow-read-text-file","fs:allow-write-text-file","fs:allow-mkdir","fs:allow-app-read-recursive","fs:allow-app-write-recursive","fs:allow-temp-read-recursive","fs:allow-temp-write-recursive","fs:scope-app-recursive","fs:scope-temp-recursive","shell:allow-open","http:default"]}}
|
||||
@ -82,8 +82,17 @@ impl OpenAiProvider {
|
||||
let api_url = config.api_url.trim_end_matches('/');
|
||||
let url = format!("{api_url}{endpoint_path}");
|
||||
|
||||
tracing::debug!(
|
||||
url = %url,
|
||||
model = %config.model,
|
||||
max_tokens = ?config.max_tokens,
|
||||
temperature = ?config.temperature,
|
||||
"OpenAI API request"
|
||||
);
|
||||
|
||||
let model = config.model.trim_end_matches('.');
|
||||
let mut body = serde_json::json!({
|
||||
"model": config.model,
|
||||
"model": model,
|
||||
"messages": messages,
|
||||
});
|
||||
|
||||
@ -128,11 +137,23 @@ impl OpenAiProvider {
|
||||
.header("Content-Type", "application/json")
|
||||
.json(&body)
|
||||
.send()
|
||||
.await?;
|
||||
.await;
|
||||
|
||||
let resp = match resp {
|
||||
Ok(response) => response,
|
||||
Err(e) => {
|
||||
tracing::error!(url = %url, error = %e, "OpenAI API request failed");
|
||||
anyhow::bail!("OpenAI API request failed: {e}");
|
||||
}
|
||||
};
|
||||
|
||||
if !resp.status().is_success() {
|
||||
let status = resp.status();
|
||||
let text = resp.text().await?;
|
||||
let text = resp
|
||||
.text()
|
||||
.await
|
||||
.unwrap_or_else(|_| "unable to read response body".to_string());
|
||||
tracing::error!(url = %url, status = %status, response = %text, "OpenAI API error response");
|
||||
anyhow::bail!("OpenAI API error {status}: {text}");
|
||||
}
|
||||
|
||||
|
||||
@ -1,8 +1,8 @@
|
||||
use tauri::State;
|
||||
|
||||
use crate::db::models::{
|
||||
AiConversation, AiMessage, Issue, IssueDetail, IssueFilter, IssueSummary, IssueUpdate, LogFile,
|
||||
ResolutionStep,
|
||||
AiConversation, AiMessage, ImageAttachment, Issue, IssueDetail, IssueFilter, IssueSummary,
|
||||
IssueUpdate, LogFile, ResolutionStep,
|
||||
};
|
||||
use crate::state::AppState;
|
||||
|
||||
@ -100,6 +100,32 @@ pub async fn get_issue(
|
||||
.filter_map(|r| r.ok())
|
||||
.collect();
|
||||
|
||||
// Load image attachments
|
||||
let mut img_stmt = db
|
||||
.prepare(
|
||||
"SELECT id, issue_id, file_name, file_path, file_size, mime_type, upload_hash, uploaded_at, pii_warning_acknowledged, is_paste \
|
||||
FROM image_attachments WHERE issue_id = ?1 ORDER BY uploaded_at ASC",
|
||||
)
|
||||
.map_err(|e| e.to_string())?;
|
||||
let image_attachments: Vec<ImageAttachment> = img_stmt
|
||||
.query_map([&issue_id], |row| {
|
||||
Ok(ImageAttachment {
|
||||
id: row.get(0)?,
|
||||
issue_id: row.get(1)?,
|
||||
file_name: row.get(2)?,
|
||||
file_path: row.get(3)?,
|
||||
file_size: row.get(4)?,
|
||||
mime_type: row.get(5)?,
|
||||
upload_hash: row.get(6)?,
|
||||
uploaded_at: row.get(7)?,
|
||||
pii_warning_acknowledged: row.get::<_, i32>(8)? != 0,
|
||||
is_paste: row.get::<_, i32>(9)? != 0,
|
||||
})
|
||||
})
|
||||
.map_err(|e| e.to_string())?
|
||||
.filter_map(|r| r.ok())
|
||||
.collect();
|
||||
|
||||
// Load resolution steps (5-whys)
|
||||
let mut rs_stmt = db
|
||||
.prepare(
|
||||
@ -148,6 +174,7 @@ pub async fn get_issue(
|
||||
Ok(IssueDetail {
|
||||
issue,
|
||||
log_files,
|
||||
image_attachments,
|
||||
resolution_steps,
|
||||
conversations,
|
||||
})
|
||||
@ -265,6 +292,11 @@ pub async fn delete_issue(issue_id: String, state: State<'_, AppState>) -> Resul
|
||||
.map_err(|e| e.to_string())?;
|
||||
db.execute("DELETE FROM log_files WHERE issue_id = ?1", [&issue_id])
|
||||
.map_err(|e| e.to_string())?;
|
||||
db.execute(
|
||||
"DELETE FROM image_attachments WHERE issue_id = ?1",
|
||||
[&issue_id],
|
||||
)
|
||||
.map_err(|e| e.to_string())?;
|
||||
db.execute(
|
||||
"DELETE FROM resolution_steps WHERE issue_id = ?1",
|
||||
[&issue_id],
|
||||
|
||||
282
src-tauri/src/commands/image.rs
Normal file
282
src-tauri/src/commands/image.rs
Normal file
@ -0,0 +1,282 @@
|
||||
use base64::Engine;
|
||||
use sha2::Digest;
|
||||
use std::path::Path;
|
||||
use tauri::State;
|
||||
|
||||
use crate::audit::log::write_audit_event;
|
||||
use crate::db::models::{AuditEntry, ImageAttachment};
|
||||
use crate::state::AppState;
|
||||
|
||||
const MAX_IMAGE_FILE_BYTES: u64 = 10 * 1024 * 1024;
|
||||
const SUPPORTED_IMAGE_MIME_TYPES: [&str; 5] = [
|
||||
"image/png",
|
||||
"image/jpeg",
|
||||
"image/gif",
|
||||
"image/webp",
|
||||
"image/svg+xml",
|
||||
];
|
||||
|
||||
fn validate_image_file_path(file_path: &str) -> Result<std::path::PathBuf, String> {
|
||||
let path = Path::new(file_path);
|
||||
let canonical = std::fs::canonicalize(path).map_err(|_| "Unable to access selected file")?;
|
||||
let metadata = std::fs::metadata(&canonical).map_err(|_| "Unable to read file metadata")?;
|
||||
|
||||
if !metadata.is_file() {
|
||||
return Err("Selected path is not a file".to_string());
|
||||
}
|
||||
|
||||
if metadata.len() > MAX_IMAGE_FILE_BYTES {
|
||||
return Err(format!(
|
||||
"Image file exceeds maximum supported size ({} MB)",
|
||||
MAX_IMAGE_FILE_BYTES / 1024 / 1024
|
||||
));
|
||||
}
|
||||
|
||||
Ok(canonical)
|
||||
}
|
||||
|
||||
fn is_supported_image_format(mime_type: &str) -> bool {
|
||||
SUPPORTED_IMAGE_MIME_TYPES.contains(&mime_type)
|
||||
}
|
||||
|
||||
#[tauri::command]
|
||||
pub async fn upload_image_attachment(
|
||||
issue_id: String,
|
||||
file_path: String,
|
||||
state: State<'_, AppState>,
|
||||
) -> Result<ImageAttachment, String> {
|
||||
let canonical_path = validate_image_file_path(&file_path)?;
|
||||
let content =
|
||||
std::fs::read(&canonical_path).map_err(|_| "Failed to read selected image file")?;
|
||||
let content_hash = format!("{:x}", sha2::Sha256::digest(&content));
|
||||
let file_name = canonical_path
|
||||
.file_name()
|
||||
.and_then(|n| n.to_str())
|
||||
.unwrap_or("unknown")
|
||||
.to_string();
|
||||
let file_size = content.len() as i64;
|
||||
let mime_type: String = infer::get(&content)
|
||||
.map(|m| m.mime_type().to_string())
|
||||
.unwrap_or_else(|| "image/png".to_string());
|
||||
|
||||
if !is_supported_image_format(mime_type.as_str()) {
|
||||
return Err(format!(
|
||||
"Unsupported image format: {}. Supported formats: {}",
|
||||
mime_type,
|
||||
SUPPORTED_IMAGE_MIME_TYPES.join(", ")
|
||||
));
|
||||
}
|
||||
|
||||
let canonical_file_path = canonical_path.to_string_lossy().to_string();
|
||||
let attachment = ImageAttachment::new(
|
||||
issue_id.clone(),
|
||||
file_name,
|
||||
canonical_file_path,
|
||||
file_size,
|
||||
mime_type,
|
||||
content_hash.clone(),
|
||||
true,
|
||||
false,
|
||||
);
|
||||
|
||||
let db = state.db.lock().map_err(|e| e.to_string())?;
|
||||
db.execute(
|
||||
"INSERT INTO image_attachments (id, issue_id, file_name, file_path, file_size, mime_type, upload_hash, uploaded_at, pii_warning_acknowledged, is_paste) \
|
||||
VALUES (?1, ?2, ?3, ?4, ?5, ?6, ?7, ?8, ?9, ?10)",
|
||||
rusqlite::params![
|
||||
attachment.id,
|
||||
attachment.issue_id,
|
||||
attachment.file_name,
|
||||
attachment.file_path,
|
||||
attachment.file_size,
|
||||
attachment.mime_type,
|
||||
attachment.upload_hash,
|
||||
attachment.uploaded_at,
|
||||
attachment.pii_warning_acknowledged as i32,
|
||||
attachment.is_paste as i32,
|
||||
],
|
||||
)
|
||||
.map_err(|_| "Failed to store uploaded image metadata".to_string())?;
|
||||
|
||||
let entry = AuditEntry::new(
|
||||
"upload_image_attachment".to_string(),
|
||||
"image_attachment".to_string(),
|
||||
attachment.id.clone(),
|
||||
serde_json::json!({
|
||||
"issue_id": issue_id,
|
||||
"file_name": attachment.file_name,
|
||||
"is_paste": false,
|
||||
})
|
||||
.to_string(),
|
||||
);
|
||||
if let Err(err) = write_audit_event(
|
||||
&db,
|
||||
&entry.action,
|
||||
&entry.entity_type,
|
||||
&entry.entity_id,
|
||||
&entry.details,
|
||||
) {
|
||||
tracing::warn!(error = %err, "failed to write upload_image_attachment audit entry");
|
||||
}
|
||||
|
||||
Ok(attachment)
|
||||
}
|
||||
|
||||
#[tauri::command]
|
||||
pub async fn upload_paste_image(
|
||||
issue_id: String,
|
||||
base64_image: String,
|
||||
mime_type: String,
|
||||
state: State<'_, AppState>,
|
||||
) -> Result<ImageAttachment, String> {
|
||||
if !base64_image.starts_with("data:image/") {
|
||||
return Err("Invalid image data - must be a data URL".to_string());
|
||||
}
|
||||
|
||||
let data_part = base64_image
|
||||
.split(',')
|
||||
.nth(1)
|
||||
.ok_or("Invalid image data format - missing base64 content")?;
|
||||
|
||||
let decoded = base64::engine::general_purpose::STANDARD
|
||||
.decode(data_part)
|
||||
.map_err(|_| "Failed to decode base64 image data")?;
|
||||
|
||||
let content_hash = format!("{:x}", sha2::Sha256::digest(&decoded));
|
||||
let file_size = decoded.len() as i64;
|
||||
let file_name = format!("pasted-image-{}.png", uuid::Uuid::now_v7());
|
||||
|
||||
if !is_supported_image_format(mime_type.as_str()) {
|
||||
return Err(format!(
|
||||
"Unsupported image format: {}. Supported formats: {}",
|
||||
mime_type,
|
||||
SUPPORTED_IMAGE_MIME_TYPES.join(", ")
|
||||
));
|
||||
}
|
||||
|
||||
let attachment = ImageAttachment::new(
|
||||
issue_id.clone(),
|
||||
file_name.clone(),
|
||||
String::new(),
|
||||
file_size,
|
||||
mime_type,
|
||||
content_hash,
|
||||
true,
|
||||
true,
|
||||
);
|
||||
|
||||
let db = state.db.lock().map_err(|e| e.to_string())?;
|
||||
db.execute(
|
||||
"INSERT INTO image_attachments (id, issue_id, file_name, file_path, file_size, mime_type, upload_hash, uploaded_at, pii_warning_acknowledged, is_paste) \
|
||||
VALUES (?1, ?2, ?3, ?4, ?5, ?6, ?7, ?8, ?9, ?10)",
|
||||
rusqlite::params![
|
||||
attachment.id,
|
||||
attachment.issue_id,
|
||||
attachment.file_name,
|
||||
attachment.file_path,
|
||||
attachment.file_size,
|
||||
attachment.mime_type,
|
||||
attachment.upload_hash,
|
||||
attachment.uploaded_at,
|
||||
attachment.pii_warning_acknowledged as i32,
|
||||
attachment.is_paste as i32,
|
||||
],
|
||||
)
|
||||
.map_err(|_| "Failed to store pasted image metadata".to_string())?;
|
||||
|
||||
let entry = AuditEntry::new(
|
||||
"upload_paste_image".to_string(),
|
||||
"image_attachment".to_string(),
|
||||
attachment.id.clone(),
|
||||
serde_json::json!({
|
||||
"issue_id": issue_id,
|
||||
"file_name": attachment.file_name,
|
||||
"is_paste": true,
|
||||
})
|
||||
.to_string(),
|
||||
);
|
||||
if let Err(err) = write_audit_event(
|
||||
&db,
|
||||
&entry.action,
|
||||
&entry.entity_type,
|
||||
&entry.entity_id,
|
||||
&entry.details,
|
||||
) {
|
||||
tracing::warn!(error = %err, "failed to write upload_paste_image audit entry");
|
||||
}
|
||||
|
||||
Ok(attachment)
|
||||
}
|
||||
|
||||
#[tauri::command]
|
||||
pub async fn list_image_attachments(
|
||||
issue_id: String,
|
||||
state: State<'_, AppState>,
|
||||
) -> Result<Vec<ImageAttachment>, String> {
|
||||
let db = state.db.lock().map_err(|e| e.to_string())?;
|
||||
|
||||
let mut stmt = db
|
||||
.prepare(
|
||||
"SELECT id, issue_id, file_name, file_path, file_size, mime_type, upload_hash, uploaded_at, pii_warning_acknowledged, is_paste \
|
||||
FROM image_attachments WHERE issue_id = ?1 ORDER BY uploaded_at ASC",
|
||||
)
|
||||
.map_err(|e| e.to_string())?;
|
||||
|
||||
let attachments = stmt
|
||||
.query_map([&issue_id], |row| {
|
||||
Ok(ImageAttachment {
|
||||
id: row.get(0)?,
|
||||
issue_id: row.get(1)?,
|
||||
file_name: row.get(2)?,
|
||||
file_path: row.get(3)?,
|
||||
file_size: row.get(4)?,
|
||||
mime_type: row.get(5)?,
|
||||
upload_hash: row.get(6)?,
|
||||
uploaded_at: row.get(7)?,
|
||||
pii_warning_acknowledged: row.get::<_, i32>(8)? != 0,
|
||||
is_paste: row.get::<_, i32>(9)? != 0,
|
||||
})
|
||||
})
|
||||
.map_err(|e| e.to_string())?
|
||||
.filter_map(|r| r.ok())
|
||||
.collect();
|
||||
|
||||
Ok(attachments)
|
||||
}
|
||||
|
||||
#[tauri::command]
|
||||
pub async fn delete_image_attachment(
|
||||
attachment_id: String,
|
||||
state: State<'_, AppState>,
|
||||
) -> Result<(), String> {
|
||||
let db = state.db.lock().map_err(|e| e.to_string())?;
|
||||
|
||||
let affected = db
|
||||
.execute(
|
||||
"DELETE FROM image_attachments WHERE id = ?1",
|
||||
[&attachment_id],
|
||||
)
|
||||
.map_err(|e| e.to_string())?;
|
||||
|
||||
if affected == 0 {
|
||||
return Err("Image attachment not found".to_string());
|
||||
}
|
||||
|
||||
Ok(())
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
mod tests {
|
||||
use super::*;
|
||||
|
||||
#[test]
|
||||
fn test_is_supported_image_format() {
|
||||
assert!(is_supported_image_format("image/png"));
|
||||
assert!(is_supported_image_format("image/jpeg"));
|
||||
assert!(is_supported_image_format("image/gif"));
|
||||
assert!(is_supported_image_format("image/webp"));
|
||||
assert!(is_supported_image_format("image/svg+xml"));
|
||||
assert!(!is_supported_image_format("image/bmp"));
|
||||
assert!(!is_supported_image_format("text/plain"));
|
||||
}
|
||||
}
|
||||
@ -2,5 +2,6 @@ pub mod ai;
|
||||
pub mod analysis;
|
||||
pub mod db;
|
||||
pub mod docs;
|
||||
pub mod image;
|
||||
pub mod integrations;
|
||||
pub mod system;
|
||||
|
||||
@ -156,38 +156,18 @@ pub fn run_migrations(conn: &Connection) -> anyhow::Result<()> {
|
||||
ALTER TABLE audit_log ADD COLUMN entry_hash TEXT NOT NULL DEFAULT '';",
|
||||
),
|
||||
(
|
||||
"013_create_persistent_webviews",
|
||||
"CREATE TABLE IF NOT EXISTS persistent_webviews (
|
||||
"013_image_attachments",
|
||||
"CREATE TABLE IF NOT EXISTS image_attachments (
|
||||
id TEXT PRIMARY KEY,
|
||||
service TEXT NOT NULL CHECK(service IN ('confluence','servicenow','azuredevops')),
|
||||
webview_label TEXT NOT NULL,
|
||||
base_url TEXT NOT NULL,
|
||||
last_active TEXT NOT NULL DEFAULT (datetime('now')),
|
||||
window_x INTEGER,
|
||||
window_y INTEGER,
|
||||
window_width INTEGER,
|
||||
window_height INTEGER,
|
||||
UNIQUE(service)
|
||||
);",
|
||||
),
|
||||
(
|
||||
"014_create_ai_providers",
|
||||
"CREATE TABLE IF NOT EXISTS ai_providers (
|
||||
id TEXT PRIMARY KEY,
|
||||
name TEXT NOT NULL UNIQUE,
|
||||
provider_type TEXT NOT NULL,
|
||||
api_url TEXT NOT NULL,
|
||||
encrypted_api_key TEXT NOT NULL,
|
||||
model TEXT NOT NULL,
|
||||
max_tokens INTEGER,
|
||||
temperature REAL,
|
||||
custom_endpoint_path TEXT,
|
||||
custom_auth_header TEXT,
|
||||
custom_auth_prefix TEXT,
|
||||
api_format TEXT,
|
||||
user_id TEXT,
|
||||
created_at TEXT NOT NULL DEFAULT (datetime('now')),
|
||||
updated_at TEXT NOT NULL DEFAULT (datetime('now'))
|
||||
issue_id TEXT NOT NULL REFERENCES issues(id) ON DELETE CASCADE,
|
||||
file_name TEXT NOT NULL,
|
||||
file_path TEXT NOT NULL DEFAULT '',
|
||||
file_size INTEGER NOT NULL DEFAULT 0,
|
||||
mime_type TEXT NOT NULL DEFAULT 'image/png',
|
||||
upload_hash TEXT NOT NULL DEFAULT '',
|
||||
uploaded_at TEXT NOT NULL DEFAULT (datetime('now')),
|
||||
pii_warning_acknowledged INTEGER NOT NULL DEFAULT 1,
|
||||
is_paste INTEGER NOT NULL DEFAULT 0
|
||||
);",
|
||||
),
|
||||
];
|
||||
@ -227,21 +207,21 @@ mod tests {
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_create_credentials_table() {
|
||||
fn test_create_image_attachments_table() {
|
||||
let conn = setup_test_db();
|
||||
|
||||
// Verify table exists
|
||||
let count: i64 = conn
|
||||
.query_row(
|
||||
"SELECT COUNT(*) FROM sqlite_master WHERE type='table' AND name='credentials'",
|
||||
"SELECT COUNT(*) FROM sqlite_master WHERE type='table' AND name='image_attachments'",
|
||||
[],
|
||||
|r| r.get(0),
|
||||
)
|
||||
.unwrap();
|
||||
assert_eq!(count, 1);
|
||||
|
||||
// Verify columns
|
||||
let mut stmt = conn.prepare("PRAGMA table_info(credentials)").unwrap();
|
||||
let mut stmt = conn
|
||||
.prepare("PRAGMA table_info(image_attachments)")
|
||||
.unwrap();
|
||||
let columns: Vec<String> = stmt
|
||||
.query_map([], |row| row.get::<_, String>(1))
|
||||
.unwrap()
|
||||
@ -249,11 +229,15 @@ mod tests {
|
||||
.unwrap();
|
||||
|
||||
assert!(columns.contains(&"id".to_string()));
|
||||
assert!(columns.contains(&"service".to_string()));
|
||||
assert!(columns.contains(&"token_hash".to_string()));
|
||||
assert!(columns.contains(&"encrypted_token".to_string()));
|
||||
assert!(columns.contains(&"created_at".to_string()));
|
||||
assert!(columns.contains(&"expires_at".to_string()));
|
||||
assert!(columns.contains(&"issue_id".to_string()));
|
||||
assert!(columns.contains(&"file_name".to_string()));
|
||||
assert!(columns.contains(&"file_path".to_string()));
|
||||
assert!(columns.contains(&"file_size".to_string()));
|
||||
assert!(columns.contains(&"mime_type".to_string()));
|
||||
assert!(columns.contains(&"upload_hash".to_string()));
|
||||
assert!(columns.contains(&"uploaded_at".to_string()));
|
||||
assert!(columns.contains(&"pii_warning_acknowledged".to_string()));
|
||||
assert!(columns.contains(&"is_paste".to_string()));
|
||||
}
|
||||
|
||||
#[test]
|
||||
@ -424,4 +408,64 @@ mod tests {
|
||||
|
||||
assert_eq!(count, 1);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_store_and_retrieve_image_attachment() {
|
||||
let conn = setup_test_db();
|
||||
|
||||
// Create an issue first (required for foreign key)
|
||||
let now = chrono::Utc::now().format("%Y-%m-%d %H:%M:%S").to_string();
|
||||
conn.execute(
|
||||
"INSERT INTO issues (id, title, description, severity, status, category, source, created_at, updated_at, resolved_at, assigned_to, tags)
|
||||
VALUES (?1, ?2, ?3, ?4, ?5, ?6, ?7, ?8, ?9, ?10, ?11, ?12)",
|
||||
rusqlite::params![
|
||||
"test-issue-1",
|
||||
"Test Issue",
|
||||
"Test description",
|
||||
"medium",
|
||||
"open",
|
||||
"test",
|
||||
"manual",
|
||||
now.clone(),
|
||||
now.clone(),
|
||||
None::<Option<String>>,
|
||||
"",
|
||||
"[]",
|
||||
],
|
||||
)
|
||||
.unwrap();
|
||||
|
||||
// Now insert the image attachment
|
||||
conn.execute(
|
||||
"INSERT INTO image_attachments (id, issue_id, file_name, file_path, file_size, mime_type, upload_hash, uploaded_at, pii_warning_acknowledged, is_paste)
|
||||
VALUES (?1, ?2, ?3, ?4, ?5, ?6, ?7, ?8, ?9, ?10)",
|
||||
rusqlite::params![
|
||||
"test-img-1",
|
||||
"test-issue-1",
|
||||
"screenshot.png",
|
||||
"/path/to/screenshot.png",
|
||||
102400,
|
||||
"image/png",
|
||||
"abc123hash",
|
||||
now,
|
||||
1,
|
||||
0,
|
||||
],
|
||||
)
|
||||
.unwrap();
|
||||
|
||||
let (id, issue_id, file_name, mime_type, is_paste): (String, String, String, String, i32) = conn
|
||||
.query_row(
|
||||
"SELECT id, issue_id, file_name, mime_type, is_paste FROM image_attachments WHERE id = ?1",
|
||||
["test-img-1"],
|
||||
|r| Ok((r.get(0)?, r.get(1)?, r.get(2)?, r.get(3)?, r.get(4)?)),
|
||||
)
|
||||
.unwrap();
|
||||
|
||||
assert_eq!(id, "test-img-1");
|
||||
assert_eq!(issue_id, "test-issue-1");
|
||||
assert_eq!(file_name, "screenshot.png");
|
||||
assert_eq!(mime_type, "image/png");
|
||||
assert_eq!(is_paste, 0);
|
||||
}
|
||||
}
|
||||
|
||||
@ -44,6 +44,7 @@ impl Issue {
|
||||
pub struct IssueDetail {
|
||||
pub issue: Issue,
|
||||
pub log_files: Vec<LogFile>,
|
||||
pub image_attachments: Vec<ImageAttachment>,
|
||||
pub resolution_steps: Vec<ResolutionStep>,
|
||||
pub conversations: Vec<AiConversation>,
|
||||
}
|
||||
@ -392,3 +393,46 @@ impl IntegrationConfig {
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// ─── Image Attachment ────────────────────────────────────────────────────────────
|
||||
|
||||
#[derive(Debug, Clone, Serialize, Deserialize)]
|
||||
pub struct ImageAttachment {
|
||||
pub id: String,
|
||||
pub issue_id: String,
|
||||
pub file_name: String,
|
||||
pub file_path: String,
|
||||
pub file_size: i64,
|
||||
pub mime_type: String,
|
||||
pub upload_hash: String,
|
||||
pub uploaded_at: String,
|
||||
pub pii_warning_acknowledged: bool,
|
||||
pub is_paste: bool,
|
||||
}
|
||||
|
||||
impl ImageAttachment {
|
||||
#[allow(clippy::too_many_arguments)]
|
||||
pub fn new(
|
||||
issue_id: String,
|
||||
file_name: String,
|
||||
file_path: String,
|
||||
file_size: i64,
|
||||
mime_type: String,
|
||||
upload_hash: String,
|
||||
pii_warning_acknowledged: bool,
|
||||
is_paste: bool,
|
||||
) -> Self {
|
||||
ImageAttachment {
|
||||
id: Uuid::now_v7().to_string(),
|
||||
issue_id,
|
||||
file_name,
|
||||
file_path,
|
||||
file_size,
|
||||
mime_type,
|
||||
upload_hash,
|
||||
uploaded_at: chrono::Utc::now().format("%Y-%m-%d %H:%M:%S").to_string(),
|
||||
pii_warning_acknowledged,
|
||||
is_paste,
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@ -177,6 +177,7 @@ mod tests {
|
||||
tags: "[]".to_string(),
|
||||
},
|
||||
log_files: vec![],
|
||||
image_attachments: vec![],
|
||||
resolution_steps: vec![ResolutionStep {
|
||||
id: "rs-pm-1".to_string(),
|
||||
issue_id: "pm-456".to_string(),
|
||||
|
||||
@ -172,6 +172,7 @@ mod tests {
|
||||
uploaded_at: "2025-01-15 10:30:00".to_string(),
|
||||
redacted: false,
|
||||
}],
|
||||
image_attachments: vec![],
|
||||
resolution_steps: vec![
|
||||
ResolutionStep {
|
||||
id: "rs-1".to_string(),
|
||||
|
||||
@ -503,25 +503,31 @@ mod tests {
|
||||
|
||||
#[test]
|
||||
fn test_encrypt_decrypt_roundtrip() {
|
||||
// Use a deterministic key derived from the test function name
|
||||
// This avoids env var conflicts with parallel tests
|
||||
let test_key = "test-key-encrypt-decrypt-roundtrip-12345";
|
||||
let key_material = derive_aes_key_from_str(test_key).unwrap();
|
||||
|
||||
let original = "my-secret-token-12345";
|
||||
let encrypted = encrypt_token(original).unwrap();
|
||||
let decrypted = decrypt_token(&encrypted).unwrap();
|
||||
let encrypted = encrypt_token_with_key(original, &key_material).unwrap();
|
||||
let decrypted = decrypt_token_with_key(&encrypted, &key_material).unwrap();
|
||||
assert_eq!(original, decrypted);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_encrypt_produces_different_output_each_time() {
|
||||
// Ensure env var is not set from other tests
|
||||
std::env::remove_var("TFTSR_ENCRYPTION_KEY");
|
||||
// Use a deterministic key derived from the test function name
|
||||
let test_key = "test-key-encrypt-different-67890";
|
||||
let key_material = derive_aes_key_from_str(test_key).unwrap();
|
||||
|
||||
let token = "same-token";
|
||||
let enc1 = encrypt_token(token).unwrap();
|
||||
let enc2 = encrypt_token(token).unwrap();
|
||||
let enc1 = encrypt_token_with_key(token, &key_material).unwrap();
|
||||
let enc2 = encrypt_token_with_key(token, &key_material).unwrap();
|
||||
// Different nonces mean different ciphertext
|
||||
assert_ne!(enc1, enc2);
|
||||
// But both decrypt to the same value
|
||||
assert_eq!(decrypt_token(&enc1).unwrap(), token);
|
||||
assert_eq!(decrypt_token(&enc2).unwrap(), token);
|
||||
assert_eq!(decrypt_token_with_key(&enc1, &key_material).unwrap(), token);
|
||||
assert_eq!(decrypt_token_with_key(&enc2, &key_material).unwrap(), token);
|
||||
}
|
||||
|
||||
#[test]
|
||||
@ -629,4 +635,77 @@ mod tests {
|
||||
assert_eq!(k1, k2);
|
||||
std::env::remove_var("TFTSR_ENCRYPTION_KEY");
|
||||
}
|
||||
|
||||
// Test helper functions that accept key directly (bypass env var)
|
||||
#[cfg(test)]
|
||||
fn derive_aes_key_from_str(key: &str) -> Result<[u8; 32], String> {
|
||||
let digest = sha2::Sha256::digest(key.as_bytes());
|
||||
let mut key_bytes = [0u8; 32];
|
||||
key_bytes.copy_from_slice(&digest);
|
||||
Ok(key_bytes)
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
fn encrypt_token_with_key(token: &str, key_bytes: &[u8; 32]) -> Result<String, String> {
|
||||
use aes_gcm::{
|
||||
aead::{Aead, KeyInit},
|
||||
Aes256Gcm, Nonce,
|
||||
};
|
||||
use rand::{thread_rng, RngCore};
|
||||
|
||||
let cipher = Aes256Gcm::new_from_slice(key_bytes)
|
||||
.map_err(|e| format!("Failed to create cipher: {e}"))?;
|
||||
|
||||
// Generate random nonce
|
||||
let mut nonce_bytes = [0u8; 12];
|
||||
thread_rng().fill_bytes(&mut nonce_bytes);
|
||||
let nonce = Nonce::from_slice(&nonce_bytes);
|
||||
|
||||
// Encrypt
|
||||
let ciphertext = cipher
|
||||
.encrypt(nonce, token.as_bytes())
|
||||
.map_err(|e| format!("Encryption failed: {e}"))?;
|
||||
|
||||
// Prepend nonce to ciphertext
|
||||
let mut result = nonce_bytes.to_vec();
|
||||
result.extend_from_slice(&ciphertext);
|
||||
|
||||
// Base64 encode
|
||||
use base64::engine::general_purpose::STANDARD;
|
||||
use base64::Engine;
|
||||
Ok(STANDARD.encode(&result))
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
fn decrypt_token_with_key(encrypted: &str, key_bytes: &[u8; 32]) -> Result<String, String> {
|
||||
use aes_gcm::{
|
||||
aead::{Aead, KeyInit},
|
||||
Aes256Gcm, Nonce,
|
||||
};
|
||||
|
||||
// Base64 decode
|
||||
use base64::engine::general_purpose::STANDARD;
|
||||
use base64::Engine;
|
||||
let data = STANDARD
|
||||
.decode(encrypted)
|
||||
.map_err(|e| format!("Base64 decode failed: {e}"))?;
|
||||
|
||||
if data.len() < 12 {
|
||||
return Err("Invalid encrypted data: too short".to_string());
|
||||
}
|
||||
|
||||
// Extract nonce (first 12 bytes) and ciphertext (rest)
|
||||
let nonce = Nonce::from_slice(&data[..12]);
|
||||
let ciphertext = &data[12..];
|
||||
|
||||
let cipher = Aes256Gcm::new_from_slice(key_bytes)
|
||||
.map_err(|e| format!("Failed to create cipher: {e}"))?;
|
||||
|
||||
// Decrypt
|
||||
let plaintext = cipher
|
||||
.decrypt(nonce, ciphertext)
|
||||
.map_err(|e| format!("Decryption failed: {e}"))?;
|
||||
|
||||
String::from_utf8(plaintext).map_err(|e| format!("Invalid UTF-8: {e}"))
|
||||
}
|
||||
}
|
||||
|
||||
@ -11,7 +11,6 @@ pub mod state;
|
||||
use sha2::{Digest, Sha256};
|
||||
use state::AppState;
|
||||
use std::sync::{Arc, Mutex};
|
||||
use tauri::Manager;
|
||||
|
||||
#[cfg_attr(mobile, tauri::mobile_entry_point)]
|
||||
pub fn run() {
|
||||
@ -26,7 +25,7 @@ pub fn run() {
|
||||
tracing::info!("Starting Troubleshooting and RCA Assistant application");
|
||||
|
||||
// Determine data directory
|
||||
let data_dir = state::get_app_data_dir().expect("Failed to determine app data directory");
|
||||
let data_dir = dirs_data_dir();
|
||||
|
||||
// Initialize database
|
||||
let conn = db::connection::init_db(&data_dir).expect("Failed to initialize database");
|
||||
@ -58,35 +57,6 @@ pub fn run() {
|
||||
.plugin(tauri_plugin_shell::init())
|
||||
.plugin(tauri_plugin_http::init())
|
||||
.manage(app_state)
|
||||
.setup(|app| {
|
||||
// Restore persistent browser windows from previous session
|
||||
let app_handle = app.handle().clone();
|
||||
let state: tauri::State<AppState> = app.state();
|
||||
|
||||
// Clone Arc fields for 'static lifetime
|
||||
let db = state.db.clone();
|
||||
let settings = state.settings.clone();
|
||||
let app_data_dir = state.app_data_dir.clone();
|
||||
let integration_webviews = state.integration_webviews.clone();
|
||||
|
||||
tauri::async_runtime::spawn(async move {
|
||||
let app_state = AppState {
|
||||
db,
|
||||
settings,
|
||||
app_data_dir,
|
||||
integration_webviews,
|
||||
};
|
||||
|
||||
if let Err(e) =
|
||||
commands::integrations::restore_persistent_webviews(&app_handle, &app_state)
|
||||
.await
|
||||
{
|
||||
tracing::warn!("Failed to restore persistent webviews: {}", e);
|
||||
}
|
||||
});
|
||||
|
||||
Ok(())
|
||||
})
|
||||
.invoke_handler(tauri::generate_handler![
|
||||
// DB / Issue CRUD
|
||||
commands::db::create_issue,
|
||||
@ -103,11 +73,18 @@ pub fn run() {
|
||||
commands::analysis::upload_log_file,
|
||||
commands::analysis::detect_pii,
|
||||
commands::analysis::apply_redactions,
|
||||
commands::image::upload_image_attachment,
|
||||
commands::image::list_image_attachments,
|
||||
commands::image::delete_image_attachment,
|
||||
commands::image::upload_paste_image,
|
||||
// AI
|
||||
commands::ai::analyze_logs,
|
||||
commands::ai::chat_message,
|
||||
commands::ai::test_provider_connection,
|
||||
commands::ai::list_providers,
|
||||
commands::system::save_ai_provider,
|
||||
commands::system::load_ai_providers,
|
||||
commands::system::delete_ai_provider,
|
||||
// Docs
|
||||
commands::docs::generate_rca,
|
||||
commands::docs::generate_postmortem,
|
||||
@ -128,7 +105,6 @@ pub fn run() {
|
||||
commands::integrations::save_integration_config,
|
||||
commands::integrations::get_integration_config,
|
||||
commands::integrations::get_all_integration_configs,
|
||||
commands::integrations::add_ado_comment,
|
||||
// System / Settings
|
||||
commands::system::check_ollama_installed,
|
||||
commands::system::get_ollama_install_guide,
|
||||
@ -140,10 +116,48 @@ pub fn run() {
|
||||
commands::system::get_settings,
|
||||
commands::system::update_settings,
|
||||
commands::system::get_audit_log,
|
||||
commands::system::save_ai_provider,
|
||||
commands::system::load_ai_providers,
|
||||
commands::system::delete_ai_provider,
|
||||
])
|
||||
.run(tauri::generate_context!())
|
||||
.expect("Error running Troubleshooting and RCA Assistant application");
|
||||
}
|
||||
|
||||
/// Determine the application data directory.
|
||||
fn dirs_data_dir() -> std::path::PathBuf {
|
||||
if let Ok(dir) = std::env::var("TFTSR_DATA_DIR") {
|
||||
return std::path::PathBuf::from(dir);
|
||||
}
|
||||
|
||||
// Use platform-appropriate data directory
|
||||
#[cfg(target_os = "linux")]
|
||||
{
|
||||
if let Ok(xdg) = std::env::var("XDG_DATA_HOME") {
|
||||
return std::path::PathBuf::from(xdg).join("trcaa");
|
||||
}
|
||||
if let Ok(home) = std::env::var("HOME") {
|
||||
return std::path::PathBuf::from(home)
|
||||
.join(".local")
|
||||
.join("share")
|
||||
.join("trcaa");
|
||||
}
|
||||
}
|
||||
|
||||
#[cfg(target_os = "macos")]
|
||||
{
|
||||
if let Ok(home) = std::env::var("HOME") {
|
||||
return std::path::PathBuf::from(home)
|
||||
.join("Library")
|
||||
.join("Application Support")
|
||||
.join("trcaa");
|
||||
}
|
||||
}
|
||||
|
||||
#[cfg(target_os = "windows")]
|
||||
{
|
||||
if let Ok(appdata) = std::env::var("APPDATA") {
|
||||
return std::path::PathBuf::from(appdata).join("trcaa");
|
||||
}
|
||||
}
|
||||
|
||||
// Fallback
|
||||
std::path::PathBuf::from("./trcaa-data")
|
||||
}
|
||||
|
||||
165
src/components/ImageGallery.tsx
Normal file
165
src/components/ImageGallery.tsx
Normal file
@ -0,0 +1,165 @@
|
||||
import React, { useState, useRef, useEffect } from "react";
|
||||
import { X, AlertTriangle, ExternalLink, Image as ImageIcon } from "lucide-react";
|
||||
import type { ImageAttachment } from "@/lib/tauriCommands";
|
||||
|
||||
interface ImageGalleryProps {
|
||||
images: ImageAttachment[];
|
||||
onDelete?: (attachment: ImageAttachment) => void;
|
||||
showWarning?: boolean;
|
||||
}
|
||||
|
||||
export function ImageGallery({ images, onDelete, showWarning = true }: ImageGalleryProps) {
|
||||
const [selectedImage, setSelectedImage] = useState<ImageAttachment | null>(null);
|
||||
const [isModalOpen, setIsModalOpen] = useState(false);
|
||||
const modalRef = useRef<HTMLDivElement>(null);
|
||||
|
||||
useEffect(() => {
|
||||
const handleKeyDown = (e: KeyboardEvent) => {
|
||||
if (e.key === "Escape" && isModalOpen) {
|
||||
setIsModalOpen(false);
|
||||
setSelectedImage(null);
|
||||
}
|
||||
};
|
||||
window.addEventListener("keydown", handleKeyDown);
|
||||
return () => window.removeEventListener("keydown", handleKeyDown);
|
||||
}, [isModalOpen]);
|
||||
|
||||
if (images.length === 0) return null;
|
||||
|
||||
const base64ToDataUrl = (base64: string, mimeType: string): string => {
|
||||
if (base64.startsWith("data:image/")) {
|
||||
return base64;
|
||||
}
|
||||
return `data:${mimeType};base64,${base64}`;
|
||||
};
|
||||
|
||||
const getPreviewUrl = (attachment: ImageAttachment): string => {
|
||||
if (attachment.file_path && attachment.file_path.length > 0) {
|
||||
return `file://${attachment.file_path}`;
|
||||
}
|
||||
return base64ToDataUrl(attachment.upload_hash, attachment.mime_type);
|
||||
};
|
||||
|
||||
const isWebSource = (image: ImageAttachment): boolean => {
|
||||
return image.file_path.length > 0 &&
|
||||
(image.file_path.startsWith("http://") ||
|
||||
image.file_path.startsWith("https://"));
|
||||
};
|
||||
|
||||
return (
|
||||
<div className="space-y-4">
|
||||
{showWarning && (
|
||||
<div className="bg-amber-100 border border-amber-300 text-amber-800 p-3 rounded-md flex items-center gap-2">
|
||||
<AlertTriangle className="w-5 h-5 flex-shrink-0" />
|
||||
<span className="text-sm">
|
||||
⚠️ PII cannot be automatically redacted from images. Use at your own risk.
|
||||
</span>
|
||||
</div>
|
||||
)}
|
||||
|
||||
{images.some(img => isWebSource(img)) && (
|
||||
<div className="bg-red-100 border border-red-300 text-red-800 p-3 rounded-md flex items-center gap-2">
|
||||
<ExternalLink className="w-5 h-5 flex-shrink-0" />
|
||||
<span className="text-sm">
|
||||
⚠️ Some images appear to be from web sources. Ensure you have permission to share.
|
||||
</span>
|
||||
</div>
|
||||
)}
|
||||
|
||||
<div className="grid grid-cols-2 sm:grid-cols-3 md:grid-cols-4 lg:grid-cols-5 gap-4">
|
||||
{images.map((image, idx) => (
|
||||
<div key={image.id} className="group relative rounded-lg overflow-hidden bg-gray-100 border border-gray-200">
|
||||
<button
|
||||
onClick={() => {
|
||||
setSelectedImage(image);
|
||||
setIsModalOpen(true);
|
||||
}}
|
||||
className="w-full aspect-video object-cover"
|
||||
>
|
||||
<img
|
||||
src={getPreviewUrl(image)}
|
||||
alt={image.file_name}
|
||||
className="w-full h-full object-cover transition-transform group-hover:scale-110"
|
||||
loading="lazy"
|
||||
/>
|
||||
</button>
|
||||
<div className="p-2">
|
||||
<p className="text-xs text-gray-700 truncate" title={image.file_name}>
|
||||
{image.file_name}
|
||||
</p>
|
||||
<p className="text-xs text-gray-500">
|
||||
{image.is_paste ? "Paste" : "Upload"} · {(image.file_size / 1024).toFixed(1)} KB
|
||||
</p>
|
||||
</div>
|
||||
{onDelete && (
|
||||
<button
|
||||
onClick={(e) => {
|
||||
e.stopPropagation();
|
||||
onDelete(image);
|
||||
}}
|
||||
className="absolute top-1 right-1 p-1 bg-white/80 hover:bg-white rounded-md text-gray-600 hover:text-red-600 transition-colors opacity-0 group-hover:opacity-100"
|
||||
title="Delete image"
|
||||
>
|
||||
<X className="w-4 h-4" />
|
||||
</button>
|
||||
)}
|
||||
</div>
|
||||
))}
|
||||
</div>
|
||||
|
||||
{isModalOpen && selectedImage && (
|
||||
<div
|
||||
className="fixed inset-0 bg-black/50 z-50 flex items-center justify-center p-4"
|
||||
onClick={() => {
|
||||
setIsModalOpen(false);
|
||||
setSelectedImage(null);
|
||||
}}
|
||||
>
|
||||
<div
|
||||
ref={modalRef}
|
||||
className="bg-white rounded-lg overflow-hidden max-w-4xl max-h-[90vh] flex flex-col"
|
||||
onClick={(e) => e.stopPropagation()}
|
||||
>
|
||||
<div className="bg-gray-100 p-4 flex items-center justify-between border-b">
|
||||
<div className="flex items-center gap-2">
|
||||
<ImageIcon className="w-5 h-5 text-gray-600" />
|
||||
<h3 className="font-medium">{selectedImage.file_name}</h3>
|
||||
</div>
|
||||
<button
|
||||
onClick={() => {
|
||||
setIsModalOpen(false);
|
||||
setSelectedImage(null);
|
||||
}}
|
||||
className="p-2 hover:bg-gray-200 rounded-lg transition-colors"
|
||||
>
|
||||
<X className="w-5 h-5" />
|
||||
</button>
|
||||
</div>
|
||||
<div className="flex-1 overflow-auto bg-gray-900 flex items-center justify-center p-8">
|
||||
<img
|
||||
src={getPreviewUrl(selectedImage)}
|
||||
alt={selectedImage.file_name}
|
||||
className="max-w-full max-h-[60vh] object-contain"
|
||||
/>
|
||||
</div>
|
||||
<div className="bg-gray-50 p-4 border-t text-sm space-y-2">
|
||||
<div className="flex gap-4">
|
||||
<div>
|
||||
<span className="text-gray-500">Type:</span> {selectedImage.mime_type}
|
||||
</div>
|
||||
<div>
|
||||
<span className="text-gray-500">Size:</span> {(selectedImage.file_size / 1024).toFixed(2)} KB
|
||||
</div>
|
||||
<div>
|
||||
<span className="text-gray-500">Source:</span> {selectedImage.is_paste ? "Paste" : "File"}
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
)}
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
export default ImageGallery;
|
||||
@ -100,6 +100,7 @@ export interface ResolutionStep {
|
||||
export interface IssueDetail {
|
||||
issue: Issue;
|
||||
log_files: LogFile[];
|
||||
image_attachments: ImageAttachment[];
|
||||
resolution_steps: ResolutionStep[];
|
||||
conversations: AiConversation[];
|
||||
}
|
||||
@ -145,6 +146,19 @@ export interface LogFile {
|
||||
redacted: boolean;
|
||||
}
|
||||
|
||||
export interface ImageAttachment {
|
||||
id: string;
|
||||
issue_id: string;
|
||||
file_name: string;
|
||||
file_path: string;
|
||||
file_size: number;
|
||||
mime_type: string;
|
||||
upload_hash: string;
|
||||
uploaded_at: string;
|
||||
pii_warning_acknowledged: boolean;
|
||||
is_paste: boolean;
|
||||
}
|
||||
|
||||
export interface PiiSpan {
|
||||
id: string;
|
||||
pii_type: string;
|
||||
@ -263,6 +277,18 @@ export const listProvidersCmd = () => invoke<ProviderInfo[]>("list_providers");
|
||||
export const uploadLogFileCmd = (issueId: string, filePath: string) =>
|
||||
invoke<LogFile>("upload_log_file", { issueId, filePath });
|
||||
|
||||
export const uploadImageAttachmentCmd = (issueId: string, filePath: string) =>
|
||||
invoke<ImageAttachment>("upload_image_attachment", { issueId, filePath });
|
||||
|
||||
export const uploadPasteImageCmd = (issueId: string, base64Image: string, mimeType: string) =>
|
||||
invoke<ImageAttachment>("upload_paste_image", { issueId, base64Image, mimeType });
|
||||
|
||||
export const listImageAttachmentsCmd = (issueId: string) =>
|
||||
invoke<ImageAttachment[]>("list_image_attachments", { issueId });
|
||||
|
||||
export const deleteImageAttachmentCmd = (attachmentId: string) =>
|
||||
invoke<void>("delete_image_attachment", { attachmentId });
|
||||
|
||||
export const detectPiiCmd = (logFileId: string) =>
|
||||
invoke<PiiDetectionResult>("detect_pii", { logFileId });
|
||||
|
||||
@ -367,17 +393,6 @@ export const updateSettingsCmd = (partialSettings: Partial<AppSettings>) =>
|
||||
export const getAuditLogCmd = (filter: AuditFilter) =>
|
||||
invoke<AuditEntry[]>("get_audit_log", { filter });
|
||||
|
||||
// ─── AI Provider Persistence ──────────────────────────────────────────────────
|
||||
|
||||
export const saveAiProviderCmd = (provider: ProviderConfig) =>
|
||||
invoke<void>("save_ai_provider", { provider });
|
||||
|
||||
export const loadAiProvidersCmd = () =>
|
||||
invoke<ProviderConfig[]>("load_ai_providers");
|
||||
|
||||
export const deleteAiProviderCmd = (name: string) =>
|
||||
invoke<void>("delete_ai_provider", { name });
|
||||
|
||||
// ─── OAuth & Integrations ─────────────────────────────────────────────────────
|
||||
|
||||
export interface OAuthInitResponse {
|
||||
@ -428,16 +443,8 @@ export interface IntegrationConfig {
|
||||
space_key?: string;
|
||||
}
|
||||
|
||||
export const authenticateWithWebviewCmd = (
|
||||
service: string,
|
||||
baseUrl: string,
|
||||
projectName?: string
|
||||
) =>
|
||||
invoke<WebviewAuthResponse>("authenticate_with_webview", {
|
||||
service,
|
||||
baseUrl,
|
||||
projectName,
|
||||
});
|
||||
export const authenticateWithWebviewCmd = (service: string, baseUrl: string, projectName?: string) =>
|
||||
invoke<WebviewAuthResponse>("authenticate_with_webview", { service, baseUrl, projectName });
|
||||
|
||||
export const extractCookiesFromWebviewCmd = (service: string, webviewId: string) =>
|
||||
invoke<ConnectionResult>("extract_cookies_from_webview", { service, webviewId });
|
||||
@ -456,5 +463,13 @@ export const getIntegrationConfigCmd = (service: string) =>
|
||||
export const getAllIntegrationConfigsCmd = () =>
|
||||
invoke<IntegrationConfig[]>("get_all_integration_configs");
|
||||
|
||||
export const addAdoCommentCmd = (workItemId: number, commentText: string) =>
|
||||
invoke<string>("add_ado_comment", { workItemId, commentText });
|
||||
// ─── AI Provider Configuration ────────────────────────────────────────────────
|
||||
|
||||
export const saveAiProviderCmd = (config: ProviderConfig) =>
|
||||
invoke<void>("save_ai_provider", { config });
|
||||
|
||||
export const loadAiProvidersCmd = () =>
|
||||
invoke<ProviderConfig[]>("load_ai_providers");
|
||||
|
||||
export const deleteAiProviderCmd = (name: string) =>
|
||||
invoke<void>("delete_ai_provider", { name });
|
||||
|
||||
@ -1,16 +1,22 @@
|
||||
import React, { useState, useCallback } from "react";
|
||||
import React, { useState, useCallback, useRef, useEffect } from "react";
|
||||
import { useNavigate, useParams } from "react-router-dom";
|
||||
import { Upload, File, Trash2, ShieldCheck } from "lucide-react";
|
||||
import { Upload, File, Trash2, ShieldCheck, AlertTriangle, Image as ImageIcon } from "lucide-react";
|
||||
import { Button, Card, CardHeader, CardTitle, CardContent, Badge } from "@/components/ui";
|
||||
import { PiiDiffViewer } from "@/components/PiiDiffViewer";
|
||||
import { useSessionStore } from "@/stores/sessionStore";
|
||||
import {
|
||||
uploadLogFileCmd,
|
||||
detectPiiCmd,
|
||||
uploadImageAttachmentCmd,
|
||||
uploadPasteImageCmd,
|
||||
listImageAttachmentsCmd,
|
||||
deleteImageAttachmentCmd,
|
||||
type LogFile,
|
||||
type PiiSpan,
|
||||
type PiiDetectionResult,
|
||||
type ImageAttachment,
|
||||
} from "@/lib/tauriCommands";
|
||||
import ImageGallery from "@/components/ImageGallery";
|
||||
|
||||
export default function LogUpload() {
|
||||
const { id } = useParams<{ id: string }>();
|
||||
@ -18,11 +24,14 @@ export default function LogUpload() {
|
||||
const { piiSpans, approvedRedactions, setPiiSpans, setApprovedRedactions } = useSessionStore();
|
||||
|
||||
const [files, setFiles] = useState<{ file: File; uploaded?: LogFile }[]>([]);
|
||||
const [images, setImages] = useState<ImageAttachment[]>([]);
|
||||
const [piiResult, setPiiResult] = useState<PiiDetectionResult | null>(null);
|
||||
const [isUploading, setIsUploading] = useState(false);
|
||||
const [isDetecting, setIsDetecting] = useState(false);
|
||||
const [error, setError] = useState<string | null>(null);
|
||||
|
||||
const fileInputRef = useRef<HTMLInputElement>(null);
|
||||
|
||||
const handleDrop = useCallback(
|
||||
(e: React.DragEvent) => {
|
||||
e.preventDefault();
|
||||
@ -96,9 +105,136 @@ export default function LogUpload() {
|
||||
}
|
||||
};
|
||||
|
||||
const handleImageDrop = useCallback(
|
||||
(e: React.DragEvent) => {
|
||||
e.preventDefault();
|
||||
const droppedFiles = Array.from(e.dataTransfer.files);
|
||||
const imageFiles = droppedFiles.filter((f) => f.type.startsWith("image/"));
|
||||
|
||||
if (imageFiles.length > 0) {
|
||||
handleImagesUpload(imageFiles);
|
||||
}
|
||||
},
|
||||
[id]
|
||||
);
|
||||
|
||||
const handleImageFileSelect = (e: React.ChangeEvent<HTMLInputElement>) => {
|
||||
if (e.target.files) {
|
||||
const selected = Array.from(e.target.files).filter((f) => f.type.startsWith("image/"));
|
||||
if (selected.length > 0) {
|
||||
handleImagesUpload(selected);
|
||||
}
|
||||
}
|
||||
};
|
||||
|
||||
const handlePaste = useCallback(
|
||||
async (e: React.ClipboardEvent) => {
|
||||
const items = e.clipboardData?.items;
|
||||
const imageItems = items ? Array.from(items).filter((item: DataTransferItem) => item.type.startsWith("image/")) : [];
|
||||
|
||||
for (const item of imageItems) {
|
||||
const file = item.getAsFile();
|
||||
if (file) {
|
||||
const reader = new FileReader();
|
||||
reader.onload = async () => {
|
||||
const base64Data = reader.result as string;
|
||||
try {
|
||||
const result = await uploadPasteImageCmd(id || "", base64Data, file.type);
|
||||
setImages((prev) => [...prev, result]);
|
||||
} catch (err) {
|
||||
setError(String(err));
|
||||
}
|
||||
};
|
||||
reader.readAsDataURL(file);
|
||||
}
|
||||
}
|
||||
},
|
||||
[id]
|
||||
);
|
||||
|
||||
const handleImagesUpload = async (imageFiles: File[]) => {
|
||||
if (!id || imageFiles.length === 0) return;
|
||||
|
||||
setIsUploading(true);
|
||||
setError(null);
|
||||
try {
|
||||
const uploaded = await Promise.all(
|
||||
imageFiles.map(async (file) => {
|
||||
const result = await uploadImageAttachmentCmd(id, file.name);
|
||||
return result;
|
||||
})
|
||||
);
|
||||
setImages((prev) => [...prev, ...uploaded]);
|
||||
} catch (err) {
|
||||
setError(String(err));
|
||||
} finally {
|
||||
setIsUploading(false);
|
||||
}
|
||||
};
|
||||
|
||||
const handleDeleteImage = async (image: ImageAttachment) => {
|
||||
try {
|
||||
await deleteImageAttachmentCmd(image.id);
|
||||
setImages((prev) => prev.filter((img) => img.id !== image.id));
|
||||
} catch (err) {
|
||||
setError(String(err));
|
||||
}
|
||||
};
|
||||
|
||||
const fileToBase64 = (file: File): Promise<string> => {
|
||||
return new Promise((resolve, reject) => {
|
||||
const reader = new FileReader();
|
||||
reader.onload = () => resolve(reader.result as string);
|
||||
reader.onerror = (err) => reject(err);
|
||||
reader.readAsDataURL(file);
|
||||
});
|
||||
};
|
||||
|
||||
|
||||
const allUploaded = files.length > 0 && files.every((f) => f.uploaded);
|
||||
const piiReviewed = piiResult != null;
|
||||
|
||||
useEffect(() => {
|
||||
const handleGlobalPaste = (e: ClipboardEvent) => {
|
||||
if (document.activeElement?.tagName === "INPUT" ||
|
||||
document.activeElement?.tagName === "TEXTAREA" ||
|
||||
(document.activeElement as HTMLElement)?.isContentEditable || false) {
|
||||
return;
|
||||
}
|
||||
|
||||
const items = e.clipboardData?.items;
|
||||
const imageItems = items ? Array.from(items).filter((item: DataTransferItem) => item.type.startsWith("image/")) : [];
|
||||
|
||||
for (const item of imageItems) {
|
||||
const file = item.getAsFile();
|
||||
if (file) {
|
||||
e.preventDefault();
|
||||
const reader = new FileReader();
|
||||
reader.onload = async () => {
|
||||
const base64Data = reader.result as string;
|
||||
try {
|
||||
const result = await uploadPasteImageCmd(id || "", base64Data, file.type);
|
||||
setImages((prev) => [...prev, result]);
|
||||
} catch (err) {
|
||||
setError(String(err));
|
||||
}
|
||||
};
|
||||
reader.readAsDataURL(file);
|
||||
break;
|
||||
}
|
||||
}
|
||||
};
|
||||
|
||||
window.addEventListener("paste", handleGlobalPaste);
|
||||
return () => window.removeEventListener("paste", handleGlobalPaste);
|
||||
}, [id]);
|
||||
|
||||
useEffect(() => {
|
||||
if (id) {
|
||||
listImageAttachmentsCmd(id).then(setImages).catch(setError);
|
||||
}
|
||||
}, [id]);
|
||||
|
||||
return (
|
||||
<div className="p-6 space-y-6">
|
||||
<div>
|
||||
@ -165,6 +301,87 @@ export default function LogUpload() {
|
||||
</Card>
|
||||
)}
|
||||
|
||||
{/* Image Upload */}
|
||||
{id && (
|
||||
<>
|
||||
<div>
|
||||
<h2 className="text-2xl font-semibold flex items-center gap-2">
|
||||
<ImageIcon className="w-6 h-6" />
|
||||
Image Attachments
|
||||
</h2>
|
||||
<p className="text-muted-foreground mt-1">
|
||||
Upload or paste screenshots and images.
|
||||
</p>
|
||||
</div>
|
||||
|
||||
{/* Image drop zone */}
|
||||
<div
|
||||
onDragOver={(e) => e.preventDefault()}
|
||||
onDrop={handleImageDrop}
|
||||
className="border-2 border-dashed border-primary/30 rounded-lg p-8 text-center hover:border-primary transition-colors cursor-pointer bg-primary/5"
|
||||
onClick={() => document.getElementById("image-input")?.click()}
|
||||
>
|
||||
<Upload className="w-8 h-8 mx-auto text-primary mb-2" />
|
||||
<p className="text-sm text-muted-foreground">
|
||||
Drag and drop images here, or click to browse
|
||||
</p>
|
||||
<p className="text-xs text-muted-foreground mt-2">
|
||||
Supported: PNG, JPEG, GIF, WebP, SVG
|
||||
</p>
|
||||
<input
|
||||
id="image-input"
|
||||
type="file"
|
||||
accept="image/*"
|
||||
className="hidden"
|
||||
onChange={handleImageFileSelect}
|
||||
/>
|
||||
</div>
|
||||
|
||||
{/* Paste button */}
|
||||
<div className="flex items-center gap-2">
|
||||
<Button
|
||||
onClick={async (e) => {
|
||||
e.preventDefault();
|
||||
document.execCommand("paste");
|
||||
}}
|
||||
variant="secondary"
|
||||
>
|
||||
Paste from Clipboard
|
||||
</Button>
|
||||
<span className="text-xs text-muted-foreground">
|
||||
Use Ctrl+V / Cmd+V or the button above to paste images
|
||||
</span>
|
||||
</div>
|
||||
|
||||
{/* PII warning for images */}
|
||||
<div className="bg-amber-50 border border-amber-200 rounded-md p-3">
|
||||
<AlertTriangle className="w-5 h-5 text-amber-600 inline mr-2" />
|
||||
<span className="text-sm text-amber-800">
|
||||
⚠️ PII cannot be automatically redacted from images. Use at your own risk.
|
||||
</span>
|
||||
</div>
|
||||
|
||||
{/* Image Gallery */}
|
||||
{images.length > 0 && (
|
||||
<Card>
|
||||
<CardHeader>
|
||||
<CardTitle className="text-lg flex items-center gap-2">
|
||||
<ImageIcon className="w-5 h-5" />
|
||||
Attached Images ({images.length})
|
||||
</CardTitle>
|
||||
</CardHeader>
|
||||
<CardContent>
|
||||
<ImageGallery
|
||||
images={images}
|
||||
onDelete={handleDeleteImage}
|
||||
showWarning={false}
|
||||
/>
|
||||
</CardContent>
|
||||
</Card>
|
||||
)}
|
||||
</>
|
||||
)}
|
||||
|
||||
{/* PII Detection */}
|
||||
{allUploaded && (
|
||||
<Card>
|
||||
|
||||
@ -21,6 +21,7 @@ const mockIssueDetail = {
|
||||
tags: "[]",
|
||||
},
|
||||
log_files: [],
|
||||
image_attachments: [],
|
||||
resolution_steps: [
|
||||
{
|
||||
id: "step-1",
|
||||
|
||||
@ -1,56 +0,0 @@
|
||||
# Fix: build-linux-arm64 — Switch to Ubuntu 22.04 with ports mirror
|
||||
|
||||
## Description
|
||||
|
||||
The `build-linux-arm64` CI job failed repeatedly with
|
||||
`E: Unable to correct problems, you have held broken packages` during the
|
||||
Install dependencies step. Root cause: `rust:1.88-slim` (Debian Bookworm) uses a single
|
||||
mirror for all architectures. When both `[arch=amd64]` and `[arch=arm64]` entries point at
|
||||
the same Debian repo, apt's dependency resolver hits unavoidable conflicts — the `binary-all`
|
||||
package index is duplicated and certain `-dev` package pairs cannot be co-installed because
|
||||
they lack `Multi-Arch: same`. This is a structural Debian single-mirror multiarch limitation
|
||||
that cannot be fixed by tweaking `sources.list`.
|
||||
|
||||
Ubuntu 22.04 solves this by routing arm64 through a separate mirror:
|
||||
`ports.ubuntu.com/ubuntu-ports`. amd64 and arm64 packages come from entirely different repos,
|
||||
eliminating all cross-arch index overlaps and resolution conflicts.
|
||||
|
||||
## Acceptance Criteria
|
||||
|
||||
- `build-linux-arm64` Install dependencies step completes without apt errors
|
||||
- `ubuntu:22.04` is the container image for the arm64 job
|
||||
- Ubuntu's `ports.ubuntu.com/ubuntu-ports` is used for arm64 packages
|
||||
- `libayatana-appindicator3-dev:arm64` is removed (no tray icon in this app)
|
||||
- Rust is installed via `rustup` (not pre-installed in Ubuntu base)
|
||||
- All 51 frontend tests pass
|
||||
- YAML is syntactically valid
|
||||
|
||||
## Work Implemented
|
||||
|
||||
### `.gitea/workflows/auto-tag.yml`
|
||||
|
||||
- **Container**: `rust:1.88-slim` → `ubuntu:22.04` for `build-linux-arm64` job
|
||||
- **Install dependencies step**: Full replacement
|
||||
- Step 1: Host tools + aarch64 cross-compiler (amd64 packages, installed before multiarch registration)
|
||||
- Step 2: Register arm64 architecture; `sed` existing `sources.list` entries to `[arch=amd64]`; add `arm64-ports.list` pointing at `ports.ubuntu.com/ubuntu-ports jammy`
|
||||
- Step 3: ARM64 dev libs (`libwebkit2gtk-4.1-dev`, `libssl-dev`, `libgtk-3-dev`, `librsvg2-dev`) — `libayatana-appindicator3-dev:arm64` removed
|
||||
- Step 4: Node.js via NodeSource
|
||||
- Step 5: Rust 1.88.0 via `rustup --no-modify-path`; `$HOME/.cargo/bin` appended to `$GITHUB_PATH`
|
||||
- **Build step**: Added `source "$HOME/.cargo/env"` as first line (belt-and-suspenders for Rust PATH)
|
||||
|
||||
### `tests/unit/releaseWorkflowCrossPlatformArtifacts.test.ts`
|
||||
|
||||
- Added new test: `"uses Ubuntu 22.04 with ports mirror for arm64 cross-compile"` — asserts workflow contains `ubuntu:22.04`, `ports.ubuntu.com/ubuntu-ports`, and `jammy`
|
||||
- All previously passing assertions continue to pass (build step env vars and upload paths unchanged)
|
||||
|
||||
### `docs/wiki/CICD-Pipeline.md`
|
||||
|
||||
- `build-linux-arm64` job entry now mentions Ubuntu 22.04 + ports mirror
|
||||
- New Known Issue entry: **Debian Multiarch Breaks arm64 Cross-Compile** — documents the root cause and the Ubuntu 22.04 fix for future reference
|
||||
|
||||
## Testing Needed
|
||||
|
||||
- [ ] YAML validation: `python3 -c "import yaml; yaml.safe_load(open('.gitea/workflows/auto-tag.yml'))" && echo OK` — **PASSED**
|
||||
- [ ] Frontend tests: `npm run test:run` — **51/51 PASSED** (50 existing + 1 new)
|
||||
- [ ] CI integration: Push branch → merge PR → observe `build-linux-arm64` Install dependencies step completes without `held broken packages` error
|
||||
- [ ] Verify arm64 `.deb`, `.rpm`, `.AppImage` artifacts are uploaded to the Gitea release
|
||||
Loading…
Reference in New Issue
Block a user