tftsr-devops_investigation/tests/unit/kubernetesCommands.test.ts

171 lines
4.9 KiB
TypeScript
Raw Permalink Normal View History

import { describe, it, expect, vi, beforeEach } from "vitest";
import { invoke } from "@tauri-apps/api/core";
import * as tauriCommands from "@/lib/tauriCommands";
// Mock Tauri invoke
vi.mock("@tauri-apps/api/core");
feat(k8s): implement clean-room Kubernetes management GUI - Backend: kube module with ClusterClient, PortForwardSession, RefreshRegistry - 7 Tauri IPC commands: add_cluster, remove_cluster, list_clusters, start_port_forward, stop_port_forward, list_port_forwards, delete_port_forward, shutdown_port_forwards - AppState extended with clusters, port_forwards, refresh_registry fields - Version bumped to 1.1.0 in Cargo.toml and package.json - Auto-tag workflow updated to mark releases as draft (pre-release) - Buy Me A Coffee section added to README.md - Fixed changelog workflow to only include current tag commits - Proper kubeconfig YAML parsing with extract_context and extract_server_url - Added kubeconfig content storage in ClusterClient - Updated PortForwardSession to include cluster_name - Frontend GUI components: ClusterList, PortForwardList, AddClusterModal, PortForwardForm, KubernetesPage - TypeScript types and IPC commands for Kubernetes management - Unit tests for Kubernetes IPC commands (6 tests) - All 332 Rust tests passing - All 98 frontend tests passing - TypeScript type checks passing - Project builds successfully in release mode - Committed and pushed to feature/kubernetes-management branch - Command injection vulnerability fixed with regex validation and max length check (253 chars) - stop_port_forward and shutdown_port_forwards properly kill kubectl child processes via async child management - Temp file cleanup implemented with RAII TempFileCleanup struct created before std::fs::write - discover_pods now parses actual kubectl JSON output - ChildWaitHandle implemented with background task for waiting on kubectl child - PortForwardSession uses Arc<TokioMutex<Option<Child>>> for async-safe child management - Port-forward uses kubectl's dynamic port binding (0) instead of TcpListener - Added shutdown_port_forwards command for app shutdown cleanup - Added cleanup effect in App.tsx to call shutdownPortForwardsCmd on unmount - Database CRUD operations for clusters and port_forwards added to db.rs - validate_resource_name uses lazy_static! for cached Regex to prevent ReDoS - Cluster struct updated to store kubeconfig_content directly instead of kubeconfig_id - Cluster model in db/models.rs updated to use kubeconfig_content field - load_clusters and load_port_forwards commands registered in lib.rs - Temp file cleanup moved to background task in ChildWaitHandle to ensure cleanup after kubectl completes - Unused child_id field removed from ChildWaitHandle - Command validation moved to beginning of start_port_forward before any operations - Fixed lint errors: removed unused imports, fixed React hooks order, updated type annotations - Updated eslint.config.js to properly configure file patterns
2026-06-07 01:27:39 +00:00
type MockedFunction<T = (...args: unknown[]) => unknown> = T & {
mockResolvedValue: (value: unknown) => void;
mockRejectedValue: (error: Error) => void;
};
describe("Kubernetes Management Commands", () => {
beforeEach(() => {
vi.clearAllMocks();
});
describe("addClusterCmd", () => {
it("should call invoke with correct parameters", async () => {
(invoke as MockedFunction).mockResolvedValue({
id: "cluster-1",
name: "production",
context: "prod-context",
cluster_url: "https://prod.example.com",
});
const result = await tauriCommands.addClusterCmd(
"cluster-1",
"production",
"kubeconfig-content"
);
expect(invoke).toHaveBeenCalledWith("add_cluster", {
id: "cluster-1",
name: "production",
kubeconfig_content: "kubeconfig-content",
});
expect(result).toEqual({
id: "cluster-1",
name: "production",
context: "prod-context",
cluster_url: "https://prod.example.com",
});
});
});
describe("removeClusterCmd", () => {
it("should call invoke with cluster id", async () => {
(invoke as MockedFunction).mockResolvedValue(undefined);
await tauriCommands.removeClusterCmd("cluster-1");
expect(invoke).toHaveBeenCalledWith("remove_cluster", { id: "cluster-1" });
});
});
describe("listClustersCmd", () => {
it("should call invoke and return cluster list", async () => {
(invoke as MockedFunction).mockResolvedValue([
{
id: "cluster-1",
name: "production",
context: "prod-context",
cluster_url: "https://prod.example.com",
},
]);
const result = await tauriCommands.listClustersCmd();
expect(invoke).toHaveBeenCalledWith("list_clusters");
expect(result).toHaveLength(1);
expect(result[0].name).toBe("production");
});
});
describe("startPortForwardCmd", () => {
it("should call invoke with port forward request", async () => {
(invoke as MockedFunction).mockResolvedValue({
id: "pf-1",
cluster_id: "cluster-1",
namespace: "default",
pod: "nginx-abc123",
container_port: 80,
local_port: 8080,
status: "Active",
});
const request = {
cluster_id: "cluster-1",
namespace: "default",
pod: "nginx-abc123",
container_port: 80,
};
const result = await tauriCommands.startPortForwardCmd(request);
expect(invoke).toHaveBeenCalledWith("start_port_forward", { request });
expect(result).toEqual({
id: "pf-1",
cluster_id: "cluster-1",
namespace: "default",
pod: "nginx-abc123",
container_port: 80,
local_port: 8080,
status: "Active",
});
});
});
describe("stopPortForwardCmd", () => {
it("should call invoke with session id", async () => {
(invoke as MockedFunction).mockResolvedValue(undefined);
await tauriCommands.stopPortForwardCmd("pf-1");
expect(invoke).toHaveBeenCalledWith("stop_port_forward", { id: "pf-1" });
});
});
describe("listPortForwardsCmd", () => {
it("should call invoke and return port forwards list", async () => {
(invoke as MockedFunction).mockResolvedValue([
{
id: "pf-1",
cluster_id: "cluster-1",
namespace: "default",
pod: "nginx-abc123",
container_port: 80,
local_port: 8080,
status: "Active",
},
]);
const result = await tauriCommands.listPortForwardsCmd();
expect(invoke).toHaveBeenCalledWith("list_port_forwards");
expect(result).toHaveLength(1);
expect(result[0].pod).toBe("nginx-abc123");
});
});
fix(kube): bridge kubeconfig storage to in-memory cluster map and fix UI issues Resolves four bugs in the Kubernetes management interface: 1. **Cluster not found error** - commands/kube.rs::list_nodes (and all other kube resource commands) look up clusters from state.clusters (in-memory map) which was never populated from the kubeconfig_files table. Add a new connect_cluster_from_kubeconfig Tauri command that reads the encrypted kubeconfig from the DB, decrypts it, and inserts a ClusterClient into state.clusters. Wire it into KubernetesPage on initial load and cluster change so the in-memory map is always populated before any kube command runs. 2. **Dropdown selection has no effect** - same root cause as #1; activating a kubeconfig only updated the DB flag but never loaded the client into memory. handleClusterChange now calls connectClusterFromKubeconfigCmd after activation. 3. **GUID shown instead of cluster name** - ClusterOverview displayed the raw internal UUID as the page subtitle. Now accepts a clusterName prop (populated from kubeconfig.context) and renders that instead. ClusterDetails similarly changed to show kubeconfig.context in the header, not the UUID. 4. **Bell icon not clickable** - Hotbar bell button had no onClick handler. Add optional onNotifications / notificationCount props; badge count is now dynamic rather than hardcoded. KubernetesPage wires up a notifications dialog showing active cluster context and a link to the Events section. All changes follow TDD: failing tests written first, then implementation.
2026-06-07 22:39:07 +00:00
describe("connectClusterFromKubeconfigCmd", () => {
it("should call invoke with kubeconfig id", async () => {
(invoke as MockedFunction).mockResolvedValue(undefined);
await tauriCommands.connectClusterFromKubeconfigCmd("kubeconfig-uuid-123");
expect(invoke).toHaveBeenCalledWith("connect_cluster_from_kubeconfig", {
id: "kubeconfig-uuid-123",
});
});
it("should resolve with void on success", async () => {
(invoke as MockedFunction).mockResolvedValue(undefined);
const result = await tauriCommands.connectClusterFromKubeconfigCmd("some-id");
expect(result).toBeUndefined();
});
it("should propagate errors from invoke", async () => {
(invoke as MockedFunction).mockRejectedValue(
new Error("Kubeconfig not found")
);
await expect(
tauriCommands.connectClusterFromKubeconfigCmd("bad-id")
).rejects.toThrow("Kubeconfig not found");
});
});
});